Skip to contentSkip to conversation

Add SPDX License Identifiers

PATCH In review Bhanusree Pola 3 participants 3 messages Feb 21, 2019

lore
Share & tools
lore
#0 lore raw

cover Add SPDX License Identifiers

This series cleans the following checkpatch.pl issues in various files:

"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"

Bhanusree Pola (4):
staging: netlogic: Add SPDX license Identifier
Staging: netlogic: Add SPDX License Identifier
Staging: netlogic: Add SPDX License Identifier
Staging: netlogic: Add SPDX License Identifier

 drivers/staging/netlogic/platform_net.c | 1 +
 drivers/staging/netlogic/platform_net.h | 1 +
 drivers/staging/netlogic/xlr_net.c      | 1 +
 drivers/staging/netlogic/xlr_net.h      | 1 +
 4 files changed, 4 insertions(+)
Signature · 1 line
2.17.1
#1 lore raw
Quoted 9 lines · Bhanusree Pola

This series cleans the following checkpatch.pl issues in various files:

"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"

Bhanusree Pola (4):
staging: netlogic: Add SPDX license Identifier
Staging: netlogic: Add SPDX License Identifier
Staging: netlogic: Add SPDX License Identifier
Staging: netlogic: Add SPDX License Identifier

4 different patches with the same subject line, yet they do different things? That's not ok, sorry, they have to be unique.

Also, please properly "thread" your emails, using git send-email or some other kind of tool, so they show up together, and not as individual stand-alone emails.

thanks,

greg k-h

#2 lore raw
In reply to Bhanusree Pola
Quoted 9 lines · Bhanusree Pola

This series cleans the following checkpatch.pl issues in various files:

"WARNING: Missing or malformed SPDX-License-Identifier tag in line 1"

Bhanusree Pola (4):
staging: netlogic: Add SPDX license Identifier
Staging: netlogic: Add SPDX License Identifier
Staging: netlogic: Add SPDX License Identifier
Staging: netlogic: Add SPDX License Identifier

You should also not have multiple patches with the same subject line. If the files and the change are closely related you could put them all in one patch. Otherwise, you need to find some way to make the subject lines unique.

julia

Quoted 17 lines
 drivers/staging/netlogic/platform_net.c | 1 +
 drivers/staging/netlogic/platform_net.h | 1 +
 drivers/staging/netlogic/xlr_net.c      | 1 +
 drivers/staging/netlogic/xlr_net.h      | 1 +
 4 files changed, 4 insertions(+)

--
2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190221111304.GA29010%40bhanusree-MacBookAir.
For more options, visit https://groups.google.com/d/optout.