Skip to contentSkip to conversation

Staging: most: Replace '--help--' in Kconfig file

PATCH In review Wentao Cai 2 participants 8 messages Mar 11, 2019

Subsystems (2)
lore
Share & tools
lore

Wentao Cai

author
#0 lore raw

cover Staging: most: Replace '--help--' in Kconfig file

Replace '--help--' with 'help' to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts

Wentao Cai (5):
Staging: most: cdev: Replace '--help--' with 'help'
Staging: most: i2c: Replace '--help--' in Kconfig
Staging: most: net: Replace '--help--' in Kconfig
Staging: most: sound: Replace '--help--' in Kconfig file
Staging: most: video: Replace '--help--' in Kconfig

 drivers/staging/most/cdev/Kconfig  | 2 +-
 drivers/staging/most/i2c/Kconfig   | 2 +-
 drivers/staging/most/net/Kconfig   | 2 +-
 drivers/staging/most/sound/Kconfig | 2 +-
 drivers/staging/most/video/Kconfig | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH 1/5 Staging: most: cdev: Replace '--help--' with 'help'

Replace '--help--' with 'help' in Kconfig to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts

---
 drivers/staging/most/cdev/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/cdev/Kconfig +1 -1
index 2b04e26bcbea..2e27e1fce58d 100644
@@ -5,7 +5,7 @@
 config MOST_CDEV
 	tristate "Cdev"
 
-	---help---
+	help
 	  Say Y here if you want to commumicate via character devices.
 
 	  To compile this driver as a module, choose M here: the
Signature · 1 line
2.11.0
author
#2 lore raw

PATCH 2/5 Staging: most: i2c: Replace '--help--' in Kconfig

In reply to Wentao Cai

Replace '--help--' with 'help' to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts

---
 drivers/staging/most/i2c/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/i2c/Kconfig +1 -1
index 79d0ff27f56d..f723f99711bd 100644
@@ -5,7 +5,7 @@
 config MOST_I2C
 	tristate "I2C"
 	depends on I2C
-	---help---
+	help
 	  Say Y here if you want to connect via I2C to network tranceiver.
 
 	  To compile this driver as a module, choose M here: the
Signature · 1 line
2.11.0
author
#3 lore raw

PATCH 3/5 Staging: most: net: Replace '--help--' in Kconfig

In reply to Wentao Cai

Replace '--help--' with 'help' to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts

---
 drivers/staging/most/net/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/net/Kconfig +1 -1
index 795330ba94ef..28040931f7e7 100644
@@ -6,7 +6,7 @@ config MOST_NET
 	tristate "Net"
 	depends on NET
 
-	---help---
+	help
 	  Say Y here if you want to commumicate via a networking device.
 
 	  To compile this driver as a module, choose M here: the
Signature · 1 line
2.11.0
author
#4 lore raw

PATCH 4/5 Staging: most: sound: Replace '--help--' in Kconfig file

In reply to Wentao Cai

Replace '--help--' with 'help' to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts

---
 drivers/staging/most/sound/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/sound/Kconfig +1 -1
index 115262a58a42..5614a999b54e 100644
@@ -6,7 +6,7 @@ config MOST_SOUND
 	tristate "Sound"
 	depends on SND
 	select SND_PCM
-	---help---
+	help
 	  Say Y here if you want to commumicate via ALSA/sound devices.
 
 	  To compile this driver as a module, choose M here: the
Signature · 1 line
2.11.0
author
#5 lore raw

PATCH 5/5 Staging: most: video: Replace '--help--' in Kconfig

In reply to Wentao Cai

Replace '--help--' with 'help' to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts

---
 drivers/staging/most/video/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/most/video/Kconfig +1 -1
index ce6af4f951a6..a458d0c74a0f 100644
@@ -5,7 +5,7 @@
 config MOST_VIDEO
 	tristate "Video"
 	depends on VIDEO_V4L2
-	---help---
+	help
 	  Say Y here if you want to commumicate via Video 4 Linux.
 
 	  To compile this driver as a module, choose M here: the
Signature · 1 line
2.11.0
#6 lore raw
In reply to Wentao Cai
Quoted 9 lines · Wentao Cai

Replace '--help--' with 'help' to silence checkpatch.pl warning:
WARNING: prefer 'help' over '---help---' for new help texts

Wentao Cai (5):
Staging: most: cdev: Replace '--help--' with 'help'
Staging: most: i2c: Replace '--help--' in Kconfig
Staging: most: net: Replace '--help--' in Kconfig
Staging: most: sound: Replace '--help--' in Kconfig file
Staging: most: video: Replace '--help--' in Kconfig

I guess that you are doing the same thing in all cases. So it wold be reasonable for the subjects to all be the same. You have the subdirectory in each case to make them different.

It could also just be one patch, since the change is easy to understand in each case.

julia

Quoted 18 lines
 drivers/staging/most/cdev/Kconfig  | 2 +-
 drivers/staging/most/i2c/Kconfig   | 2 +-
 drivers/staging/most/net/Kconfig   | 2 +-
 drivers/staging/most/sound/Kconfig | 2 +-
 drivers/staging/most/video/Kconfig | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

--
2.11.0

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190311150108.4717-1-etsai042%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#7 lore raw
Quoted 14 lines · Julia Lawall
Quoted 4 lines

I guess that you are doing the same thing in all cases. So it wold be reasonable for the subjects to all be the same. You have the

subdirectory

Quoted 3 lines

in each case to make them different.

It could also just be one patch, since the change is easy to understand

in

Quoted 3 lines

each case.

julia

Thanks Julia, I'll resubmit them in one patch.

Wentao