staging: greybus: alignment should match open parenthesis
Subsystems (3)
PATCH 1/1 staging: greybus: alignment should match open parenthesis
Aligning to open parenthesis
--- drivers/staging/greybus/audio_codec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/greybus/audio_codec.c +4 -4
@@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec, i2s_port =0 ;/* fixed for now */ cportid = data->connection->hd_cport_id; ret =gb_audio_apbridgea_register_cport (data->connection, - i2s_port, cportid, + i2s_port, cportid,AUDIO_APBRIDGEA_DIRECTION_TX );if (ret) { dev_err_ratelimited(module->dev,
@@ -160,7 +160,7 @@ static int gbaudio_module_disable_tx(struct gbaudio_module_info *module, int id) i2s_port =0 ;/* fixed for now */ cportid = data->connection->hd_cport_id; ret =gb_audio_apbridgea_unregister_cport (data->connection, - i2s_port, cportid, + i2s_port, cportid,AUDIO_APBRIDGEA_DIRECTION_TX );if (ret) { dev_err_ratelimited(module->dev,
@@ -205,7 +205,7 @@ static int gbaudio_module_enable_rx(struct gbaudio_codec_info *codec, i2s_port =0 ;/* fixed for now */ cportid = data->connection->hd_cport_id; ret =gb_audio_apbridgea_register_cport (data->connection, - i2s_port, cportid, + i2s_port, cportid,AUDIO_APBRIDGEA_DIRECTION_RX );if (ret) { dev_err_ratelimited(module->dev,
@@ -295,7 +295,7 @@ static int gbaudio_module_disable_rx(struct gbaudio_module_info *module, int id) i2s_port =0 ;/* fixed for now */ cportid = data->connection->hd_cport_id; ret =gb_audio_apbridgea_unregister_cport (data->connection, - i2s_port, cportid, + i2s_port, cportid,AUDIO_APBRIDGEA_DIRECTION_RX );if (ret) { dev_err_ratelimited(module->dev,
Signature · 1 line
2.7.4
Quoted 1 line · Payal Kshirsagar
Aligning to open parenthesis
The log message should be in the imperatie, so Align rather than Aligning. Also a sentence should have a period at the end.
Quoted 10 lines
Signed-off-by Payal Kshirsagar <[email protected]>--- drivers/staging/greybus/audio_codec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/greybus/audio_codec.c +0
-0
drivers/staging/greybus/audio_codec.c static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec, · line 74
Quoted 6 lines
drivers/staging/greybus/audio_codec.c +1
-1@@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec, i2s_port =0 ;/* fixed for now */ cportid = data->connection->hd_cport_id; ret =gb_audio_apbridgea_register_cport (data->connection, - i2s_port, cportid, + i2s_port, cportid,AUDIO_APBRIDGEA_DIRECTION_TX );
It's not really an advantage, because the final argument can't be moved. It's better to keep the arguments lined up, as they were.
julia
Quoted 39 lines
drivers/staging/greybus/audio_codec.c +3
-4if (ret) { dev_err_ratelimited(module->dev,@@ -160,7 +160,7 @@ static int gbaudio_module_disable_tx(struct gbaudio_module_info *module, int id) i2s_port =0 ;/* fixed for now */ cportid = data->connection->hd_cport_id; ret =gb_audio_apbridgea_unregister_cport (data->connection, - i2s_port, cportid, + i2s_port, cportid,AUDIO_APBRIDGEA_DIRECTION_TX );if (ret) { dev_err_ratelimited(module->dev,@@ -205,7 +205,7 @@ static int gbaudio_module_enable_rx(struct gbaudio_codec_info *codec, i2s_port =0 ;/* fixed for now */ cportid = data->connection->hd_cport_id; ret =gb_audio_apbridgea_register_cport (data->connection, - i2s_port, cportid, + i2s_port, cportid,AUDIO_APBRIDGEA_DIRECTION_RX );if (ret) { dev_err_ratelimited(module->dev,@@ -295,7 +295,7 @@ static int gbaudio_module_disable_rx(struct gbaudio_module_info *module, int id) i2s_port =0 ;/* fixed for now */ cportid = data->connection->hd_cport_id; ret =gb_audio_apbridgea_unregister_cport (data->connection, - i2s_port, cportid, + i2s_port, cportid,AUDIO_APBRIDGEA_DIRECTION_RX );if (ret) { dev_err_ratelimited(module->dev, --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1553087541-4396-1-git-send-email-payal.s.kshirsagar.98%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 9 lines · Julia Lawall
Quoted 1 line · Payal Kshirsagar
Aligning to open parenthesis
The log message should be in the imperatie, so Align rather than Aligning. Also a sentence should have a period at the end.
Okay, I will take care from next time and will drop this patch. Thanks
payal
Quoted 89 lines
Review
Quoted 7 lines
Signed-off-by Payal Kshirsagar <[email protected]>--- drivers/staging/greybus/audio_codec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)(quoted diff) +0
-0
b/drivers/staging/greybus/audio_codec.cdrivers/staging/greybus/audio_codec.c static int gbaudio_module_enable_tx(struct
Quoted 4 lines
index 08746c8..d62f91f 100644
drivers/staging/greybus/audio_codec.c +0
-0@@ -70,7 +70,7 @@ static int gbaudio_module_enable_tx(struct
gbaudio_codec_info*codec,drivers/staging/greybus/audio_codec.c static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec,
Quoted 6 lines
drivers/staging/greybus/audio_codec.c +1
-1i2s_port =0 ;/* fixed for now */ cportid = data->connection->hd_cport_id; ret = gb_audio_apbridgea_register_cport(data->connection, - i2s_port, cportid, + i2s_port, cportid,
AUDIO_APBRIDGEA_DIRECTION_TX);It's not really an advantage, because the final argument can't be moved. It's better to keep the arguments lined up, as they were.
julia
drivers/staging/greybus/audio_codec.c static int gbaudio_module_disable_tx(struct
Quoted 3 lines
drivers/staging/greybus/audio_codec.c +0
-0if (ret) { dev_err_ratelimited(module->dev,@@ -160,7 +160,7 @@ static int gbaudio_module_disable_tx(struct
gbaudio_module_info*module, int id)drivers/staging/greybus/audio_codec.c static int gbaudio_module_disable_tx(struct gbaudio_module_info *module, int id)
Quoted 5 lines
drivers/staging/greybus/audio_codec.c +1
-1i2s_port =0 ;/* fixed for now */ cportid = data->connection->hd_cport_id; ret = gb_audio_apbridgea_unregister_cport(data->connection, - i2s_port, cportid, + i2s_port,cportid,
Quoted 1 line
AUDIO_APBRIDGEA_DIRECTION_TX);drivers/staging/greybus/audio_codec.c static int gbaudio_module_enable_rx(struct
Quoted 3 lines
if (ret) { dev_err_ratelimited(module->dev,drivers/staging/greybus/audio_codec.c +0
-0@@ -205,7 +205,7 @@ static int gbaudio_module_enable_rx(struct
gbaudio_codec_info*codec,drivers/staging/greybus/audio_codec.c static int gbaudio_module_enable_tx(struct gbaudio_codec_info *codec,
Quoted 6 lines
drivers/staging/greybus/audio_codec.c +1
-1i2s_port =0 ;/* fixed for now */ cportid = data->connection->hd_cport_id; ret = gb_audio_apbridgea_register_cport(data->connection, - i2s_port, cportid, + i2s_port, cportid,
AUDIO_APBRIDGEA_DIRECTION_RX);drivers/staging/greybus/audio_codec.c static int gbaudio_module_disable_rx(struct
Quoted 3 lines
drivers/staging/greybus/audio_codec.c +0
-0if (ret) { dev_err_ratelimited(module->dev,@@ -295,7 +295,7 @@ static int gbaudio_module_disable_rx(struct
gbaudio_module_info*module, int id)drivers/staging/greybus/audio_codec.c static int gbaudio_module_disable_tx(struct gbaudio_module_info *module, int id)
Quoted 5 lines
drivers/staging/greybus/audio_codec.c +1
-1i2s_port =0 ;/* fixed for now */ cportid = data->connection->hd_cport_id; ret = gb_audio_apbridgea_unregister_cport(data->connection, - i2s_port, cportid, + i2s_port,cportid,
Quoted 1 line
AUDIO_APBRIDGEA_DIRECTION_RX);Quoted 7 lines
if (ret) { dev_err_ratelimited(module->dev,--
2.7.4--
You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
Quoted 2 lines
To post to this group, send email to [email protected]. To view this discussion on the web visit
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected]. To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.20.1903201423520.3627%40hadrien
.
For more options, visit https://groups.google.com/d/optout.