Skip to contentSkip to conversation

staging: greybus: cleanup long line in gb_uart_probe()

PATCH In review Ioannis Valasakis 2 participants 2 messages Nov 2, 2018 – Nov 3, 2018

Subsystems (3)
Staging Greybus Greybus UART protocols drivers
lore
Share & tools
lore

Ioannis Valasakis

author
#0 lore raw

PATCH 1/1 staging: greybus: cleanup long line in gb_uart_probe()

Clear line over 80 characters warning in gb_uart_probe() by adding appropriate lines breaks.
Reported by checkpatch

Signed-off-by Ioannis Valasakis <[email protected]>
---
 drivers/staging/greybus/uart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/greybus/uart.c +2 -2
index b3bffe91ae99..735f70c09823 100644
@@ -829,8 +829,8 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
 	if (!gb_tty)
 		return -ENOMEM;
 
-	connection = gb_connection_create(gbphy_dev->bundle,
-					  le16_to_cpu(gbphy_dev->cport_desc->id),
+	connection = gb_connection_create(gbphy_dev->bundle, le16_to_cpu
+					 (gbphy_dev->cport_desc->id),
 					  gb_uart_request_handler);
 	if (IS_ERR(connection)) {
 		retval = PTR_ERR(connection);
Signature · 6 lines
2.19.1


-- 
ta
ioannis
#1 lore raw
Quoted 14 lines · Ioannis Valasakis

Clear line over 80 characters warning in gb_uart_probe() by adding appropriate lines breaks.
Reported by checkpatch

Signed-off-by Ioannis Valasakis <[email protected]>
---
 drivers/staging/greybus/uart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/greybus/uart.c +0 -0
index b3bffe91ae99..735f70c09823 100644

drivers/staging/greybus/uart.c static int gb_uart_probe(struct gbphy_device *gbphy_dev, · line 833

Quoted 7 lines
drivers/staging/greybus/uart.c +2 -2
@@ -829,8 +829,8 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
 	if (!gb_tty)
 		return -ENOMEM;
 
-	connection = gb_connection_create(gbphy_dev->bundle,
-					  le16_to_cpu(gbphy_dev->cport_desc->id),
+	connection = gb_connection_create(gbphy_dev->bundle, le16_to_cpu
+					 (gbphy_dev->cport_desc->id),

This really hides the structure of the code. You can just reduce the indentation in front of the call and then line the remaining argument up with that.

julia

Quoted 18 lines
drivers/staging/greybus/uart.c +0 -1
 					  gb_uart_request_handler);
 	if (IS_ERR(connection)) {
 		retval = PTR_ERR(connection);
--

2.19.1

--
ta
ioannis

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181102232501.GA1571%40kvasir.local.
For more options, visit https://groups.google.com/d/optout.