staging: greybus: remove extra space before tab

PATCH In review Ioannis Valasakis 3 participants 4 messages Nov 2, 2018 – Nov 3, 2018

Subsystems (2)

Staging Greybus

lore

Share & tools

lore

Ioannis Valasakis

author

2018-11-02 23:45 UTC #0 lore raw

PATCH 1/1 staging: greybus: remove extra space before tab

Remove extra spaces before the tab character inside a comment section. Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>

---
 drivers/staging/greybus/greybus_protocols.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/staging/greybus/greybus_protocols.h +2 -2

index 5783f715bdc2..429a952c5200 100644
@@ -918,8 +918,8 @@ struct gb_spi_device_config_response {
  *	0 the default (from @spi_device) is used.
  * @len: size of rx and tx buffers (in bytes)
  * @delay_usecs: microseconds to delay after this transfer before (optionally)
- * 	changing the chipselect status, then starting the next transfer or
- * 	completing this spi_message.
+ *	changing the chipselect status, then starting the next transfer or
+ *	completing this spi_message.
  * @cs_change: affects chipselect after this transfer completes
  * @bits_per_word: select a bits_per_word other than the device default for this
  *	transfer. If 0 the default (from @spi_device) is used.

Signature · 6 lines

2.19.1


-- 
ta
ioannis

Julia Lawall

2018-11-03 06:57 UTC #1 lore raw

Quoted 6 lines · Ioannis Valasakis

Remove extra spaces before the tab character inside a comment section. Reported by checkpatch.
Signed-off-by Ioannis Valasakis <[email protected]>
---
 drivers/staging/greybus/greybus_protocols.h | 4 ++--

You seem to have sent three patches on this file. Greg will want them to be in a series, to reduce ambiguity about how they should be applied.

Likewise for the other files.

julia

Quoted 32 lines

 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/greybus/greybus_protocols.h +2 -3
index 5783f715bdc2..429a952c5200 100644
@@ -918,8 +918,8 @@ struct gb_spi_device_config_response {
  *	0 the default (from @spi_device) is used.
  * @len: size of rx and tx buffers (in bytes)
  * @delay_usecs: microseconds to delay after this transfer before (optionally)
- * 	changing the chipselect status, then starting the next transfer or
- * 	completing this spi_message.
+ *	changing the chipselect status, then starting the next transfer or
+ *	completing this spi_message.
  * @cs_change: affects chipselect after this transfer completes
  * @bits_per_word: select a bits_per_word other than the device default for this
  *	transfer. If 0 the default (from @spi_device) is used.
--
2.19.1
--
ta
ioannis
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181102234508.GA27353%40kvasir.local.
For more options, visit https://groups.google.com/d/optout.

[email protected]

2018-11-03 14:17 UTC #2 lore raw

Quoted 12 lines · Julia Lawall

Quoted 6 lines · Ioannis Valasakis
Remove extra spaces before the tab character inside a comment section. Reported by checkpatch.
Signed-off-by Ioannis Valasakis <[email protected] <javascript:>>
---
 drivers/staging/greybus/greybus_protocols.h | 4 ++-- 

Quoted 8 lines

You seem to have sent three patches on this file. Greg will want them to be in a series, to reduce ambiguity about how they should be applied.
Likewise for the other files.
julia

By series do you mean that I need to create a patchset?

ta
ioannis

Quoted 43 lines

Review
Quoted 3 lines
 1 file changed, 2 insertions(+), 2 deletions(-) 
(quoted diff) +0 -0
b/drivers/staging/greybus/greybus_protocols.h
drivers/staging/greybus/greybus_protocols.h struct gb_spi_device_config_response { · line 920
Quoted 7 lines
index 5783f715bdc2..429a952c5200 100644
drivers/staging/greybus/greybus_protocols.h +0 -0
@@ -918,8 +918,8 @@ struct gb_spi_device_config_response { 
  *        0 the default (from @spi_device) is used. 
  * @len: size of rx and tx buffers (in bytes) 
  * @delay_usecs: microseconds to delay after this transfer before 
(optionally)
drivers/staging/greybus/greybus_protocols.h struct gb_spi_device_config_response { · line 921
Quoted 1 line
drivers/staging/greybus/greybus_protocols.h +0 -1
- *         changing the chipselect status, then starting the next 
transfer or
drivers/staging/greybus/greybus_protocols.h struct gb_spi_device_config_response { · line 921
Quoted 2 lines
drivers/staging/greybus/greybus_protocols.h +1 -1
- *         completing this spi_message. 
+ *        changing the chipselect status, then starting the next 
transfer or
drivers/staging/greybus/greybus_protocols.h struct gb_spi_device_config_response {
Quoted 3 lines
drivers/staging/greybus/greybus_protocols.h +1 -0
+ *        completing this spi_message. 
  * @cs_change: affects chipselect after this transfer completes 
  * @bits_per_word: select a bits_per_word other than the device default 
for this
Quoted 11 lines
drivers/staging/greybus/greybus_protocols.h +0 -0
  *        transfer. If 0 the default (from @spi_device) is used. 
Signature · 9 lines
2.19.1 


-- 
ta 
ioannis 

-- 
You received this message because you are subscribed to the Google 
Groups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected] <javascript:>.
Quoted 1 line
To post to this group, send email to [email protected]
<javascript:>.
Quoted 1 line
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20181102234508.GA27353%40kvasir.local.
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.

Julia Lawall

2018-11-03 14:18 UTC #3 lore raw

Quoted 15 lines · On Sat, 3 Nov 2018, [email protected] wrote:

On Saturday, November 3, 2018 at 6:57:54 AM UTC, Julia Lawall wrote:
On Fri, 2 Nov 2018, Ioannis Valasakis wrote:
> Remove extra spaces before the tab character inside a comment section. > Reported by checkpatch.
>
> Signed-off-by: Ioannis Valasakis <[email protected]>
> ---
> drivers/staging/greybus/greybus_protocols.h | 4 ++--
You seem to have sent three patches on this file. Greg will want them to be in a series, to reduce ambiguity about how they should be applied.

Quoted 6 lines

Likewise for the other files.
julia
By series do you mean that I need to create a patchset?

Yes, that makes the application order clear.

julia

Quoted 44 lines

ta
ioannis
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/greybus_protocols.h b/drivers/staging/greybus/greybus_protocols.h
> index 5783f715bdc2..429a952c5200 100644
> --- a/drivers/staging/greybus/greybus_protocols.h
> +++ b/drivers/staging/greybus/greybus_protocols.h
> @@ -918,8 +918,8 @@ struct gb_spi_device_config_response {
> *        0 the default (from @spi_device) is used.
> * @len: size of rx and tx buffers (in bytes)
> * @delay_usecs: microseconds to delay after this transfer before (optionally)
> - *         changing the chipselect status, then starting the next transfer or
> - *         completing this spi_message.
> + *        changing the chipselect status, then starting the next transfer or
> + *        completing this spi_message.
> * @cs_change: affects chipselect after this transfer completes
> * @bits_per_word: select a bits_per_word other than the device default for this
> *        transfer. If 0 the default (from @spi_device) is used.
> --
> 2.19.1
>
>
> --
> ta
> ioannis
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. > To post to this group, send email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181102234508.GA27353%40kvasir.local.
> For more options, visit https://groups.google.com/d/optout.
>
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/a43ce3ad-9062-4294-a23c-f9898fe44276%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.