Skip to contentSkip to conversation

staging: greybus: fix styling and bool comparison

PATCH In review Ioannis Valasakis 3 participants 8 messages Nov 4, 2018 – Nov 5, 2018

Subsystems (2)
Staging Greybus
lore
Share & tools
lore

Ioannis Valasakis

author
#0 lore raw

cover staging: greybus: fix styling and bool comparison

Fix styling and bool comparison per coccinelle warnings.

Ioannis Valasakis (2):
staging: greybus: remove comparison to BOOL
staging: graybus: match open parentheses

 drivers/staging/greybus/es2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.19.1
author
#1 lore raw

PATCH 1/2 staging: greybus: remove comparison to BOOL

Remove two instances of a comparison to BOOL.
Reported by coccinelle.

Signed-off-by Ioannis Valasakis <[email protected]>
---
 drivers/staging/greybus/es2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/greybus/es2.c +2 -2
index b082d81833a0..afaa6d15c23b 100644
@@ -316,8 +316,8 @@ static struct urb *next_free_urb(struct es2_ap_dev *es2, gfp_t gfp_mask)
 
 	/* Look in our pool of allocated urbs first, as that's the "fastest" */
 	for (i = 0; i < NUM_CPORT_OUT_URB; ++i) {
-		if (es2->cport_out_urb_busy[i] == false &&
-				es2->cport_out_urb_cancelled[i] == false) {
+		if (!es2->cport_out_urb_busy[i] &&
+				!es2->cport_out_urb_cancelled[i]) {
 			es2->cport_out_urb_busy[i] = true;
 			urb = es2->cport_out_urb[i];
 			break;
Signature · 1 line
2.19.1
author
#2 lore raw

PATCH 2/2 staging: graybus: match open parentheses

In reply to Ioannis Valasakis

Match open parentheses by indenting.
Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>
---
 drivers/staging/greybus/es2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/greybus/es2.c +1 -1
index afaa6d15c23b..b4e3d6a3d523 100644
@@ -317,7 +317,7 @@ static struct urb *next_free_urb(struct es2_ap_dev *es2, gfp_t gfp_mask)
 	/* Look in our pool of allocated urbs first, as that's the "fastest" */
 	for (i = 0; i < NUM_CPORT_OUT_URB; ++i) {
 		if (!es2->cport_out_urb_busy[i] &&
-				!es2->cport_out_urb_cancelled[i]) {
+		    !es2->cport_out_urb_cancelled[i]) {
 			es2->cport_out_urb_busy[i] = true;
 			urb = es2->cport_out_urb[i];
 			break;
Signature · 1 line
2.19.1
maintainer
#3 lore raw

Re: [PATCH 2/2] staging: graybus: match open parentheses

Quoted 7 lines · Ioannis Valasakis

Match open parentheses by indenting.
Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>
---
 drivers/staging/greybus/es2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Ah, this is the 2/2 patch, it didn't show up in my searching as you mispelled "greybus" on the Subject: line :(

author
#4 lore raw

Re: [PATCH 2/2] staging: graybus: match open parentheses

Quoted 11 lines · Greg KH
Quoted 7 lines · Ioannis Valasakis

Match open parentheses by indenting.
Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>
---
 drivers/staging/greybus/es2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Ah, this is the 2/2 patch, it didn't show up in my searching as you mispelled "greybus" on the Subject: line :(

Oh, I am sorry about this! Do you still need the whole series of greybus to be send as a patchset? thanks

ioannis

Quoted 1 line
maintainer
#5 lore raw

Re: [PATCH 2/2] staging: graybus: match open parentheses

Quoted 10 lines · Ioannis Valasakis
Quoted 9 lines · Greg KH
Quoted 7 lines · Ioannis Valasakis

Match open parentheses by indenting.
Reported by checkpatch.

Signed-off-by Ioannis Valasakis <[email protected]>
---
 drivers/staging/greybus/es2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 4 lines
Quoted 2 lines

Ah, this is the 2/2 patch, it didn't show up in my searching as you mispelled "greybus" on the Subject: line :(

Oh, I am sorry about this! Do you still need the whole series of greybus to be send as a patchset? thanks

Yes, all of the patches have now been processed by me, so if I did not apply them, please redo and resend.

thanks,

greg k-h

Acked-by on the v1 series
#6 lore raw
In reply to Ioannis Valasakis
Quoted 5 lines · Ioannis Valasakis

Fix styling and bool comparison per coccinelle warnings.

Ioannis Valasakis (2):
staging: greybus: remove comparison to BOOL
staging: graybus: match open parentheses

Acked-by Julia Lawall <[email protected]>
Quoted 15 lines
 drivers/staging/greybus/es2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.19.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1541366816.git.code%40wizofe.uk.
For more options, visit https://groups.google.com/d/optout.

maintainer
#7 lore raw
In reply to Ioannis Valasakis
Quoted 8 lines · Ioannis Valasakis

Fix styling and bool comparison per coccinelle warnings.

Ioannis Valasakis (2):
staging: greybus: remove comparison to BOOL
staging: graybus: match open parentheses

 drivers/staging/greybus/es2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Why isn't this part of the previous patch series?

And I only see 1 patch here, not 2.

There's way too many changes floating around from you for these drivers for me to be able to easily figure out what is going on.
Can you resend the latest version of all of your patches for the greybus drivers, as one single patch series, with the latest "version" number on them, so I know what to review and hopefully apply to the tree?

thanks,

greg k-h