Skip to contentSkip to conversation

net: ax25: Add SPDX License to fix missing License warning

PATCH In review Jules Irenge 3 participants 3 messages Feb 23, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: ax25: Add SPDX License to fix missing License warning

---
 net/ax25/af_ax25.c | 1 +
 1 file changed, 1 insertion(+)
net/ax25/af_ax25.c +1 -0
index 5d01edf8d819..5048790a75f6 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
Signature · 1 line
2.20.1
#1 lore raw
Quoted 1 line · Jules Irenge

I know I never take patches without any changelog text :(

net/ax25/af_ax25.c line 1

Quoted 10 lines
---
 net/ax25/af_ax25.c | 1 +
 1 file changed, 1 insertion(+)
net/ax25/af_ax25.c +1 -0
index 5d01edf8d819..5048790a75f6 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0

That is the incorrect license of this file!

NEVER add or modify a SPDX line if you do not really really really know what you are doing. Putting the wrong license tag on a file is worse than not having any tag at all.

BE VERY CAREFUL ABOUT THESE THINGS, they matter. If you get them wrong, lawyers get very grumpy :)

thanks,

greg k-h

#2 lore raw
In reply to Jules Irenge

For the outreachy application period you should work on drivers/staging. If you want to work on something else, you shouldn't CC the mailing list, and you take the risk that your change won't be applied before th end fo the application period.

julia

Quoted 24 lines · Jules Irenge
---
 net/ax25/af_ax25.c | 1 +
 1 file changed, 1 insertion(+)
net/ax25/af_ax25.c +1 -1
index 5d01edf8d819..5048790a75f6 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
--

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190223111100.13983-1-jbi.octave%40gmail.com.
For more options, visit https://groups.google.com/d/optout.