Skip to contentSkip to conversation

Staging: vt6655: Align a static function declaration

PATCH In review Madhumitha Prabakaran 2 participants 2 messages Feb 28, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v6 1/1 Staging: vt6655: Align a static function declaration

Align function arguments and function return type to improve readability.

---
Changes since v6:
- Started again to recommit from greg's version due to code duplication

Changes in v5:
- Commit log and code diff are matching. In last commit, there was error from my side while reevaluating and commiting it again

Changes in v4:
- Commit log and code diff are matching

Changes in v3:
- Included driver name in subject line.

Changes in v2:
- Improved alignment of function declaration
- Modified subject line and commit log

---
 drivers/staging/vt6655/card.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/staging/vt6655/card.c +3 -8
index 3226dbaab3bb..6ecbe925026d 100644
@@ -60,14 +60,9 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
 
 /*---------------------  Static Functions  --------------------------*/
 
-static
-void
-s_vCalculateOFDMRParameter(
-	unsigned char byRate,
-	u8 bb_type,
-	unsigned char *pbyTxRate,
-	unsigned char *pbyRsvTime
-);
+static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
+				       unsigned char *pbyTxRate,
+				       unsigned char *pbyRsvTime);
 
 /*---------------------  Export Functions  --------------------------*/
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 7 lines · Madhumitha Prabakaran

Align function arguments and function return type to improve readability.

---
Changes since v6:
- Started again to recommit from greg's version due to code duplication

It looks better this time.

julia

Quoted 50 lines

Changes in v5:
- Commit log and code diff are matching. In last commit, there was error from my side while reevaluating and commiting it again

Changes in v4:
- Commit log and code diff are matching

Changes in v3:
- Included driver name in subject line.

Changes in v2:
- Improved alignment of function declaration
- Modified subject line and commit log

---
 drivers/staging/vt6655/card.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)
drivers/staging/vt6655/card.c +3 -9
index 3226dbaab3bb..6ecbe925026d 100644
@@ -60,14 +60,9 @@ static const unsigned short cwRXBCNTSFOff[MAX_RATE] = {
 
 /*---------------------  Static Functions  --------------------------*/
 
-static
-void
-s_vCalculateOFDMRParameter(
-	unsigned char byRate,
-	u8 bb_type,
-	unsigned char *pbyTxRate,
-	unsigned char *pbyRsvTime
-);
+static void s_vCalculateOFDMRParameter(unsigned char byRate, u8 bb_type,
+				       unsigned char *pbyTxRate,
+				       unsigned char *pbyRsvTime);
 
 /*---------------------  Export Functions  --------------------------*/
 
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190228211422.26979-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.