staging: mt7621-dma: SPDX license cleanups
Subsystems (2)
cover staging: mt7621-dma: SPDX license cleanups
This patch series adds SPDX license identifier to fix missing and malformed warning generated by checkpatch.pl tool
then removes unnecessary license boilerplates.
Now that we have the spdx specified,
the license text is not necessary.
Jules Irenge (2):
staging: mt7621-dma: add SPDX GPL-2.0 or later version license
identifier
staging: mt7621-dma: remove license boilerplate text
drivers/staging/mt7621-dma/mtk-hsdma.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/2 staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier
Add SPDX GPL-2.0-or-later license to fix missing SPDX warning
reported by checkpatch.pl.
--- drivers/staging/mt7621-dma/mtk-hsdma.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/mt7621-dma/mtk-hsdma.c +1 -0
@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later /* * Copyright (C) 2015, Michael Lee <[email protected]> * MTK HSDMA support
Signature · 1 line
2.20.1
Greg KH
maintainerRe: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier
Quoted 13 lines · Jules Irenge
Add SPDX GPL-2.0-or-later license to fix missing SPDX warning
reported by checkpatch.pl.Signed-off-by Jules Irenge <[email protected]>--- drivers/staging/mt7621-dma/mtk-hsdma.c | 1 + 1 file changed, 1 insertion(+)drivers/staging/mt7621-dma/mtk-hsdma.c +0
-0
drivers/staging/mt7621-dma/mtk-hsdma.c line 1
Quoted 1 line
drivers/staging/mt7621-dma/mtk-hsdma.c +1
-0@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later
Shouldn't this be:
// SPDX-License-Identifier: GPL-2.0+
The "or later" is starting to get used, but I don't think it's all that prelevant yet. What did you read to decide to use that format instead of the "+" format?
thanks,
greg k-h
Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier
Some people say GPL-2.0+ has deprecated (
https://www.drupal.org/project/lightning/issues/2938910 ) but I will change it to GPL-2.0+.
I tried looking on https://spdx.org/licenses/
Kind regards,
*Jules*
*..*
BCS West Yorkshire Secretary
Positive action combined with positive thinking results in success - Shiv Khera
Quoted 29 lines · Greg KH
Review
Quoted 9 lines · Jules Irenge
Add SPDX GPL-2.0-or-later license to fix missing SPDX warning
reported by checkpatch.pl.Signed-off-by Jules Irenge <[email protected]>--- drivers/staging/mt7621-dma/mtk-hsdma.c | 1 + 1 file changed, 1 insertion(+)(quoted diff) +0
-0
b/drivers/staging/mt7621-dma/mtk-hsdma.cdrivers/staging/mt7621-dma/mtk-hsdma.c line 1
Quoted 5 lines
index
d67a2504adb1..7d69586f23c0100644drivers/staging/mt7621-dma/mtk-hsdma.c +1
-0@@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0-or-later Shouldn't this be:
// SPDX-License-Identifier: GPL-2.0+
The "or later" is starting to get used, but I don't think it's all that prelevant yet. What did you read to decide to use that format instead of the "+" format?
thanks,
greg k-h
Greg KH
maintainerRe: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
Quoted 2 lines · Jules Octave
Some people say GPL-2.0+ has deprecated (
https://www.drupal.org/project/lightning/issues/2938910 ) but I will
That is drupal, not the kernel.
Quoted 2 lines
change it to GPL-2.0+.
I tried looking on https://spdx.org/licenses/
That's a nice place to read as well, but we are using an "older" version of spdx.
Always read the in-kernel documentation, we write it for a reason :)
Look at Documentation/process/license-rules.rst please, it shows that you should use the "GPL-2.0+" marking.
thanks,
greg k-h
Re: [Outreachy kernel] Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier
Thanks . I have just changed it. I take good note.
*Jules*
*..*
BCS West Yorkshire Secretary
Positive action combined with positive thinking results in success - Shiv Khera
Quoted 45 lines · Greg KH
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?A: No.
Q: Should I include quotations after my reply?http://daringfireball.net/2007/07/on_top
Quoted 2 lines · Jules Octave
Some people say GPL-2.0+ has deprecated (
https://www.drupal.org/project/lightning/issues/2938910 ) but I willThat is drupal, not the kernel.
Quoted 2 lines
change it to GPL-2.0+.
I tried looking on https://spdx.org/licenses/That's a nice place to read as well, but we are using an "older" version of spdx.
Always read the in-kernel documentation, we write it for a reason :)
Look at
Documentation/process/license-rules.rstplease, it shows that you should use the "GPL-2.0+" marking.thanks,
greg k-h
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected]. To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20190301200104.GA19353%40kroah.com
.
For more options, visit https://groups.google.com/d/optout.
Re: [Outreachy kernel] Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier
Quoted 1 line · Jules Octave
Thanks . I have just changed it. I take good note.
Greg told you not to top post. But you are top posting again. Please move down to the thing that you are responding to and put your response right under it, like I have done in this message.
julia
Quoted 57 lines
Jules
..
BCS West Yorkshire Secretary
Positive action combined with positive thinking results in success - Shiv KheraOn Fri, 1 Mar 2019 at 20:01, Greg KH <[email protected]> wrote:
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?A: No.
Q: Should I include quotations after my reply?http://daringfireball.net/2007/07/on_top
On Fri, Mar 01, 2019 at 05:38:58PM +0000, Jules Octave wrote:
> Some people say GPL-2.0+ has deprecated (
> https://www.drupal.org/project/lightning/issues/2938910 ) but I willThat is drupal, not the kernel.
> change it to GPL-2.0+.
> I tried looking on https://spdx.org/licenses/That's a nice place to read as well, but we are using an "older" version of spdx.
Always read the in-kernel documentation, we write it for a reason :)
Look at
Documentation/process/license-rules.rstplease, it shows that you should use the "GPL-2.0+" marking.thanks,
greg k-h
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190301200104.GA19353%40kroah.com.
For more options, visit https://groups.google.com/d/optout.--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAOuULM6csFS6UCZMfefDZhOdraTspMBKrXT5JiL3Gi2EOqAyXw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
Re: [Outreachy kernel] Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier
Apology, I did not see that. I will change.
*Jules*
*..*
BCS West Yorkshire Secretary
Positive action combined with positive thinking results in success - Shiv Khera
Quoted 84 lines · Julia Lawall
Quoted 1 line · Jules Octave
Thanks . I have just changed it. I take good note.
Greg told you not to top post. But you are top posting again. Please move down to the thing that you are responding to and put your response right under it, like I have done in this message.
julia
Quoted 5 lines
Jules
..
BCS West Yorkshire Secretary
Positive action combined with positive thinking results in success -Shiv Khera
Quoted 6 lines · Greg KH
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally readtext.
Quoted 5 lines
Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No.Quoted 8 lines
Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Mar 01, 2019 at 05:38:58PM +0000, Jules Octave wrote: > Some people say GPL-2.0+ has deprecated ( > https://www.drupal.org/project/lightning/issues/2938910 ) but Iwill
Quoted 7 lines
That is drupal, not the kernel.
> change it to GPL-2.0+.
> I tried looking on https://spdx.org/licenses/That's a nice place to read as well, but we are using an "older"
version
Quoted 3 lines
of spdx.
Always read the in-kernel documentation, we write it for a reason
:)
Quoted 2 lines
Look at
Documentation/process/license-rules.rstplease, it showsthat
Quoted 8 lines
you should use the "GPL-2.0+" marking.
thanks,
greg k-h
--
You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it,
send an email to [email protected].
Quoted 1 line
To post to this group, send email to
Quoted 1 line
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/20190301200104.GA19353%40kroah.com
.Quoted 4 lines
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
Quoted 2 lines
To post to this group, send email to [email protected]. To view this discussion on the web visit
Quoted 3 lines
For more options, visit https://groups.google.com/d/optout.
Re: [Outreachy kernel] Re: [PATCH 1/2] staging: mt7621-dma: add SPDX GPL-2.0 or later version license identifier
Quoted 1 line · Jules Octave
Apology, I did not see that. I will change.
This is top posting again. No mail sent to the mailing list should involve top posting.
julia
Quoted 104 lines
Jules
..
BCS West Yorkshire Secretary
Positive action combined with positive thinking results in success - Shiv KheraOn Sat, 2 Mar 2019 at 06:30, Julia Lawall <[email protected]> wrote:
On Sat, 2 Mar 2019, Jules Octave wrote:
> Thanks . I have just changed it. I take good note.
Greg told you not to top post. But you are top posting again. Please
move down to the thing that you are responding to and put your response
right under it, like I have done in this message.julia
>
> Jules
> ..
> BCS West Yorkshire Secretary
> Positive action combined with positive thinking results in
success - Shiv Khera
>
>
> On Fri, 1 Mar 2019 at 20:01, Greg KH
<[email protected]> wrote:
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called
top-posting?
> A: Because it messes up the order in which people
normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
>
> http://daringfireball.net/2007/07/on_top
>
> On Fri, Mar 01, 2019 at 05:38:58PM +0000, Jules Octave
wrote:
> > Some people say GPL-2.0+ has deprecated (
> >
https://www.drupal.org/project/lightning/issues/2938910 ) but I
will
>
> That is drupal, not the kernel.
>
> > change it to GPL-2.0+.
> > I tried looking on https://spdx.org/licenses/
>
> That's a nice place to read as well, but we are using an
"older" version
> of spdx.
>
> Always read the in-kernel documentation, we write it for
a reason :)
>
> Look atDocumentation/process/license-rules.rstplease,
it shows that
> you should use the "GPL-2.0+" marking.
>
> thanks,
>
> greg k-h
>
> --
> You received this message because you are subscribed to
the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails
from it, send an email to
[email protected].
> To post to this group, send email to
[email protected].
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20190301200104.GA19353%4 0kroah.com.
> For more options, visit
https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the
Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from
it, send an email to
[email protected].
> To post to this group, send email to
[email protected].
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAOuULM6csFS6UCZMfefDZhO draTspMBKrXT5JiL3Gi2EOqAyXw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
PATCH 2/2 staging: mt7621-dma: remove license boilerplate text
In reply to Jules IrengeRemoves license boilerplate text
--- drivers/staging/mt7621-dma/mtk-hsdma.c | 7 ------- 1 file changed, 7 deletions(-)
drivers/staging/mt7621-dma/mtk-hsdma.c +0 -7
@@ -1,13 +1,6 @@// SPDX-License-Identifier: GPL-2.0-or-later /* * Copyright (C) 2015, Michael Lee <[email protected]> -* MTK HSDMA support -* -* This program is free software; you can redistribute it and/or modify it -* under the terms of the GNU General Public License as published by the -* Free Software Foundation; either version 2 of the License, or (at your -* option) any later version. -* */ #include <linux/dmaengine.h>
Signature · 1 line
2.20.1