Fixed Warning: line over 80 characters
PATCH 1/1 Fixed Warning: line over 80 characters
--- drivers/staging/pi433/rf69.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/pi433/rf69.c +2 -1
@@ -563,7 +563,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag) {switch (flag) {case mode_switch_completed: -return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_MODE_READY ); +return (rf69_read_reg (spi,REG_IRQFLAGS1 ) & +MASK_IRQFLAGS1_MODE_READY );case ready_to_receive:return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_RX_READY );case ready_to_send:
Signature · 1 line
2.7.4
You need a log message. Even if everything seems obvious from the subject line. The subject line and the log message should be in the imperative. So that would be Fix, rather than Fixed.
The log message should say what you have done and why. Fix doesn't really do either. You have fixed something, but one doesn't know what change you have made nor why you chose to make that change.
Presumably you found this issue using checkpatch. So you could say "Issue found using checkpatch" to make that clear.
julia
Quoted 29 lines · Debleena Sen
Signed-off-by Debleena Sen <[email protected]>--- drivers/staging/pi433/rf69.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/pi433/rf69.c +2
-2@@ -563,7 +563,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flag flag) {switch (flag) {case mode_switch_completed: -return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_MODE_READY ); +return (rf69_read_reg (spi,REG_IRQFLAGS1 ) & +MASK_IRQFLAGS1_MODE_READY );case ready_to_receive:return (rf69_read_reg (spi,REG_IRQFLAGS1 ) &MASK_IRQFLAGS1_RX_READY );case ready_to_send: --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1551551350-111229-1-git-send-email-idebleenasen%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 43 lines · Julia Lawall
You need a log message. Even if everything seems obvious from the subject line. The subject line and the log message should be in the imperative. So that would be Fix, rather than Fixed.
The log message should say what you have done and why. Fix doesn't really do either. You have fixed something, but one doesn't know what change you have made nor why you chose to make that change.
Presumably you found this issue using checkpatch. So you could say "Issue found using checkpatch" to make that clear.
julia
drivers/staging/pi433/rf69.c bool rf69_get_flag(struct spi_device *spi, enum flag
Quoted 10 lines · Debleena Sen
Signed-off-by Debleena Sen <[email protected] <javascript:>>---
drivers/staging/pi433/rf69.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/pi433/rf69.c +0
-0@@ -563,7 +563,8 @@ bool rf69_get_flag(struct spi_device *spi, enum flagflag)
drivers/staging/pi433/rf69.c bool rf69_get_flag(struct spi_device *spi, enum flag flag)
Quoted 4 lines
drivers/staging/pi433/rf69.c +0
-1{switch (flag) {case mode_switch_completed: - return (rf69_read_reg(spi, REG_IRQFLAGS1) &
MASK_IRQFLAGS1_MODE_READY);drivers/staging/pi433/rf69.c bool rf69_get_flag(struct spi_device *spi, enum flag flag)
Quoted 4 lines
drivers/staging/pi433/rf69.c +2
-0+return (rf69_read_reg (spi,REG_IRQFLAGS1 ) & +MASK_IRQFLAGS1_MODE_READY );case ready_to_receive: return (rf69_read_reg(spi, REG_IRQFLAGS1) &
MASK_IRQFLAGS1_RX_READY);Quoted 6 lines
drivers/staging/pi433/rf69.c +0
-0case ready_to_send:Signature · 4 lines
2.7.4 -- You received this message because you are subscribed to the Google
Quoted 11 lines
Groups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected] <javascript:>.
Quoted 1 line
To post to this group, send email to [email protected]
<javascript:>.
Quoted 1 line
To view this discussion on the web visit
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.
I'm sorry for not adding the log message. This was my first patch and I was a bit confused about the process. I'll keep this in mind for future.
Yes I did find the issue after running checkpatch.pl on pi433/rf69.c
The checkpatch.pl warning was: [WARNING]: line over 80 charaters #566
So I reformatted the line to remove the warning. Is this a valid patch?
Quoted 46 lines · On Sat, 2 Mar 2019, [email protected] wrote:
On Sunday, March 3, 2019 at 12:10:55 AM UTC+5:30, Julia Lawall wrote:
You need a log message. Even if everything seems obvious from the subject line. The subject line and the log message should be in the imperative. So that would be Fix, rather than Fixed.The log message should say what you have done and why. Fix doesn't really do either. You have fixed something, but one doesn't know what change you have made nor why you chose to make that change.
Presumably you found this issue using checkpatch. So you could say "Issue found using checkpatch" to make that clear.
julia
On Sat, 2 Mar 2019, Debleena Sen wrote:
> Signed-off-by: Debleena Sen <[email protected]>
> ---
> drivers/staging/pi433/rf69.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --gita/drivers/staging/pi433/rf69.cb/drivers/staging/pi433/rf69.c
> index e19b9ce..0c189a7 100644
> ---a/drivers/staging/pi433/rf69.c
> +++b/drivers/staging/pi433/rf69.c
> @@ -563,7 +563,8 @@ boolrf69_get_flag(struct spi_device *spi, enum flag flag)
> {
> switch (flag) {
> casemode_switch_completed:
> - return (rf69_read_reg(spi, REG_IRQFLAGS1)&MASK_IRQFLAGS1_MODE_READY);
> + return (rf69_read_reg(spi, REG_IRQFLAGS1)&
> + MASK_IRQFLAGS1_MODE_READY);
> caseready_to_receive:
> return (rf69_read_reg(spi, REG_IRQFLAGS1)&MASK_IRQFLAGS1_RX_READY);
> caseready_to_send:
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To post to this group, send email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1551551350-111229-1-git-send-email-idebleenasen%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
Quoted 7 lines
I'm sorry for not adding the log message. This was my first patch and I was a bit confused about the process. I'll keep this in mind for future.
Yes I did find the issue after running checkpatch.pl on
pi433/rf69.cThe checkpatch.pl warning was: [WARNING]: line over 80 charaters #566
So I reformatted the line to remove the warning. Is this a valid patch?
The change looks ok. You need to send a v2 though to address the log message issue.
I wonder also about the ... in the Signed off by email address. Did you do that or was it generated for you? It could be nicer to have the complete address.
julia