Staging: wlan-ng: Fix alignment match issue
PATCH 1/1 Staging: wlan-ng: Fix alignment match issue
Use tab to match alignment with open parenthesis to remove checkpatch.pl check:
CHECK: Alignment should match open parenthesis
--- drivers/staging/wlan-ng/prism2mgmt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/wlan-ng/prism2mgmt.c +2 -2
@@ -228,8 +228,8 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)__le16 wordbuf[17 ]; result =hfa384x_drvr_setconfig16 (hw, - HFA384x_RID_CNFROAMINGMODE, - HFA384x_ROAMMODE_HOSTSCAN_HOSTROAM); + HFA384x_RID_CNFROAMINGMODE, + HFA384x_ROAMMODE_HOSTSCAN_HOSTROAM);if (result) { netdev_err(wlandev->netdev, "setconfig(ROAMINGMODE) failed. result=%d\n",
Signature · 1 line
2.7.4
Quoted 14 lines · Debleena Sen
Use tab to match alignment with open parenthesis to remove checkpatch.pl check:
CHECK: Alignment should match open parenthesisSigned-off-by Debleena Sen <[email protected]>--- drivers/staging/wlan-ng/prism2mgmt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/wlan-ng/prism2mgmt.c +0
-0
drivers/staging/wlan-ng/prism2mgmt.c int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp) · line 232
Quoted 7 lines
drivers/staging/wlan-ng/prism2mgmt.c +2
-2@@ -228,8 +228,8 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)__le16 wordbuf[17 ]; result =hfa384x_drvr_setconfig16 (hw, - HFA384x_RID_CNFROAMINGMODE, - HFA384x_ROAMMODE_HOSTSCAN_HOSTROAM); + HFA384x_RID_CNFROAMINGMODE, + HFA384x_ROAMMODE_HOSTSCAN_HOSTROAM);
You are now over 80 characters for the third argument. So it would be better to leave the code as is.
julia
Quoted 13 lines
drivers/staging/wlan-ng/prism2mgmt.c +0
-1if (result) { netdev_err(wlandev->netdev, "setconfig(ROAMINGMODE) failed. result=%d\n", --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1551612545-54801-1-git-send-email-idebleenasen%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Quoted 47 lines · Julia Lawall
Review
Quoted 10 lines · Debleena Sen
Use tab to match alignment with open parenthesis to remove checkpatch.pl check:
CHECK: Alignment should match open parenthesisSigned-off-by Debleena Sen <[email protected] <javascript:>>---
drivers/staging/wlan-ng/prism2mgmt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)(quoted diff) +0
-0
b/drivers/staging/wlan-ng/prism2mgmt.cdrivers/staging/wlan-ng/prism2mgmt.c int prism2mgmt_scan(struct wlandevice *wlandev, void
Quoted 4 lines
index 7350fe5..7d2a140 100644
drivers/staging/wlan-ng/prism2mgmt.c +0
-0@@ -228,8 +228,8 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void*msgp)
drivers/staging/wlan-ng/prism2mgmt.c int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)
Quoted 5 lines
drivers/staging/wlan-ng/prism2mgmt.c +0
-1__le16 wordbuf[17 ]; result = hfa384x_drvr_setconfig16(hw, - HFA384x_RID_CNFROAMINGMODE,-
HFA384x_ROAMMODE_HOSTSCAN_HOSTROAM);drivers/staging/wlan-ng/prism2mgmt.c int prism2mgmt_scan(struct wlandevice *wlandev, void · line 232
Quoted 1 line
drivers/staging/wlan-ng/prism2mgmt.c +1
-0+
HFA384x_RID_CNFROAMINGMODE,drivers/staging/wlan-ng/prism2mgmt.c int prism2mgmt_scan(struct wlandevice *wlandev, void · line 233
Quoted 1 line
drivers/staging/wlan-ng/prism2mgmt.c +1
-0+
HFA384x_ROAMMODE_HOSTSCAN_HOSTROAM);You are now over 80 characters for the third argument. So it would be better to leave the code as is.
julia
drivers/staging/wlan-ng/prism2mgmt.c int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)
Quoted 3 lines
drivers/staging/wlan-ng/prism2mgmt.c +0
-0if (result) { netdev_err(wlandev->netdev, "setconfig(ROAMINGMODE) failed.result=%d\n",
Quoted 5 lines
Signature · 4 lines
2.7.4 -- You received this message because you are subscribed to the Google
Quoted 11 lines
Groups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected] <javascript:>.
Quoted 1 line
To post to this group, send email to [email protected]
<javascript:>.
Quoted 1 line
To view this discussion on the web visit
Quoted 2 lines
For more options, visit https://groups.google.com/d/optout.
Yes I checked that. Sorry. Must've missed it.
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 61 lines · On Sun, 3 Mar 2019, [email protected] wrote:
On Sunday, March 3, 2019 at 5:01:38 PM UTC+5:30, Julia Lawall wrote:
On Sun, 3 Mar 2019, Debleena Sen wrote: > Use tab to match alignment with open parenthesis to remove > checkpatch.pl check: > CHECK: Alignment should match open parenthesis > > Signed-off-by: Debleena Sen <[email protected]> > --- > drivers/staging/wlan-ng/prism2mgmt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c > index 7350fe5..7d2a140 100644 > --- a/drivers/staging/wlan-ng/prism2mgmt.c > +++ b/drivers/staging/wlan-ng/prism2mgmt.c > @@ -228,8 +228,8 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp) > __le16 wordbuf[17]; > > result = hfa384x_drvr_setconfig16(hw, > - HFA384x_RID_CNFROAMINGMODE, >- HFA384x_ROAMMODE_HOSTSCAN_HOSTROAM ); > + HFA384x_RID_CNFROAMINGMODE, > + HFA384x_ROAMMODE_HOSTSCAN_HOSTROAM); You are now over 80 characters for the third argument. So it would be better to leave the code as is. julia > if (result) { > netdev_err(wlandev->netdev, > "setconfig(ROAMINGMODE) failed. result=%d\n", > -- > 2.7.4 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. > To post to this group, send email to [email protected]. > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/1551612545-54801-1-git-s end-email-idebleenasen%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >
Quoted 2 lines
Ok. But when I ran checkpatch.pl on the updated file the warning of more than 80 characters didn't show up. So I thought to commit the changes.
OK, perhaps check patch doesn't give the warning in some cases. But I think that the less indented arguments are not so bad, and not exceeding 80 characters is better as long as the code remains readable in other ways.
julia
Quoted 12 lines
--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/0baf5675-eda3-4e64-95e4- 694f82155da2%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.