Skip to contentSkip to conversation

Staging: vt6655: Fix line over 80 characters

PATCH In review Madhumitha Prabakaran 3 participants 7 messages Mar 4, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: vt6655: Fix line over 80 characters

Fix the warning issued by checkpatch.pl
WARNING: line over 80 characters

---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/card.h +2 -1
index d71022aa3f86..6bbbbe1314d5 100644
@@ -44,7 +44,8 @@ struct vnt_private;
 void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type);
 void CARDvUpdateBasicTopRate(struct vnt_private *priv);
 bool CARDbIsOFDMinBasicRate(struct vnt_private *priv);
-void CARDvSetLoopbackMode(struct vnt_private *priv, unsigned short wLoopbackMode);
+void CARDvSetLoopbackMode(struct vnt_private *priv,
+			  unsigned short wLoopbackMode);
 bool CARDbSoftwareReset(struct vnt_private *priv);
 void CARDvSetFirstNextTBTT(struct vnt_private *priv,
 			   unsigned short wBeaconInterval);
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Madhumitha Prabakaran

Fix the warning issued by checkpatch.pl
WARNING: line over 80 characters

---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/card.h +0 -0
index d71022aa3f86..6bbbbe1314d5 100644

drivers/staging/vt6655/card.h struct vnt_private; · line 48

Quoted 6 lines
drivers/staging/vt6655/card.h +2 -1
@@ -44,7 +44,8 @@ struct vnt_private;
 void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type);
 void CARDvUpdateBasicTopRate(struct vnt_private *priv);
 bool CARDbIsOFDMinBasicRate(struct vnt_private *priv);
-void CARDvSetLoopbackMode(struct vnt_private *priv, unsigned short wLoopbackMode);
+void CARDvSetLoopbackMode(struct vnt_private *priv,
+			  unsigned short wLoopbackMode);

I have the impression that this function is actually never used. Maybe you can try to get rid of it.

julia

Quoted 13 lines
drivers/staging/vt6655/card.h +0 -1
 bool CARDbSoftwareReset(struct vnt_private *priv);
 void CARDvSetFirstNextTBTT(struct vnt_private *priv,
 			   unsigned short wBeaconInterval);
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190304011949.17148-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

#2 lore raw
Quoted 35 lines · Julia Lawall
Quoted 13 lines · Madhumitha Prabakaran

Fix the warning issued by checkpatch.pl
WARNING: line over 80 characters

---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/card.h +0 -0
index d71022aa3f86..6bbbbe1314d5 100644

drivers/staging/vt6655/card.h struct vnt_private; · line 48

Quoted 6 lines
drivers/staging/vt6655/card.h +2 -1
@@ -44,7 +44,8 @@ struct vnt_private;
 void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type);
 void CARDvUpdateBasicTopRate(struct vnt_private *priv);
 bool CARDbIsOFDMinBasicRate(struct vnt_private *priv);
-void CARDvSetLoopbackMode(struct vnt_private *priv, unsigned short wLoopbackMode);
+void CARDvSetLoopbackMode(struct vnt_private *priv,
+			  unsigned short wLoopbackMode);

I have the impression that this function is actually never used. Maybe you can try to get rid of it.

julia

Quoted 6 lines
drivers/staging/vt6655/card.h +0 -1
 bool CARDbSoftwareReset(struct vnt_private *priv);
 void CARDvSetFirstNextTBTT(struct vnt_private *priv,
 			   unsigned short wBeaconInterval);
--

2.17.1

Quoted 14 lines
Quoted 7 lines

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190304011949.17148-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Signature · 5 lines
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1903040842080.2559%40hadrien.
For more options, visit https://groups.google.com/d/optout.

I will check and fix it

Madhumitha

#3 lore raw
In reply to Julia Lawall
Quoted 35 lines · Julia Lawall
Quoted 13 lines · Madhumitha Prabakaran

Fix the warning issued by checkpatch.pl
WARNING: line over 80 characters

---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/vt6655/card.h +0 -0
index d71022aa3f86..6bbbbe1314d5 100644

drivers/staging/vt6655/card.h struct vnt_private; · line 48

Quoted 6 lines
drivers/staging/vt6655/card.h +2 -1
@@ -44,7 +44,8 @@ struct vnt_private;
 void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type);
 void CARDvUpdateBasicTopRate(struct vnt_private *priv);
 bool CARDbIsOFDMinBasicRate(struct vnt_private *priv);
-void CARDvSetLoopbackMode(struct vnt_private *priv, unsigned short wLoopbackMode);
+void CARDvSetLoopbackMode(struct vnt_private *priv,
+			  unsigned short wLoopbackMode);

I have the impression that this function is actually never used. Maybe you can try to get rid of it.

julia

Quoted 6 lines
drivers/staging/vt6655/card.h +0 -1
 bool CARDbSoftwareReset(struct vnt_private *priv);
 void CARDvSetFirstNextTBTT(struct vnt_private *priv,
 			   unsigned short wBeaconInterval);
--

2.17.1

Quoted 14 lines
Quoted 7 lines

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190304011949.17148-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

Signature · 5 lines
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/alpine.DEB.2.21.1903040842080.2559%40hadrien.
For more options, visit https://groups.google.com/d/optout.

None of the function declarations in card.h is used with itself. But the CARDvSetLoopbackMode function is used in card.c. Whether we can remove it, considering the fact that it is used in card.c or not. I'm not sure regarding it.

thanks,
madhumitha

maintainer
#4 lore raw
In reply to Madhumitha Prabakaran
Quoted 7 lines · Madhumitha Prabakaran

Fix the warning issued by checkpatch.pl
WARNING: line over 80 characters

---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

You sent multiple patches with the same subject line, and no hint as to what order they need to be applied in.

I have now removed all of your pending patches from my "to review" queue, please fix them up and resend them properly.

thanks,

greg k-h

#5 lore raw
Quoted 13 lines · Greg KH
Quoted 7 lines · Madhumitha Prabakaran

Fix the warning issued by checkpatch.pl
WARNING: line over 80 characters

---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

You sent multiple patches with the same subject line, and no hint as to what order they need to be applied in.

Quoted 6 lines

I have now removed all of your pending patches from my "to review" queue, please fix them up and resend them properly.

thanks,

greg k-h

I will resend all the patches.
I only have 2 patches with same subject lines, other three patches have different subject line.
So do you want me to include v2 in the patches or I can send it as same, as it is removed from your "to review" queue.

thanks,

Madhumitha

maintainer
#6 lore raw
Quoted 17 lines · Madhumthia Prabakaran
Quoted 16 lines · Greg KH
Quoted 7 lines · Madhumitha Prabakaran

Fix the warning issued by checkpatch.pl
WARNING: line over 80 characters

---
 drivers/staging/vt6655/card.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

You sent multiple patches with the same subject line, and no hint as to what order they need to be applied in.

I have now removed all of your pending patches from my "to review" queue, please fix them up and resend them properly.

Quoted 7 lines
Quoted 3 lines

thanks,

greg k-h

I will resend all the patches.
I only have 2 patches with same subject lines, other three patches have different subject line.
So do you want me to include v2 in the patches or I can send it as same, as it is removed from your "to review" queue.

I need them all resent, as one single patch series, in the proper format. As I said, I have dropped all of your pending patches at that point in time.

thanks,

greg k-h