Skip to contentSkip to conversation

Staging: vt6655: Remove an unused function

PATCH In review Madhumitha Prabakaran 2 participants 2 messages Mar 7, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Staging: vt6655: Remove an unused function

Remove an unused function, as it is never called in kernel tree.
---
Changes in v2 -
- Converted patch series to a patch

---
 drivers/staging/vt6655/mac.c | 7 -------
 drivers/staging/vt6655/mac.h | 2 --
 2 files changed, 9 deletions(-)
drivers/staging/vt6655/mac.c +0 -7
index 40a8f1ce837c..2f773fdf8d64 100644
@@ -57,13 +57,6 @@
  * Return Value: true if all test bits On; otherwise false
  *
  */
-bool MACbIsRegBitsOn(struct vnt_private *priv, unsigned char byRegOfs,
-		     unsigned char byTestBits)
-{
-	void __iomem *io_base = priv->PortOffset;
-
-	return (ioread8(io_base + byRegOfs) & byTestBits) == byTestBits;
-}
 
 /*
  * Description:
drivers/staging/vt6655/mac.h +0 -2
index 59538ac09fc5..c7888c4e96f2 100644
@@ -876,8 +876,6 @@ do {								\
 #define MACvSetRFLE_LatchBase(iobase)                                 \
 	MACvWordRegBitsOn(iobase, MAC_REG_SOFTPWRCTL, SOFTPWRCTL_RFLEOPT)
 
-bool MACbIsRegBitsOn(struct vnt_private *priv, unsigned char byRegOfs,
-		     unsigned char byTestBits);
 bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,
 		      unsigned char byTestBits);
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 15 lines · Madhumitha Prabakaran

Remove an unused function, as it is never called in kernel tree.
---
Changes in v2 -
- Converted patch series to a patch

---
 drivers/staging/vt6655/mac.c | 7 -------
 drivers/staging/vt6655/mac.h | 2 --
 2 files changed, 9 deletions(-)
drivers/staging/vt6655/mac.c +0 -0
index 40a8f1ce837c..2f773fdf8d64 100644

drivers/staging/vt6655/mac.c line 59

Quoted 3 lines
drivers/staging/vt6655/mac.c +0 -0
@@ -57,13 +57,6 @@
  * Return Value: true if all test bits On; otherwise false
  *
  */

The text above looks like a comment about this function. If you are removing this function, you should remove the comment too.

julia

Quoted 33 lines
drivers/staging/vt6655/mac.c +0 -7
-bool MACbIsRegBitsOn(struct vnt_private *priv, unsigned char byRegOfs,
-		     unsigned char byTestBits)
-{
-	void __iomem *io_base = priv->PortOffset;
-
-	return (ioread8(io_base + byRegOfs) & byTestBits) == byTestBits;
-}
 
 /*
  * Description:
drivers/staging/vt6655/mac.h +0 -3
index 59538ac09fc5..c7888c4e96f2 100644
@@ -876,8 +876,6 @@ do {								\
 #define MACvSetRFLE_LatchBase(iobase)                                 \
 	MACvWordRegBitsOn(iobase, MAC_REG_SOFTPWRCTL, SOFTPWRCTL_RFLEOPT)
 
-bool MACbIsRegBitsOn(struct vnt_private *priv, unsigned char byRegOfs,
-		     unsigned char byTestBits);
 bool MACbIsRegBitsOff(struct vnt_private *priv, unsigned char byRegOfs,
 		      unsigned char byTestBits);
 
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190307204254.8003-1-madhumithabiw%40gmail.com.
For more options, visit https://groups.google.com/d/optout.