Skip to contentSkip to conversation

ath11k: fix itnull.cocci warnings

PATCH In review Julia Lawall 2 participants 2 messages Mar 7, 2019 – Mar 8, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath11k: fix itnull.cocci warnings

From: kbuild test robot <[email protected]>

Iterator variable bound on line 976 cannot be NULL.

Generated by: scripts/coccinelle/iterators/itnull.cocci

Fixes 258bbf525e65 ("ath11k: add driver")

---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup
head:   e7daa3ec639f390e383dae0db9e6b143bcc7b5bc
commit: 258bbf525e652e244aa8b2331f55fda573fbe926 [3/42] ath11k: add driver

:::::: branch date: 5 hours ago
:::::: commit date: 4 weeks ago

Please take the patch only if it's a positive warning. Thanks!

 dp_rx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath11k/dp_rx.c +1 -1
@@ -974,7 +974,7 @@ struct htt_ppdu_stats_info *ath11k_dp_ht
 	struct htt_ppdu_stats *ppdu_stats = NULL;
 
 	list_for_each_entry(ppdu_info, &ar->ppdu_stats_info, list) {
-		if (ppdu_info && ppdu_info->ppdu_id == ppdu_id)
+		if (ppdu_info->ppdu_id == ppdu_id)
 			return ppdu_info;
 	}
 

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k

#1 lore raw
Quoted 9 lines · Julia Lawall

From: kbuild test robot <[email protected]>

Iterator variable bound on line 976 cannot be NULL.

Generated by: scripts/coccinelle/iterators/itnull.cocci

Fixes 258bbf525e65 ("ath11k: add driver")

Doesn't apply either.

Signature · 6 lines
Kalle Valo

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k