Skip to contentSkip to conversation

drivers/net/wireless/ath/ath11k/qmi.c:1989:1-7: ERROR: missing iounmap; ioremap on line 1935 and execution via conditional on line 1965 (fwd)

PATCH New Julia Lawall 1 participant 1 message Mar 7, 2019 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 3/42 drivers/net/wireless/ath/ath11k/qmi.c:1989:1-7: ERROR: missing iounmap; ioremap on line 1935 and execution via conditional on line 1965 (fwd)

The messages below about iounmap are for the function ath11k_qmi_load_bdf in qmi.c. There are three occurrences of goto out that need to jump to the iounmap above the out: label.

The message about the lock is about the goto fallback on line 4103. Should the spinlock be unlocked here?

The message about unsigned in dp_tx.c is because the variable ring_entry_sz is declared as u32 (line 561).

julia

---------- Forwarded message ----------
Date: Fri, 8 Mar 2019 05:28:10 +0800
From: kbuild test robot <[email protected]>
To: [email protected]
Cc: Julia Lawall <[email protected]>
Subject: [ath6kl:ath11k-bringup 3/42]
drivers/net/wireless/ath/ath11k/qmi.c:1989:1-7: ERROR: missing iounmap; ioremap on line 1935 and execution via conditional on line 1965

CC: [email protected]
CC: [email protected]
TO: Kalle Valo <[email protected]>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git ath11k-bringup
head:   e7daa3ec639f390e383dae0db9e6b143bcc7b5bc
commit: 258bbf525e652e244aa8b2331f55fda573fbe926 [3/42] ath11k: add driver

:::::: branch date: 5 hours ago
:::::: commit date: 4 weeks ago

Quoted 1 line
Quoted 1 line

drivers/net/wireless/ath/ath11k/qmi.c:1989:1-7: ERROR: missing iounmap; ioremap on line 1935 and execution via conditional on line 1965

drivers/net/wireless/ath/ath11k/qmi.c:1989:1-7: ERROR: missing iounmap; ioremap on line 1935 and execution via conditional on line 1971 drivers/net/wireless/ath/ath11k/qmi.c:1989:1-7: ERROR: missing iounmap; ioremap on line 1935 and execution via conditional on line 1977
--

Quoted 1 line
Quoted 1 line

drivers/net/wireless/ath/ath11k/dp_rx.c:977:6-15: ERROR: iterator variable bound on line 976 cannot be NULL

--

Quoted 1 line
Quoted 1 line

drivers/net/wireless/ath/ath11k/wmi.c:4140:1-7: preceding lock on line 4088

--

Quoted 1 line
Quoted 1 line

drivers/net/wireless/ath/ath11k/dp_rx.c:278:16-22: ERROR: application of sizeof to pointer

--

Quoted 1 line
Quoted 1 line

drivers/net/wireless/ath/ath11k/mac.c:711:5-8: Unneeded variable: "ret". Return "0" on line 719

drivers/net/wireless/ath/ath11k/mac.c:418:5-11: Unneeded variable: "status". Return "0" on line 451
--

Quoted 1 line
Quoted 1 line

drivers/net/wireless/ath/ath11k/mac.c:3274:2-3: Unneeded semicolon

--

Quoted 1 line
Quoted 1 line

drivers/net/wireless/ath/ath11k/dp_tx.c:641:5-18: WARNING: Unsigned expression compared with zero: ring_entry_sz < 0

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k