staging: speakup: fix line over 80 characters.
PATCH 1/2 staging: speakup: fix line over 80 characters.
Fix coding style issues, which solves checkpatch.pl warning:
"WARNING: line over 80 characters".
--- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/kobjects.c +1 -1
@@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,continue ; } -/* Do not replace with kstrtoul: here we need temp to be updated */ +/* Do not replace with kstrtoul: temp need to be updated */ index =simple_strtoul (cp, &temp,10 );if (index >255 ) { rejected++;
Signature · 1 line
2.20.1
PATCH 2/2 staging: speakup: fix line over 80 characters.
Fix coding style issues which solves checkpatch.pl warning:
"WARNING: line over 80 characters".
--- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/speakup/kobjects.c +1 -1
@@ -788,7 +788,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,continue ; } -/* Do not replace with kstrtoul: here we need temp to be updated */ +/* Do not replace with kstrtoul: temp need to be updated */ index =simple_strtoul (cp, &temp,10 );while ((temp < linefeed) && (*temp ==' ' || *temp =='\t' ))
Signature · 1 line
2.20.1
Greg KH
maintainerQuoted 13 lines · Jules Irenge
Fix coding style issues which solves checkpatch.pl warning:
"WARNING: line over 80 characters".Signed-off-by Jules Irenge <[email protected]>--- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/speakup/kobjects.c +0
-0
drivers/staging/speakup/kobjects.c static ssize_t message_store_helper(const char *buf, size_t count, · line 791
Quoted 5 lines
drivers/staging/speakup/kobjects.c +1
-1@@ -788,7 +788,7 @@ static ssize_t message_store_helper(const char *buf, size_t count,continue ; } -/* Do not replace with kstrtoul: here we need temp to be updated */ +/* Do not replace with kstrtoul: temp need to be updated */
You sent 2 patches that did different things, yet they had the same subject line?
Also, again, the original is better.
thanks,
greg k-h
Quoted 2 lines · Jules Irenge
Fix coding style issues, which solves checkpatch.pl warning:
"WARNING: line over 80 characters".
You have two patches with the same subject. Actually they do the same thing, and work on the same file, so they could be merged into one patch.
Also you are missing the Signed-off-by.
julia
Quoted 27 lines
--- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/speakup/kobjects.c +1
-2@@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,continue ; } -/* Do not replace with kstrtoul: here we need temp to be updated */ +/* Do not replace with kstrtoul: temp need to be updated */ index =simple_strtoul (cp, &temp,10 );if (index >255 ) { rejected++; --2.20.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190317112857.18220-1-jbi.octave%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Greg KH
maintainerQuoted 5 lines · Jules Irenge
Fix coding style issues, which solves checkpatch.pl warning:
"WARNING: line over 80 characters".--- drivers/staging/speakup/kobjects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
No signed off by?
drivers/staging/speakup/kobjects.c static ssize_t chars_chartab_store(struct kobject *kobj, · line 157
Quoted 11 lines
drivers/staging/speakup/kobjects.c +1
-1@@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj,continue ; } -/* Do not replace with kstrtoul: here we need temp to be updated */ +/* Do not replace with kstrtoul: temp need to be updated */
Original text is better than this, I do not know what your shortening of the line now means :(
thanks,
greg k-h