Skip to contentSkip to conversation

io_uring: fix ifnullfree.cocci warnings

PATCH In review Julia Lawall 2 participants 2 messages Apr 10, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 io_uring: fix ifnullfree.cocci warnings

From: kbuild test robot <[email protected]>

NULL check before kfree is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes b905f31ee046 ("io_uring: introduce inline reqs for IORING_SETUP_IOPOLL")
CC Jianchao Wang <[email protected]>

---

url: https://github.com/0day-ci/linux/commits/Jianchao-Wang/io_uring-introduce-inline-reqs-for-IORING_SETUP_IOPOLL/20190409-194746
:::::: branch date: 17 hours ago
:::::: commit date: 17 hours ago

 io_uring.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/io_uring.c +1 -2
@@ -2597,8 +2597,7 @@ static void io_ring_ctx_free(struct io_r
 		sock_release(ctx->ring_sock);
 #endif
 
-	if (ctx->inline_req_array)
-		kfree(ctx->inline_req_array);
+	kfree(ctx->inline_req_array);
 
 	io_mem_free(ctx->sq_ring);
 	io_mem_free(ctx->sq_sqes);
#1 lore raw
Quoted 23 lines · Julia Lawall

From: kbuild test robot <[email protected]>

NULL check before kfree is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes b905f31ee046 ("io_uring: introduce inline reqs for IORING_SETUP_IOPOLL")
CC Jianchao Wang <[email protected]>

---

url: https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_0day-2Dci_linux_commits_Jianchao-2DWang_io-5Furing-2Dintroduce-2Dinline-2Dreqs-2Dfor-2DIORING-5FSETUP-5FIOPOLL_20190409-2D194746&d=DwIBAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=7WdAxUBeiTUTCy8v-7zXyr4qk7sx26ATvfo6QSTvZyQ&m=JhagBidUFU8krcGWek4GwnU4uoqS09eboyA8kslpNts&s=fcK4IjSBbR0XznBh7lL6V47NyfxmdixfO3QXiWWVuX0&e=
:::::: branch date: 17 hours ago
:::::: commit date: 17 hours ago

 io_uring.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

fs/io_uring.c static void io_ring_ctx_free(struct io_r · line 2600

Quoted 6 lines
fs/io_uring.c +1 -2
@@ -2597,8 +2597,7 @@ static void io_ring_ctx_free(struct io_r
 		sock_release(ctx->ring_sock);
 #endif
 
-	if (ctx->inline_req_array)
-		kfree(ctx->inline_req_array);
+	kfree(ctx->inline_req_array);

Yes, indeed. kfree can tolerate NULL pointer.
Will change it in latter version.

Thanks
Jianchao

Quoted 4 lines
fs/io_uring.c +0 -0
 	io_mem_free(ctx->sq_ring);
 	io_mem_free(ctx->sq_sqes);