Skip to contentSkip to conversation

media: i2c: fix returnvar.cocci warnings

PATCH New Julia Lawall 1 participant 1 message Oct 3, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: i2c: fix returnvar.cocci warnings

From: kbuild test robot <[email protected]>

Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes a80daf4057d7 ("media: i2c: Add IMX290 CMOS image sensor driver")
CC Manivannan Sadhasivam <[email protected]>

---

url:    https://github.com/0day-ci/linux/commits/Manivannan-Sadhasivam/dt-bindings-media-i2c-Add-IMX290-CMOS-sensor-binding/20191003-175652
base:   git://linuxtv.org/media_tree.git master

:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

Please take the patch only if it's a positive warning. Thanks!

 imx290.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/media/i2c/imx290.c +1 -2
@@ -447,7 +447,6 @@ static int imx290_set_fmt(struct v4l2_su
 	const struct imx290_mode *mode;
 	struct v4l2_mbus_framefmt *format;
 	unsigned int i;
-	int ret = 0;
 
 	mutex_lock(&imx290->lock);
 
@@ -483,7 +482,7 @@ static int imx290_set_fmt(struct v4l2_su
 
 	mutex_unlock(&imx290->lock);
 
-	return ret;
+	return 0;
 }
 
 static int imx290_entity_init_cfg(struct v4l2_subdev *subdev,