staging: comedi: Capitalize macro name to fix camelcase checkpatch warning
PATCH 1/1 staging: comedi: Capitalize macro name to fix camelcase checkpatch warning
Capitalize RANGE_mA to fix camelcase check warning. Issue reported by checkpatch.pl
--- drivers/staging/comedi/comedidev.h | 2 +- drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++-- drivers/staging/comedi/drivers/dac02.c | 2 +- drivers/staging/comedi/range.c | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-)
drivers/staging/comedi/comedidev.h +1 -1
@@ -603,7 +603,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,#define RANGE (a, b) {(a) * 1e6, (b) * 1e6, 0}#define RANGE_ext (a, b) {(a) * 1e6, (b) * 1e6, RF_EXTERNAL} -#define RANGE_mA (a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA} +#define RANGE_MA (a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}#define RANGE_unitless (a, b) {(a) * 1e6, (b) * 1e6, 0}#define BIP_RANGE (a) {-(a) * 1e6, (a) * 1e6, 0}#define UNI_RANGE (a) {0, (a) * 1e6, 0}
drivers/staging/comedi/drivers/adv_pci1724.c +2 -2
@@ -64,8 +64,8 @@static const struct comedi_lrange adv_pci1724_ao_ranges = {4 , {BIP_RANGE (10 ), -RANGE_mA (0 ,20 ), -RANGE_mA (4 ,20 ), +RANGE_MA (0 ,20 ), +RANGE_MA (4 ,20 ),RANGE_unitless (0 ,1 ) } };
drivers/staging/comedi/drivers/dac02.c +1 -1
@@ -54,7 +54,7 @@ static const struct comedi_lrange das02_ao_ranges = {UNI_RANGE (10 ),BIP_RANGE (5 ),BIP_RANGE (10 ), -RANGE_mA (4 ,20 ), +RANGE_MA (4 ,20 ), RANGE_ext(0, 1) } };
drivers/staging/comedi/range.c +3 -3
@@ -23,11 +23,11 @@ const struct comedi_lrange range_unipolar5 = { 1, {UNI_RANGE(5)} };EXPORT_SYMBOL_GPL (range_unipolar5);const struct comedi_lrange range_unipolar2_5 = {1 , {UNI_RANGE (2.5 )} };EXPORT_SYMBOL_GPL (range_unipolar2_5); -const struct comedi_lrange range_0_20mA = {1 , {RANGE_mA (0 ,20 )} }; +const struct comedi_lrange range_0_20mA = {1 , {RANGE_MA (0 ,20 )} };EXPORT_SYMBOL_GPL (range_0_20mA); -const struct comedi_lrange range_4_20mA = {1 , {RANGE_mA (4 ,20 )} }; +const struct comedi_lrange range_4_20mA = {1 , {RANGE_MA (4 ,20 )} };EXPORT_SYMBOL_GPL (range_4_20mA); -const struct comedi_lrange range_0_32mA = {1 , {RANGE_mA (0 ,32 )} }; +const struct comedi_lrange range_0_32mA = {1 , {RANGE_MA (0 ,32 )} };EXPORT_SYMBOL_GPL (range_0_32mA);const struct comedi_lrange range_unknown = {1 , {{0 ,1000000 , UNIT_none} } };EXPORT_SYMBOL_GPL (range_unknown);
Signature · 1 line
2.21.0
Quoted 2 lines · Jules Irenge
Capitalize
RANGE_mAto fix camelcase check warning. Issue reported by checkpatch.pl
I guess mA means something, so it would be better to keep it?
julia
Quoted 77 lines
Signed-off-by Jules Irenge <[email protected]>--- drivers/staging/comedi/comedidev.h | 2 +- drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++-- drivers/staging/comedi/drivers/dac02.c | 2 +- drivers/staging/comedi/range.c | 6 +++--- 4 files changed, 7 insertions(+), 7 deletions(-)drivers/staging/comedi/comedidev.h +1
-1@@ -603,7 +603,7 @@ int comedi_check_chanlist(struct comedi_subdevice *s,#define RANGE (a, b) {(a) * 1e6, (b) * 1e6, 0}#define RANGE_ext (a, b) {(a) * 1e6, (b) * 1e6, RF_EXTERNAL} -#define RANGE_mA (a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA} +#define RANGE_MA (a, b) {(a) * 1e6, (b) * 1e6, UNIT_MA}#define RANGE_unitless (a, b) {(a) * 1e6, (b) * 1e6, 0}#define BIP_RANGE (a) {-(a) * 1e6, (a) * 1e6, 0}#define UNI_RANGE (a) {0, (a) * 1e6, 0}drivers/staging/comedi/drivers/adv_pci1724.c +2
-2@@ -64,8 +64,8 @@static const struct comedi_lrange adv_pci1724_ao_ranges = {4 , {BIP_RANGE (10 ), -RANGE_mA (0 ,20 ), -RANGE_mA (4 ,20 ), +RANGE_MA (0 ,20 ), +RANGE_MA (4 ,20 ),RANGE_unitless (0 ,1 ) } };drivers/staging/comedi/drivers/dac02.c +1
-1@@ -54,7 +54,7 @@ static const struct comedi_lrange das02_ao_ranges = {UNI_RANGE (10 ),BIP_RANGE (5 ),BIP_RANGE (10 ), -RANGE_mA (4 ,20 ), +RANGE_MA (4 ,20 ), RANGE_ext(0, 1) } };drivers/staging/comedi/range.c +3
-4@@ -23,11 +23,11 @@ const struct comedi_lrange range_unipolar5 = { 1, {UNI_RANGE(5)} };EXPORT_SYMBOL_GPL (range_unipolar5);const struct comedi_lrange range_unipolar2_5 = {1 , {UNI_RANGE (2.5 )} };EXPORT_SYMBOL_GPL (range_unipolar2_5); -const struct comedi_lrange range_0_20mA = {1 , {RANGE_mA (0 ,20 )} }; +const struct comedi_lrange range_0_20mA = {1 , {RANGE_MA (0 ,20 )} };EXPORT_SYMBOL_GPL (range_0_20mA); -const struct comedi_lrange range_4_20mA = {1 , {RANGE_mA (4 ,20 )} }; +const struct comedi_lrange range_4_20mA = {1 , {RANGE_MA (4 ,20 )} };EXPORT_SYMBOL_GPL (range_4_20mA); -const struct comedi_lrange range_0_32mA = {1 , {RANGE_mA (0 ,32 )} }; +const struct comedi_lrange range_0_32mA = {1 , {RANGE_MA (0 ,32 )} };EXPORT_SYMBOL_GPL (range_0_32mA);const struct comedi_lrange range_unknown = {1 , {{0 ,1000000 , UNIT_none} } };EXPORT_SYMBOL_GPL (range_unknown); --2.21.0
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191006184827.12021-1-jbi.octave%40gmail.com.
Greg KH
maintainerQuoted 8 lines · Julia Lawall
Quoted 2 lines · Jules Irenge
Capitalize
RANGE_mAto fix camelcase check warning. Issue reported by checkpatch.plI guess mA means something, so it would be better to keep it?
Yes it does, we need to keep it, sorry.
thanks,
greg k-h