staging: rtl8723bs: Replace string with identifier
PATCH 1/1 staging: rtl8723bs: Replace string with identifier
Replace the hardcoded function name with it's predefined identifier. Issue found by checkpatch.
--- drivers/staging/rtl8723bs/core/rtw_xmit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723bs/core/rtw_xmit.c +2 -2
@@ -2310,7 +2310,7 @@ s32 rtw_xmit(struct adapter *padapter, _pkt **ppkt)if (!pxmitframe) { drop_cnt++; -RT_TRACE (_module_xmit_osdep_c_, _drv_err_, ("rtw_xmit: no more pxmitframe\n" )); +RT_TRACE (_module_xmit_osdep_c_, _drv_err_, ("%s: no more pxmitframe\n" , __func__));DBG_COUNTER (padapter->tx_logs.core_tx_err_pxmitframe);return -1 ; }
@@ -2318,7 +2318,7 @@ s32 rtw_xmit(struct adapter *padapter, _pkt **ppkt) res =update_attrib (padapter, *ppkt, &pxmitframe->attrib);if (res == _FAIL) { -RT_TRACE (_module_xmit_osdep_c_, _drv_err_, ("rtw_xmit: update attrib fail\n" )); +RT_TRACE (_module_xmit_osdep_c_, _drv_err_, ("%s: update attrib fail\n" , __func__));#ifdef DBG_TX_DROP_FRAME DBG_871X ("DBG_TX_DROP_FRAME %s update attrib fail\n" , __func__);#endif
Signature · 1 line
2.20.1
Quoted 13 lines · Javier F. Arias
Replace the hardcoded function name with it's predefined identifier. Issue found by checkpatch.
Signed-off-by Javier F. Arias <[email protected]>--- drivers/staging/rtl8723bs/core/rtw_xmit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/rtl8723bs/core/rtw_xmit.c +0
-0
drivers/staging/rtl8723bs/core/rtw_xmit.c s32 rtw_xmit(struct adapter *padapter, _pkt **ppkt) · line 2313
Quoted 5 lines
drivers/staging/rtl8723bs/core/rtw_xmit.c +1
-1@@ -2310,7 +2310,7 @@ s32 rtw_xmit(struct adapter *padapter, _pkt **ppkt)if (!pxmitframe) { drop_cnt++; -RT_TRACE (_module_xmit_osdep_c_, _drv_err_, ("rtw_xmit: no more pxmitframe\n" )); +RT_TRACE (_module_xmit_osdep_c_, _drv_err_, ("%s: no more pxmitframe\n" , __func__));
This is not really respecting the 80 column limit.Maybecheckpatch doesn't complain because the overflow is in a string, but there could be a newline after _drv_err_,
julia
Quoted 20 lines
drivers/staging/rtl8723bs/core/rtw_xmit.c +1
-2DBG_COUNTER (padapter->tx_logs.core_tx_err_pxmitframe);return -1 ; }@@ -2318,7 +2318,7 @@ s32 rtw_xmit(struct adapter *padapter, _pkt **ppkt) res =update_attrib (padapter, *ppkt, &pxmitframe->attrib);if (res == _FAIL) { -RT_TRACE (_module_xmit_osdep_c_, _drv_err_, ("rtw_xmit: update attrib fail\n" )); +RT_TRACE (_module_xmit_osdep_c_, _drv_err_, ("%s: update attrib fail\n" , __func__));#ifdef DBG_TX_DROP_FRAME DBG_871X ("DBG_TX_DROP_FRAME %s update attrib fail\n" , __func__);#endif --2.20.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191007144719.2zzlljlqymdqgom7%40gmail.com.