Skip to contentSkip to conversation

staging: rtl8723bs: Fix line over 80 characters

PATCH In review Javier F. Arias 3 participants 5 messages Oct 8, 2019 – Oct 9, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8723bs: Fix line over 80 characters

Break last two function call arguments into two separate lines. Issue found by checkpatch.

---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +2 -1
index 6d18d23acdc0..43af76b9fa49 100644
@@ -217,7 +217,8 @@ void expire_timeout_chk(struct adapter *padapter)
 	#ifdef DBG_EXPIRATION_CHK
 	if (phead != plist) {
 		DBG_871X(FUNC_NDEV_FMT" auth_list, cnt:%u\n"
-			, FUNC_NDEV_ARG(padapter->pnetdev), pstapriv->auth_list_cnt);
+			, FUNC_NDEV_ARG(padapter->pnetdev)
+			, pstapriv->auth_list_cnt);
 	}
 	#endif
 	while (phead != plist) {
Signature · 1 line
2.20.1
#1 lore raw
Quoted 13 lines · Javier F. Arias

Break last two function call arguments into two separate lines. Issue found by checkpatch.

---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +0 -0
index 6d18d23acdc0..43af76b9fa49 100644

drivers/staging/rtl8723bs/core/rtw_ap.c void expire_timeout_chk(struct adapter *padapter) · line 221

Quoted 6 lines
drivers/staging/rtl8723bs/core/rtw_ap.c +2 -1
@@ -217,7 +217,8 @@ void expire_timeout_chk(struct adapter *padapter)
 	#ifdef DBG_EXPIRATION_CHK
 	if (phead != plist) {
 		DBG_871X(FUNC_NDEV_FMT" auth_list, cnt:%u\n"
-			, FUNC_NDEV_ARG(padapter->pnetdev), pstapriv->auth_list_cnt);
+			, FUNC_NDEV_ARG(padapter->pnetdev)
+			, pstapriv->auth_list_cnt);

It's not normal in the kernel to put the commas at the beginning of the line like that.

julia

Quoted 11 lines
drivers/staging/rtl8723bs/core/rtw_ap.c +0 -1
 	}
 	#endif
 	while (phead != plist) {
--

2.20.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191008210850.ldgx5n3sahpdauvu%40gmail.com.

#2 lore raw

Hello Julia,

Thanks for the feedback. The first line was originally like this so I just split the last argument. Should I fix that issue in this commit too or create a new one?

Quoted 48 lines · Julia Lawall

Review

Quoted 9 lines · Javier F. Arias

Break last two function call arguments into two separate lines. Issue found by checkpatch.

Signed-off-by Javier F. Arias <[email protected] <javascript:>>

---

 drivers/staging/rtl8723bs/core/rtw_ap.c | 3 ++- 
 1 file changed, 2 insertions(+), 1 deletion(-) 
(quoted diff) +0 -0

b/drivers/staging/rtl8723bs/core/rtw_ap.c

drivers/staging/rtl8723bs/core/rtw_ap.c void expire_timeout_chk(struct adapter *padapter) · line 220

Quoted 8 lines

index 6d18d23acdc0..43af76b9fa49 100644

drivers/staging/rtl8723bs/core/rtw_ap.c +0 -1
@@ -217,7 +217,8 @@ void expire_timeout_chk(struct adapter *padapter) 
         #ifdef DBG_EXPIRATION_CHK 
         if (phead != plist) { 
                 DBG_871X(FUNC_NDEV_FMT" auth_list, cnt:%u\n" 
-                        , FUNC_NDEV_ARG(padapter->pnetdev), 

pstapriv->auth_list_cnt);

drivers/staging/rtl8723bs/core/rtw_ap.c void expire_timeout_chk(struct adapter *padapter) · line 221

Quoted 2 lines
drivers/staging/rtl8723bs/core/rtw_ap.c +2 -0
+                        , FUNC_NDEV_ARG(padapter->pnetdev) 
+                        , pstapriv->auth_list_cnt); 

It's not normal in the kernel to put the commas at the beginning of the line like that.

julia

Quoted 8 lines
drivers/staging/rtl8723bs/core/rtw_ap.c +0 -0
         } 
         #endif 
         while (phead != plist) { 
Signature · 4 lines
2.20.1 

-- 
You received this message because you are subscribed to the Google 

Groups "outreachy-kernel" group.

Quoted 1 line

To unsubscribe from this group and stop receiving emails from it, send

an email to [email protected] <javascript:>.

Quoted 1 line

To view this discussion on the web visit

https://groups.google.com/d/msgid/outreachy-kernel/20191008210850.ldgx5n3sahpdauvu%40gmail.com.

Quoted 1 line
#3 lore raw
Quoted 5 lines · Javier Arias

Hello Julia,

Thanks for the feedback. The first line was originally like this so I just split the last argument. Should I fix that issue in this commit too or create a new one?

You could make a series of the two kinds of changes.

If you send two independent patches on the same file, Greg will be unsure of the order in which to apply them.

julia

Quoted 60 lines · Julia Lawall

      On Tue, 8 Oct 2019, Javier F. Arias wrote:

      > Break last two function call arguments into two separate
      lines.
      > Issue found by checkpatch.
      >
      > Signed-off-by: Javier F. Arias <[email protected]>
      > ---
      >  drivers/staging/rtl8723bs/core/rtw_ap.c | 3 ++-
      >  1 file changed, 2 insertions(+), 1 deletion(-)
      >
      > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c
      b/drivers/staging/rtl8723bs/core/rtw_ap.c
      > index 6d18d23acdc0..43af76b9fa49 100644
      > --- a/drivers/staging/rtl8723bs/core/rtw_ap.c
      > +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
      > @@ -217,7 +217,8 @@ void expire_timeout_chk(struct adapter
      *padapter)
      >          #ifdef DBG_EXPIRATION_CHK
      >          if (phead != plist) {
      >                  DBG_871X(FUNC_NDEV_FMT" auth_list, cnt:%u\n"
      > -                        , FUNC_NDEV_ARG(padapter->pnetdev),
      pstapriv->auth_list_cnt);
      > +                        , FUNC_NDEV_ARG(padapter->pnetdev)
      > +                        , pstapriv->auth_list_cnt);

      It's not normal in the kernel to put the commas at the beginning
      of the
      line like that.

      julia

      >          }
      >          #endif
      >          while (phead != plist) {
      > --
      > 2.20.1
      >
      > --
      > You received this message because you are subscribed to the
      Google Groups "outreachy-kernel" group.
      > To unsubscribe from this group and stop receiving emails from
      it, send an email to [email protected].
      > To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/20191008210850.ldgx5n3sa
      hpdauvu%40gmail.com.
      >

--
You received this message because you are subscribed to the Google Groups
"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to [email protected].
To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/c9163826-7e60-4668-8ccc- 04ce37106e4f%40googlegroups.com.

#4 lore raw

Ok. I sent a patchset to deal with this issue.

Thanks

Quoted 83 lines · Julia Lawall
Quoted 3 lines · Javier Arias

Hello Julia,

Thanks for the feedback. The first line was originally like this so I

just

Quoted 2 lines

split the last argument. Should I fix that issue in this commit too or create a new one?

You could make a series of the two kinds of changes.

If you send two independent patches on the same file, Greg will be unsure of the order in which to apply them.

julia

Quoted 40 lines · Julia Lawall

      On Tue, 8 Oct 2019, Javier F. Arias wrote: 

      > Break last two function call arguments into two separate 
      lines. 
      > Issue found by checkpatch. 
      > 
      > Signed-off-by: Javier F. Arias <[email protected]> 
      > --- 
      >  drivers/staging/rtl8723bs/core/rtw_ap.c | 3 ++- 
      >  1 file changed, 2 insertions(+), 1 deletion(-) 
      > 
      > diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c 
      b/drivers/staging/rtl8723bs/core/rtw_ap.c 
      > index 6d18d23acdc0..43af76b9fa49 100644 
      > --- a/drivers/staging/rtl8723bs/core/rtw_ap.c 
      > +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c 
      > @@ -217,7 +217,8 @@ void expire_timeout_chk(struct adapter 
      *padapter) 
      >          #ifdef DBG_EXPIRATION_CHK 
      >          if (phead != plist) { 
      >                  DBG_871X(FUNC_NDEV_FMT" auth_list, cnt:%u\n" 
      > -                        , FUNC_NDEV_ARG(padapter->pnetdev), 
      pstapriv->auth_list_cnt); 
      > +                        , FUNC_NDEV_ARG(padapter->pnetdev) 
      > +                        , pstapriv->auth_list_cnt); 

      It's not normal in the kernel to put the commas at the beginning 
      of the 
      line like that. 

      julia 

      >          } 
      >          #endif 
      >          while (phead != plist) { 
      > -- 
Quoted 8 lines
      > 2.20.1 
      > 
      > -- 
      > You received this message because you are subscribed to the 
      Google Groups "outreachy-kernel" group. 
      > To unsubscribe from this group and stop receiving emails from 
      it, send an email to [email protected]. 
      > To view this discussion on the web visithttps://

groups.google.com/d/msgid/outreachy-kernel/20191008210850.ldgx5n3sa

Quoted 5 lines
      hpdauvu%40gmail.com. 
      > 
Signature · 1 line
You received this message because you are subscribed to the Google 

Groups

Quoted 2 lines

"outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send

an

Quoted 2 lines

email to [email protected] <javascript:>. To view this discussion on the web visithttps://

groups.google.com/d/msgid/outreachy-kernel/c9163826-7e60-4668-8ccc-

Quoted 3 lines

04ce37106e4f%40googlegroups.com.