Skip to contentSkip to conversation

staging: sm750fb: Edit CamelCase in ddk750_power.h

PATCH In review Jamal Shareef 2 participants 3 messages Oct 18, 2019 – Oct 20, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: sm750fb: Edit CamelCase in ddk750_power.h

Removes instances of CamelCase. Issue found by checkpatch.

---
 drivers/staging/sm750fb/ddk750_power.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/sm750fb/ddk750_power.h +5 -5
index 7002567a47d2..cd892f2b717f 100644
@@ -3,10 +3,10 @@
 #define DDK750_POWER_H__
 
 enum dpms {
-	crtDPMS_ON = 0x0,
-	crtDPMS_STANDBY = 0x1,
-	crtDPMS_SUSPEND = 0x2,
-	crtDPMS_OFF = 0x3,
+	crt_DPMS_ON = 0x0,
+	crt_DPMS_STANDBY = 0x1,
+	crt_DPMS_SUSPEND = 0x2,
+	crt_DPMS_OFF = 0x3,
 };
 
 #define set_DAC(off) {							\
@@ -15,7 +15,7 @@ enum dpms {
 }
 
 void ddk750_set_dpms(enum dpms state);
-void sm750_set_power_mode(unsigned int powerMode);
+void sm750_set_power_mode(unsigned int power_mode);
 void sm750_set_current_gate(unsigned int gate);
 
 /*
Signature · 1 line
2.17.1
#1 lore raw

You don't need to put the name of the file in the subject line. One can see that easily from the diffstat information.

Quoted 27 lines · Jamal Shareef

Removes instances of CamelCase. Issue found by checkpatch.

---
 drivers/staging/sm750fb/ddk750_power.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/sm750fb/ddk750_power.h +4 -4
index 7002567a47d2..cd892f2b717f 100644
@@ -3,10 +3,10 @@
 #define DDK750_POWER_H__
 
 enum dpms {
-	crtDPMS_ON = 0x0,
-	crtDPMS_STANDBY = 0x1,
-	crtDPMS_SUSPEND = 0x2,
-	crtDPMS_OFF = 0x3,
+	crt_DPMS_ON = 0x0,
+	crt_DPMS_STANDBY = 0x1,
+	crt_DPMS_SUSPEND = 0x2,
+	crt_DPMS_OFF = 0x3,
 };
 
 #define set_DAC(off) {							\

drivers/staging/sm750fb/ddk750_power.h enum dpms { · line 18

Quoted 5 lines
drivers/staging/sm750fb/ddk750_power.h +1 -1
@@ -15,7 +15,7 @@ enum dpms {
 }
 
 void ddk750_set_dpms(enum dpms state);
-void sm750_set_power_mode(unsigned int powerMode);
+void sm750_set_power_mode(unsigned int power_mode);

This looks suspicious. You shouldn't be updating only the prototype without updating the definition as well.

julia

Quoted 11 lines
drivers/staging/sm750fb/ddk750_power.h +0 -1
 void sm750_set_current_gate(unsigned int gate);
 
 /*
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191018020112.22226-1-jamal.k.shareef%40gmail.com.

#2 lore raw
Quoted 34 lines · Julia Lawall

You don't need to put the name of the file in the subject line. One can see that easily from the diffstat information.

Quoted 29 lines · Jamal Shareef

Removes instances of CamelCase. Issue found by checkpatch.

---
 drivers/staging/sm750fb/ddk750_power.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/sm750fb/ddk750_power.h +4 -4
index 7002567a47d2..cd892f2b717f 100644
@@ -3,10 +3,10 @@
 #define DDK750_POWER_H__
 
 enum dpms {
-	crtDPMS_ON = 0x0,
-	crtDPMS_STANDBY = 0x1,
-	crtDPMS_SUSPEND = 0x2,
-	crtDPMS_OFF = 0x3,
+	crt_DPMS_ON = 0x0,
+	crt_DPMS_STANDBY = 0x1,
+	crt_DPMS_SUSPEND = 0x2,
+	crt_DPMS_OFF = 0x3,
 };
 
 #define set_DAC(off) {							\
@@ -15,7 +15,7 @@ enum dpms {
 }
 
Quoted 9 lines

drivers/staging/sm750fb/ddk750_power.h enum dpms { · line 18

Quoted 3 lines
drivers/staging/sm750fb/ddk750_power.h +1 -1
 void ddk750_set_dpms(enum dpms state);
-void sm750_set_power_mode(unsigned int powerMode);
+void sm750_set_power_mode(unsigned int power_mode);

This looks suspicious. You shouldn't be updating only the prototype without updating the definition as well.

julia

A grep for these function names doesn't return any other hits. It does look suspicious however. This enum is used by other function but not by use of the enum labels themselves initially.

Jamal

Quoted 11 lines
Quoted 11 lines
drivers/staging/sm750fb/ddk750_power.h +0 -1
 void sm750_set_current_gate(unsigned int gate);
 
 /*
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191018020112.22226-1-jamal.k.shareef%40gmail.com.