usbip: Fix free of unallocated memory in vhci tx
Subsystems (2)
PATCH v2 1/1 usbip: Fix free of unallocated memory in vhci tx
iso_buffer should be set to NULL after use and free in the while loop. In the case of isochronous URB in the while loop, iso_buffer is allocated and after sending it to server, buffer is deallocated. And then, if the next URB in the while loop is not a isochronous pipe, iso_buffer still holds the previously deallocated buffer address and kfree tries to free wrong buffer address.
---
v1 - v2: Move the setting NULL after kfree() and add the comment
--- drivers/usb/usbip/vhci_tx.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/usb/usbip/vhci_tx.c +3 -0
@@ -147,7 +147,10 @@ static int vhci_send_cmd_submit(struct vhci_device *vdev) }kfree (iov); +/* This is only for isochronous case */ kfree (iso_buffer); + iso_buffer =NULL ; +usbip_dbg_vhci_tx ("send txdata\n" ); total_size += txsize;
Signature · 1 line
2.20.1
Quoted 11 lines · Suwan Kim
iso_buffershould be set to NULL after use and free in the while loop. In the case of isochronous URB in the while loop,iso_bufferis allocated and after sending it to server, buffer is deallocated. And then, if the next URB in the while loop is not a isochronous pipe,iso_bufferstill holds the previously deallocated buffer address and kfree tries to free wrong buffer address.Fixes ea44d190764b ("usbip: Implement SG support to vhci-hcd and stub driver")Reported-by kbuild test robot <[email protected]>Reported-by Julia Lawall <[email protected]>Signed-off-by Suwan Kim <[email protected]>
Quoted 25 lines
---
v1 - v2: Move the setting NULL afterkfree()and add the comment--- drivers/usb/usbip/vhci_tx.c | 3 +++ 1 file changed, 3 insertions(+)drivers/usb/usbip/vhci_tx.c +3
-1@@ -147,7 +147,10 @@ static int vhci_send_cmd_submit(struct vhci_device *vdev) }kfree (iov); +/* This is only for isochronous case */ kfree (iso_buffer); + iso_buffer =NULL ; +usbip_dbg_vhci_tx ("send txdata\n" ); total_size += txsize; --2.20.1
Quoted 11 lines · Julia Lawall
Quoted 7 lines · Suwan Kim
iso_buffershould be set to NULL after use and free in the while loop. In the case of isochronous URB in the while loop,iso_bufferis allocated and after sending it to server, buffer is deallocated. And then, if the next URB in the while loop is not a isochronous pipe,iso_bufferstill holds the previously deallocated buffer address and kfree tries to free wrong buffer address.
Quoted 10 lines
Quoted 4 lines
Fixes ea44d190764b ("usbip: Implement SG support to vhci-hcd and stub driver")Reported-by kbuild test robot <[email protected]>Reported-by Julia Lawall <[email protected]>Signed-off-by Suwan Kim <[email protected]>Reviewed-by Julia Lawall <[email protected]>Quoted 3 lines
---
v1 - v2: Move the setting NULL afterkfree()and add the comment
---
Thanks.
thanks,
-- Shuah