media: coda: jpeg: fix platform_get_irq.cocci warnings
PATCH 1/1 media: coda: jpeg: fix platform_get_irq.cocci warnings
From: kbuild test robot <[email protected]>
Error report is redundant because platform_get_irq() already prints an error
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
---
The {} will need to be removed as well.
url: https://github.com/0day-ci/linux/commits/Philipp-Zabel/media-coda-do-not-skip-finish_run-if-aborting/20191114-025803 base: git://linuxtv.org/media_tree.git master
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
Please take the patch only if it's a positive warning. Thanks!
coda-common.c | 1 - 1 file changed, 1 deletion(-)
drivers/media/platform/coda/coda-common.c +0 -1
@@ -3019,7 +3019,6 @@ static int coda_probe(struct platform_deif (dev->devtype->product ==CODA_960 ) { irq =platform_get_irq_byname (pdev,"jpeg" );if (irq <0 ) { -dev_err (&pdev->dev,"failed to get jpeg irq resource\n" );return irq; }
Hi Julia,
Quoted 28 lines · Julia Lawall
From: kbuild test robot <[email protected]>
Error report is redundant because
platform_get_irq()already prints an errorGenerated by:
scripts/coccinelle/api/platform_get_irq.cocciFixes fb3a8aa62186 ("media: coda: jpeg: add CODA960 JPEG encoder support")CC Philipp Zabel <[email protected]>Signed-off-by kbuild test robot <[email protected]>Signed-off-by Julia Lawall <[email protected]>---
The {} will need to be removed as well.
url: https://github.com/0day-ci/linux/commits/Philipp-Zabel/media-coda-do-not-skip-finish_run-if-aborting/20191114-025803 base: git://linuxtv.org/media_tree.git master:::::: branch date: 4 days ago
:::::: commit date: 4 days agoPlease take the patch only if it's a positive warning. Thanks!
coda-common.c | 1 - 1 file changed, 1 deletion(-)
drivers/media/platform/coda/coda-common.c static int coda_probe(struct platform_de · line 3024
Quoted 7 lines
drivers/media/platform/coda/coda-common.c +0
-1@@ -3019,7 +3019,6 @@ static int coda_probe(struct platform_deif (dev->devtype->product ==CODA_960 ) { irq =platform_get_irq_byname (pdev,"jpeg" );if (irq <0 ) { -dev_err (&pdev->dev,"failed to get jpeg irq resource\n" );return irq; }
Can you remove the {} as well? Those are no longer needed/wanted after removing the dev_err.
Thanks!
Hans
Quoted 28 lines · Hans Verkuil
Hi Julia,
Quoted 25 lines · Julia Lawall
From: kbuild test robot <[email protected]>
Error report is redundant because
platform_get_irq()already prints an errorGenerated by:
scripts/coccinelle/api/platform_get_irq.cocciFixes fb3a8aa62186 ("media: coda: jpeg: add CODA960 JPEG encoder support")CC Philipp Zabel <[email protected]>Signed-off-by kbuild test robot <[email protected]>Signed-off-by Julia Lawall <[email protected]>---
The {} will need to be removed as well.
url: https://github.com/0day-ci/linux/commits/Philipp-Zabel/media-coda-do-not-skip-finish_run-if-aborting/20191114-025803 base: git://linuxtv.org/media_tree.git master:::::: branch date: 4 days ago
:::::: commit date: 4 days agoPlease take the patch only if it's a positive warning. Thanks!
coda-common.c | 1 - 1 file changed, 1 deletion(-)
Quoted 13 lines
drivers/media/platform/coda/coda-common.c static int coda_probe(struct platform_de · line 3024
Quoted 10 lines
drivers/media/platform/coda/coda-common.c +0
-1@@ -3019,7 +3019,6 @@ static int coda_probe(struct platform_deif (dev->devtype->product ==CODA_960 ) { irq =platform_get_irq_byname (pdev,"jpeg" );if (irq <0 ) { -dev_err (&pdev->dev,"failed to get jpeg irq resource\n" );return irq; }Can you remove the {} as well? Those are no longer needed/wanted after removing the
dev_err.
I have fixed this in v2.
regards
Philipp