Skip to contentSkip to conversation

objtool, perf: fix ifnullfree.cocci warnings

PATCH New Julia Lawall 1 participant 1 message Jan 10, 2020 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 objtool, perf: fix ifnullfree.cocci warnings

NULL check before some freeing functions is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes 4864b0702653 ("objtool, perf: Fix GCC 8 -Wrestrict error")
CC Josh Poimboeuf <[email protected]>

---

tree:   https://android.googlesource.com/kernel/common android-4.9-o-mr1
head:   58ce54880a03d9c27327434ba15281f5a7139671
commit: 4864b070265301ba88506ee407d51e058dcb0ad6 [42/51] objtool, perf: Fix GCC 8 -Wrestrict error

:::::: branch date: 29 hours ago
:::::: commit date: 9 weeks ago

 bio-integrity.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
block/bio-integrity.c +2 -4
@@ -499,11 +499,9 @@ EXPORT_SYMBOL(bioset_integrity_create);
 
 void bioset_integrity_free(struct bio_set *bs)
 {
-	if (bs->bio_integrity_pool)
-		mempool_destroy(bs->bio_integrity_pool);
+	mempool_destroy(bs->bio_integrity_pool);
 
-	if (bs->bvec_integrity_pool)
-		mempool_destroy(bs->bvec_integrity_pool);
+	mempool_destroy(bs->bvec_integrity_pool);
 }
 EXPORT_SYMBOL(bioset_integrity_free);