Skip to contentSkip to conversation

MAINTAINERS: adjust to kobject doc ReST conversion

PATCH Applied Lukas Bulwahn 3 participants 4 messages Mar 4, 2020 – Mar 10, 2020

Subsystems (2)

v1 of 2 Applied Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: adjust to kobject doc ReST conversion

Commit 5fed00dcaca8 ("Documentation: kobject.txt has been moved to core-api/kobject.rst") missed to adjust the entry in MAINTAINERS.

Since then, ./scripts/get_maintainer.pl --self-test complains:

warning: no file matches F: Documentation/kobject.txt

Adjust DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS entry in MAINTAINERS.

---
Sameer, please ack.
Jonathan, pick pick this patch for doc-next.

 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index d064049aad1b..998d56e61a41 100644
@@ -5213,7 +5213,7 @@ M:	Greg Kroah-Hartman <[email protected]>
 R:	"Rafael J. Wysocki" <[email protected]>
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
 S:	Supported
-F:	Documentation/kobject.txt
+F:	Documentation/core-api/kobject.rst
 F:	drivers/base/
 F:	fs/debugfs/
 F:	fs/sysfs/
Signature · 1 line
2.17.1
#1 lore raw
Quoted 22 lines · Lukas Bulwahn

Commit 5fed00dcaca8 ("Documentation: kobject.txt has been moved to core-api/kobject.rst") missed to adjust the entry in MAINTAINERS.

Since then, ./scripts/get_maintainer.pl --self-test complains:

warning: no file matches F: Documentation/kobject.txt

Adjust DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS entry in MAINTAINERS.

---
Sameer, please ack.
Jonathan, pick pick this patch for doc-next.

  MAINTAINERS | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +0 -0
index d064049aad1b..998d56e61a41 100644

MAINTAINERS M: Greg Kroah-Hartman <[email protected]> · line 5219

Quoted 8 lines
MAINTAINERS +1 -1
@@ -5213,7 +5213,7 @@ M:	Greg Kroah-Hartman <[email protected]>
  R:	"Rafael J. Wysocki" <[email protected]>
  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
  S:	Supported
-F:	Documentation/kobject.txt
+F:	Documentation/core-api/kobject.rst
  F:	drivers/base/
  F:	fs/debugfs/
  F:	fs/sysfs/

Hi Lukas,

Thanks for the fix. It looks good to me

#2 lore raw
Quoted 4 lines · Sameer Rahmani

Thanks for the fix. It looks good to me

Sameer, in the kernel community, there is the convention to acknowledge a patch with responses, such as Acked-by or Reviewed-by. Maintainer scripts then allow the maintainer to pick those up automatically from the responses. So, you would respond in a new line with "Acked-by: your full name <your email address>".

You can read more on that here:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by

I hope this helps and is interesting to you.

Thanks for your review and quick response to my patch,

Lukas

maintainer Applied
#3 lore raw
In reply to Lukas Bulwahn
Quoted 5 lines · On Wed, 4 Mar 2020 12:08:21 +0100 Lukas Bulwahn <[email protected]>…

Commit 5fed00dcaca8 ("Documentation: kobject.txt has been moved to core-api/kobject.rst") missed to adjust the entry in MAINTAINERS.

Since then, ./scripts/get_maintainer.pl --self-test complains:

Quoted 8 lines

warning: no file matches F: Documentation/kobject.txt

Adjust DRIVER CORE, KOBJECTS, DEBUGFS AND SYSFS entry in MAINTAINERS.

---
Sameer, please ack.
Jonathan, pick pick this patch for doc-next.

Applied, thanks.

jon