Skip to contentSkip to conversation

Fix line over 80 characters

PATCH In review Gokce Kuler 3 participants 3 messages Mar 7, 2020 – Mar 8, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix line over 80 characters

Fix line over 80 characters

---
 drivers/staging/exfat/exfat_super.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/exfat/exfat_super.c +2 -1
index 1ae5a77..37e424f 100644
@@ -2161,7 +2161,8 @@ static int ffsRemoveDir(struct inode *inode, struct file_id_t *fid)
 	mutex_lock(&p_fs->v_mutex);
 
 	clu_to_free.dir = fid->start_clu;
-	clu_to_free.size = (s32)((fid->size - 1) >> p_fs->cluster_size_bits) + 1;
+	clu_to_free.size = (s32)((fid->size - 1) >>
+		       	p_fs->cluster_size_bits) + 1;
 	clu_to_free.flags = fid->flags;
 
 	if (!is_dir_empty(sb, &clu_to_free)) {
Signature · 1 line
2.7.4
#1 lore raw
Quoted 11 lines · Gokce Kuler

Fix line over 80 characters

---
 drivers/staging/exfat/exfat_super.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/exfat/exfat_super.c +0 -0
index 1ae5a77..37e424f 100644

drivers/staging/exfat/exfat_super.c static int ffsRemoveDir(struct inode *inode, struct file_id_t *fid) · line 2165

Quoted 6 lines
drivers/staging/exfat/exfat_super.c +2 -1
@@ -2161,7 +2161,8 @@ static int ffsRemoveDir(struct inode *inode, struct file_id_t *fid)
 	mutex_lock(&p_fs->v_mutex);
 
 	clu_to_free.dir = fid->start_clu;
-	clu_to_free.size = (s32)((fid->size - 1) >> p_fs->cluster_size_bits) + 1;
+	clu_to_free.size = (s32)((fid->size - 1) >>
+		       	p_fs->cluster_size_bits) + 1;

Maybe the changed code is more confusing than the original, because now the ( is on one line and the corresponding ) is on a different line. One could think that the whole second line is the right argument of the >>.

I guess that the 1 could be on the second line, but it would look a bit lonely. So perhaps slightly exceeding 80 characters is actually the best option here.

julia

Quoted 11 lines
drivers/staging/exfat/exfat_super.c +0 -1
 	clu_to_free.flags = fid->flags;
 
 	if (!is_dir_empty(sb, &clu_to_free)) {
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200307202409.GA10517%40siyah2.

maintainer
#2 lore raw
In reply to Gokce Kuler
Quoted 23 lines · Gokce Kuler

Fix line over 80 characters

---
 drivers/staging/exfat/exfat_super.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/exfat/exfat_super.c +2 -1
index 1ae5a77..37e424f 100644
@@ -2161,7 +2161,8 @@ static int ffsRemoveDir(struct inode *inode, struct file_id_t *fid)
 	mutex_lock(&p_fs->v_mutex);
 
 	clu_to_free.dir = fid->start_clu;
-	clu_to_free.size = (s32)((fid->size - 1) >> p_fs->cluster_size_bits) + 1;
+	clu_to_free.size = (s32)((fid->size - 1) >>
+		       	p_fs->cluster_size_bits) + 1;
 	clu_to_free.flags = fid->flags;
 
 	if (!is_dir_empty(sb, &clu_to_free)) {
Signature · 1 line
2.7.4

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.

You are receiving this message because of the following common error(s) as indicated below:

- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like.

If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.

thanks,

greg k-h's patch email bot