staging: vt6655: remove line over 80 characters
PATCH 1/1 staging: vt6655: remove line over 80 characters
Fix line over 80 characters.
--- drivers/staging/vt6655/mac.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/staging/vt6655/mac.h +6 -3
@@ -884,9 +884,11 @@ bool MACbIsIntDisable(struct vnt_private *priv);void MACvSetShortRetryLimit (struct vnt_private *priv,unsigned char byRetryLimit); -void MACvSetLongRetryLimit (struct vnt_private *priv,unsigned char byRetryLimit); +void MACvSetLongRetryLimit (struct vnt_private *priv, +unsigned char byRetryLimit); -void MACvSetLoopbackMode (struct vnt_private *priv,unsigned char byLoopbackMode); +void MACvSetLoopbackMode (struct vnt_private *priv, +unsigned char byLoopbackMode);void MACvSaveContext (struct vnt_private *priv,unsigned char *pbyCxtBuf);void MACvRestoreContext (struct vnt_private *priv,unsigned char *pbyCxtBuf);
@@ -913,7 +915,8 @@ void MACvSetCurrSyncDescAddrEx(struct vnt_private *priv,void MACvSetCurrATIMDescAddrEx (struct vnt_private *priv,u32 curr_desc_addr);void MACvTimer0MicroSDelay (struct vnt_private *priv,unsigned int uDelay); -void MACvOneShotTimer1MicroSec (struct vnt_private *priv,unsigned int uDelayTime); +void MACvOneShotTimer1MicroSec (struct vnt_private *priv, +unsigned int uDelayTime);void MACvSetMISCFifo (struct vnt_private *priv,unsigned short wOffset,u32 dwData);
Signature · 1 line
2.17.1
Quoted 1 line · Payal Kshirsagar
Fix line over 80 characters.
The change is fine. However, the patch should be sent to more people. Search for get_maintainer in the tutorial.
Quoted 25 lines
Signed-off-by Payal Kshirsagar <[email protected]>--- drivers/staging/vt6655/mac.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)drivers/staging/vt6655/mac.h +4
-2@@ -884,9 +884,11 @@ bool MACbIsIntDisable(struct vnt_private *priv);void MACvSetShortRetryLimit (struct vnt_private *priv,unsigned char byRetryLimit); -void MACvSetLongRetryLimit (struct vnt_private *priv,unsigned char byRetryLimit); +void MACvSetLongRetryLimit (struct vnt_private *priv, +unsigned char byRetryLimit); -void MACvSetLoopbackMode (struct vnt_private *priv,unsigned char byLoopbackMode); +void MACvSetLoopbackMode (struct vnt_private *priv, +unsigned char byLoopbackMode);void MACvSaveContext (struct vnt_private *priv,unsigned char *pbyCxtBuf);void MACvRestoreContext (struct vnt_private *priv,unsigned char *pbyCxtBuf);
drivers/staging/vt6655/mac.h void MACvSetCurrSyncDescAddrEx(struct vnt_private *priv, · line 919
Quoted 6 lines
drivers/staging/vt6655/mac.h +2
-1@@ -913,7 +915,8 @@ void MACvSetCurrSyncDescAddrEx(struct vnt_private *priv,void MACvSetCurrATIMDescAddrEx (struct vnt_private *priv,u32 curr_desc_addr);void MACvTimer0MicroSDelay (struct vnt_private *priv,unsigned int uDelay); -void MACvOneShotTimer1MicroSec (struct vnt_private *priv,unsigned int uDelayTime); +void MACvOneShotTimer1MicroSec (struct vnt_private *priv, +unsigned int uDelayTime);
If you want to work more on this file, you could improve the naming of variables. This code is starting variables with p when the variable has a pointer type and u when the variable has an unsigned type. The kernel doesn't follow that convention. Also, camel case should not be used. This uDelayTime should be delay_time.
These are actually function prototypes. So you would change both the function prototype shown here and the definition, which is probably in some .c file.
julia