Skip to contentSkip to conversation

staging: exfat: alignment should match open parenthesis

PATCH In review Payal Kshirsagar 3 participants 3 messages Mar 8, 2020 – Mar 9, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: exfat: alignment should match open parenthesis

Align code to match open parenthesis.

---
 drivers/staging/exfat/exfat.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/exfat/exfat.h +2 -2
index c863d7566b57..341c9192f7e8 100644
@@ -716,9 +716,9 @@ int multi_sector_write(struct super_block *sb, sector_t sec,
 void exfat_bdev_open(struct super_block *sb);
 void exfat_bdev_close(struct super_block *sb);
 int exfat_bdev_read(struct super_block *sb, sector_t secno,
-	      struct buffer_head **bh, u32 num_secs, bool read);
+		    struct buffer_head **bh, u32 num_secs, bool read);
 int exfat_bdev_write(struct super_block *sb, sector_t secno,
-	       struct buffer_head *bh, u32 num_secs, bool sync);
+		     struct buffer_head *bh, u32 num_secs, bool sync);
 int exfat_bdev_sync(struct super_block *sb);
 
 /* cluster operation functions */
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · On Sun, 8 Mar 2020 23:50:46 +0530 Payal Kshirsagar…

Align code to match open parenthesis.

---
 drivers/staging/exfat/exfat.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/exfat/exfat.h +0 -0
index c863d7566b57..341c9192f7e8 100644
@@ -716,9 +716,9 @@ int multi_sector_write(struct super_block *sb, sector_t sec,
 void exfat_bdev_open(struct super_block *sb);

drivers/staging/exfat/exfat.h int multi_sector_write(struct super_block *sb, sector_t sec, · line 724

Quoted 10 lines
drivers/staging/exfat/exfat.h +2 -2
 void exfat_bdev_close(struct super_block *sb);
 int exfat_bdev_read(struct super_block *sb, sector_t secno,
-	      struct buffer_head **bh, u32 num_secs, bool read);
+		    struct buffer_head **bh, u32 num_secs, bool read);
 int exfat_bdev_write(struct super_block *sb, sector_t secno,
-	       struct buffer_head *bh, u32 num_secs, bool sync);
+		     struct buffer_head *bh, u32 num_secs, bool sync);
 int exfat_bdev_sync(struct super_block *sb);
 
 /* cluster operation functions */

The change itself looks good, but as Julia mentioned, you should use get_maintainer.pl and send these changes to more people. In this case, adding exFAT maintainer and [email protected] to
Cc: would be nice.

Note that this also depends on habits, lists, personal preferences. You will find that some contributors Cc: the whole list from get_maintainer.pl (which is fine by all means), some contributors might already know who is actually interested in changes (and not Cc: all results). Depending on what subsystem you're contributing to, you'll get familiar with practice.

Signature · 1 line
Stefano
#2 lore raw
Quoted 32 lines · Stefano Brivio
Quoted 13 lines · On Sun, 8 Mar 2020 23:50:46 +0530 Payal Kshirsagar…

Align code to match open parenthesis.

---
 drivers/staging/exfat/exfat.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/exfat/exfat.h +0 -0
index c863d7566b57..341c9192f7e8 100644
@@ -716,9 +716,9 @@ int multi_sector_write(struct super_block *sb, sector_t sec,
 void exfat_bdev_open(struct super_block *sb);

drivers/staging/exfat/exfat.h int multi_sector_write(struct super_block *sb, sector_t sec, · line 724

Quoted 10 lines
drivers/staging/exfat/exfat.h +2 -2
 void exfat_bdev_close(struct super_block *sb);
 int exfat_bdev_read(struct super_block *sb, sector_t secno,
-	      struct buffer_head **bh, u32 num_secs, bool read);
+		    struct buffer_head **bh, u32 num_secs, bool read);
 int exfat_bdev_write(struct super_block *sb, sector_t secno,
-	       struct buffer_head *bh, u32 num_secs, bool sync);
+		     struct buffer_head *bh, u32 num_secs, bool sync);
 int exfat_bdev_sync(struct super_block *sb);
 
 /* cluster operation functions */

The change itself looks good, but as Julia mentioned, you should use get_maintainer.pl and send these changes to more people. In this case, adding exFAT maintainer and [email protected] to
Cc: would be nice.

Quoted 6 lines

Note that this also depends on habits, lists, personal preferences. You will find that some contributors Cc: the whole list from get_maintainer.pl (which is fine by all means), some contributors might already know who is actually interested in changes (and not Cc: all results). Depending on what subsystem you're contributing to, you'll get familiar with practice.

A lot of options are suggested in the Outreachy tutorial that can be used to avoid sending patches to everyone who has ever touched the file.

julia

Quoted 9 lines

--
Stefano

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200309124025.3b8d039a%40elisabeth.