Skip to contentSkip to conversation

staging: rtl8712: Avoid multiple line dereference

PATCH In review Gokce Kuler 2 participants 2 messages Mar 20, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8712: Avoid multiple line dereference

merge a line -> with a line ending with a sign

---
 drivers/staging/rtl8712/rtl871x_mlme.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8712/rtl871x_mlme.c +1 -2
index 74dac74..7d5a50a 100644
@@ -1094,8 +1094,7 @@ int r8712_select_and_join_from_scan(struct mlme_priv *pmlmepriv)
 			src_ssid = pmlmepriv->assoc_bssid;
 			if (!memcmp(dst_ssid, src_ssid, ETH_ALEN)) {
 				if (check_fwstate(pmlmepriv, _FW_LINKED)) {
-					if (is_same_network(&pmlmepriv->
-					    cur_network.network,
+					if (is_same_network(&pmlmepriv->cur_network.network,
 					    &pnetwork->network)) {
 						_clr_fwstate_(pmlmepriv,
 							_FW_UNDER_LINKING);
Signature · 1 line
2.7.4
#1 lore raw
Quoted 12 lines · Gokce Kuler

merge a line -> with a line ending with a sign

---
 drivers/staging/rtl8712/rtl871x_mlme.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8712/rtl871x_mlme.c +0 -0
index 74dac74..7d5a50a 100644

drivers/staging/rtl8712/rtl871x_mlme.c int r8712_select_and_join_from_scan(struct mlme_priv *pmlmepriv) · line 1098

Quoted 7 lines
drivers/staging/rtl8712/rtl871x_mlme.c +1 -2
@@ -1094,8 +1094,7 @@ int r8712_select_and_join_from_scan(struct mlme_priv *pmlmepriv)
 			src_ssid = pmlmepriv->assoc_bssid;
 			if (!memcmp(dst_ssid, src_ssid, ETH_ALEN)) {
 				if (check_fwstate(pmlmepriv, _FW_LINKED)) {
-					if (is_same_network(&pmlmepriv->
-					    cur_network.network,
+					if (is_same_network(&pmlmepriv->cur_network.network,
 					    &pnetwork->network)) {

It's not really ideal to have the second argument so far to the left like this. It should be aligned with the right side of the ( after is_same_network.

julia

Quoted 10 lines
drivers/staging/rtl8712/rtl871x_mlme.c +0 -1
 						_clr_fwstate_(pmlmepriv,
 							_FW_UNDER_LINKING);
--

2.7.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200320091413.GA6302%40siyah2.