staging: mt7621-dma: quoted string split across lines
Subsystems (2)
PATCH 1/1 staging: mt7621-dma: quoted string split across lines
quoted string merge to upper line
--- drivers/staging/mt7621-dma/mtk-hsdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/mt7621-dma/mtk-hsdma.c +1 -2
@@ -241,8 +241,7 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma, tx_desc = &chan->tx_ring[i]; rx_desc = &chan->rx_ring[i]; -dev_dbg (hsdma->ddev.dev,"%d tx addr0: %08x, flags %08x, " -"tx addr1: %08x, rx addr0 %08x, flags %08x\n" , +dev_dbg (hsdma->ddev.dev,"%d tx addr0: %08x, flags %08x, tx addr1: %08x, rx addr0 %08x, flags %08x\n" , i, tx_desc->addr0, tx_desc->flags, tx_desc->addr1, rx_desc->addr0, rx_desc->flags); }
Signature · 1 line
2.7.4
You seem to have three patches with the same subject line. Perhaps you could merge them into a single patch.
Quoted 1 line · Gokce Kuler
quoted string merge to upper line
The verb should come first, so that would be Merge.
Upper line doesn't seem very useful.
Maybe it could be:
Concatenate a string that appeared on two lines, in order to make the atring easier to find if the message is printed.
julia
Quoted 27 lines
Signed-off-by Gokce Kuler <[email protected]>--- drivers/staging/mt7621-dma/mtk-hsdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/mt7621-dma/mtk-hsdma.c +1
-3@@ -241,8 +241,7 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma, tx_desc = &chan->tx_ring[i]; rx_desc = &chan->rx_ring[i]; -dev_dbg (hsdma->ddev.dev,"%d tx addr0: %08x, flags %08x, " -"tx addr1: %08x, rx addr0 %08x, flags %08x\n" , +dev_dbg (hsdma->ddev.dev,"%d tx addr0: %08x, flags %08x, tx addr1: %08x, rx addr0 %08x, flags %08x\n" , i, tx_desc->addr0, tx_desc->flags, tx_desc->addr1, rx_desc->addr0, rx_desc->flags); } --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200320233056.GA9027%40siyah2.
Greg KH
maintainerQuoted 23 lines · Gokce Kuler
quoted string merge to upper line
Signed-off-by Gokce Kuler <[email protected]>--- drivers/staging/mt7621-dma/mtk-hsdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/staging/mt7621-dma/mtk-hsdma.c +1
-2@@ -241,8 +241,7 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma, tx_desc = &chan->tx_ring[i]; rx_desc = &chan->rx_ring[i]; -dev_dbg (hsdma->ddev.dev,"%d tx addr0: %08x, flags %08x, " -"tx addr1: %08x, rx addr0 %08x, flags %08x\n" , +dev_dbg (hsdma->ddev.dev,"%d tx addr0: %08x, flags %08x, tx addr1: %08x, rx addr0 %08x, flags %08x\n" , i, tx_desc->addr0, tx_desc->flags, tx_desc->addr1, rx_desc->addr0, rx_desc->flags); }Signature · 1 line
2.7.4
You sent 2 patches with the same exact subject line, yet they did different things, which isn't ok. :(
Please fix up both and resend.
thanks,
greg k-h