Skip to contentSkip to conversation

staging: kpc2000: Removing a blank line

PATCH In review Simran Singhal 2 participants 2 messages Mar 25, 2020 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: kpc2000: Removing a blank line

This patch fixes the checkpatch warning by removing a blank line.
CHECK: Please don't use multiple blank lines

---
Changes in v2:
- Make the subject and commit message correct by mentioning that this patch specifically removes a blank line.

 drivers/staging/kpc2000/kpc2000/pcie.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/kpc2000/kpc2000/pcie.h +0 -1
index cb815c30faa4..f1fc91b4c704 100644
@@ -6,7 +6,6 @@
 #include "../kpc.h"
 #include "dma_common_defs.h"
 
-
 /*      System Register Map (BAR 1, Start Addr 0)
  *
  *  BAR Size:
Signature · 1 line
2.17.1
#1 lore raw
Quoted 3 lines · Simran Singhal

This patch fixes the checkpatch warning by removing a blank line.
CHECK: Please don't use multiple blank lines

The subject line and the log message should be written in the imperative. So that would be Remove, rather than Removing for the subject line.

The log message should first say what you did to fix the problem and why. How the problem was found can come afterwards. So you should not start with "This patch fixes the checkpatch warning by". "This patch" is not useful, because it is obvious that it is a patch, based on the subject line. "fixes" does not given any information about what is done or why. "the checkpatch warning" is useful, but it's not what one wants to see first.

julia

Quoted 30 lines

---
Changes in v2:
- Make the subject and commit message correct by mentioning that this patch specifically removes a blank line.

 drivers/staging/kpc2000/kpc2000/pcie.h | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/kpc2000/kpc2000/pcie.h +0 -2
index cb815c30faa4..f1fc91b4c704 100644
@@ -6,7 +6,6 @@
 #include "../kpc.h"
 #include "dma_common_defs.h"
 
-
 /*      System Register Map (BAR 1, Start Addr 0)
  *
  *  BAR Size:
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20200325095407.GA3788%40simran-Inspiron-5558.