staging: gasket: using octal permissions instead of symbolic permissions
PATCH 1/1 staging: gasket: using octal permissions instead of symbolic permissions
Since octal permissions is preffered to symbolic permissions, octal permissions is used.Problem found checkpatch.pl.
--- drivers/staging/gasket/gasket_sysfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/gasket/gasket_sysfs.h +1 -1
@@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {#define GASKET_SYSFS_RO (_name, _show_function, _attr_type) \ { \ - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \ + .attr = __ATTR(_name, 0444, _show_function, NULL), \ .data.attr_type = _attr_type \ }
Signature · 1 line
2.7.4
Quoted 4 lines · On Wed, 1 Apr 2020 02:09:40 +0300 Gokce Kuler <[email protected]> wrote:
Since octal permissions is preffered to symbolic permissions, octal permissions is used.Problem found checkpatch.pl.
Signed-off-by Gokce Kuler <[email protected]>
Signature · 1 line
Stefano
Greg KH
maintainerQuoted 13 lines · Gokce Kuler
Since octal permissions is preffered to symbolic permissions, octal permissions is used.Problem found checkpatch.pl.
Signed-off-by Gokce Kuler <[email protected]>--- drivers/staging/gasket/gasket_sysfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/gasket/gasket_sysfs.h +0
-0
drivers/staging/gasket/gasket_sysfs.h struct gasket_sysfs_attribute { · line 78
Quoted 5 lines
drivers/staging/gasket/gasket_sysfs.h +1
-1@@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {#define GASKET_SYSFS_RO (_name, _show_function, _attr_type) \ { \ - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \ + .attr = __ATTR(_name, 0444, _show_function, NULL), \
Why not use __ATTR_RO() instead?
thanks,
greg k-h
checkpatch.pl did not show any warning about this. Can I add the permission head to __ATTR_RO() ?
Greg KH <[email protected]>, 1 Nis 2020 Çar, 08:56 tarihinde şunu yazdı:
Quoted 31 lines · Gokce Kuler
Review
Quoted 9 lines
Since octal permissions is preffered to symbolic permissions, octal permissions is used.Problem found checkpatch.pl.
Signed-off-by Gokce Kuler <[email protected]>--- drivers/staging/gasket/gasket_sysfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/staging/gasket/gasket_sysfs.hdrivers/staging/gasket/gasket_sysfs.h struct gasket_sysfs_attribute { · line 76
Quoted 6 lines
index 1d0eed6..28dc422 100644
drivers/staging/gasket/gasket_sysfs.h +0
-0@@ -75,7 +75,7 @@ struct gasket_sysfs_attribute {#define GASKET_SYSFS_RO (_name, _show_function, _attr_type)\drivers/staging/gasket/gasket_sysfs.h struct gasket_sysfs_attribute { · line 77
Quoted 1 line
drivers/staging/gasket/gasket_sysfs.h +0
-0{\drivers/staging/gasket/gasket_sysfs.h struct gasket_sysfs_attribute { · line 78
Quoted 1 line
drivers/staging/gasket/gasket_sysfs.h +0
-1- .attr = __ATTR(_name, S_IRUGO, _show_function, NULL),\drivers/staging/gasket/gasket_sysfs.h struct gasket_sysfs_attribute { · line 78
Quoted 1 line
drivers/staging/gasket/gasket_sysfs.h +1
-0+ .attr = __ATTR(_name, 0444, _show_function, NULL),\
Why not use
__ATTR_RO()instead?thanks,
greg k-h
Quoted 1 line · Gokce Kuler
checkpatch.pl did not show any warning about this. Can I add the permission head to
__ATTR_RO()?
What do you mean by permission head?
julia
Quoted 35 lines
Greg KH <[email protected]>, 1 Nis 2020 Çar, 08:56 tarihinde şunu yazdı:
On Wed, Apr 01, 2020 at 02:09:40AM +0300, Gokce Kuler wrote: > Since octal permissions is preffered to symbolic permissions, > octal permissions is used.Problem found checkpatch.pl. > > Signed-off-by: Gokce Kuler <[email protected]> > --- > drivers/staging/gasket/gasket_sysfs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/gasket/gasket_sysfs.h b/drivers/staging/gasket/gasket_sysfs.h > index 1d0eed6..28dc422 100644 > --- a/drivers/staging/gasket/gasket_sysfs.h > +++ b/drivers/staging/gasket/gasket_sysfs.h > @@ -75,7 +75,7 @@ struct gasket_sysfs_attribute { > > #define GASKET_SYSFS_RO(_name, _show_function, _attr_type) \ > { \ > - .attr = __ATTR(_name, S_IRUGO, _show_function, NULL), \ > + .attr = __ATTR(_name, 0444, _show_function, NULL), \ Why not use __ATTR_RO() instead? thanks, greg k-h--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/CAL9LiB%2BPSd68yRfkrbr9yHkShzuPceJHosvswETO1-w1zgkqFw%40mail.gmail.com.
Can I edit like #define GASKET_SYSFS_RO(_name,_permission_, _show_function,_attr_type) ?
Julia Lawall <[email protected]>, 2 Nis 2020 Per, 15:43 tarihinde şunu yazdı:
Quoted 54 lines · Gokce Kuler
Quoted 2 lines
checkpatch.pl did not show any warning about this. Can I add the
permission head to
__ATTR_RO()?What do you mean by permission head?
julia
Quoted 2 lines
Greg KH <[email protected]>, 1 Nis 2020 Çar, 08:56 tarihinde
şunu yazdı:
Quoted 10 lines · Gokce Kuler
> Since octal permissions is preffered to symbolic permissions, > octal permissions is used.Problem found checkpatch.pl. >
> Signed-off-by: Gokce Kuler <[email protected]> > ---
>drivers/staging/gasket/gasket_sysfs.h| 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --gita/drivers/staging/gasket/gasket_sysfs.h
b/drivers/staging/gasket/gasket_sysfs.hQuoted 6 lines
> index 1d0eed6..28dc422 100644
> ---a/drivers/staging/gasket/gasket_sysfs.h
> +++b/drivers/staging/gasket/gasket_sysfs.h
> @@ -75,7 +75,7 @@ structgasket_sysfs_attribute{ >
> #defineGASKET_SYSFS_RO(_name, _show_function, _attr_type)\Quoted 1 line
> {\Quoted 1 line
> - .attr = __ATTR(_name,
S_IRUGO,_show_function,NULL), \
Quoted 1 line
> + .attr = __ATTR(_name, 0444, _show_function,NULL), \
Quoted 9 lines
Why not use
__ATTR_RO()instead?thanks,
greg k-h
--
You received this message because you are subscribed to the GoogleGroups "outreachy-kernel" group.
Quoted 1 line
To unsubscribe from this group and stop receiving emails from it, send
an email to [email protected].
Quoted 2 lines
To view this discussion on the web visit
Quoted 2 lines
Greg KH
maintainerQuoted 2 lines · Gokce Kuler
Can I edit like #define GASKET_SYSFS_RO(_name,_permission_,
_show_function,_attr_type) ?
As you seem to have lost the context of the email here, I'm sorry, but I have no idea what you are referring to.
Remember:
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
thanks,
greg k-h
Quoted 1 line · Gokce Kuler
Can I edit like #define
GASKET_SYSFS_RO(_name,_permission_, _show_function, _attr_type)?
Look at how others have used __ATTR_RO. What you propose does not look right.
julia
Quoted 50 lines
Julia Lawall <[email protected]>, 2 Nis 2020 Per, 15:43 tarihinde şunu yazdı:
On Thu, 2 Apr 2020, Gokce Kuler wrote:> checkpatch.pl did not show any warning about this. Can I add the permission head to
__ATTR_RO()?What do you mean by permission head?
julia
>
> Greg KH <[email protected]>, 1 Nis 2020 Çar, 08:56 tarihinde şunu yazdı:
> On Wed, Apr 01, 2020 at 02:09:40AM +0300, Gokce Kuler wrote:
> > Since octal permissions is preffered to symbolic permissions,
> > octal permissions is used.Problem found checkpatch.pl.
> >
> > Signed-off-by: Gokce Kuler <[email protected]>
> > ---
> >drivers/staging/gasket/gasket_sysfs.h| 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --gita/drivers/staging/gasket/gasket_sysfs.hb/drivers/staging/gasket/gasket_sysfs.h> > index 1d0eed6..28dc422 100644
> > ---a/drivers/staging/gasket/gasket_sysfs.h
> > +++b/drivers/staging/gasket/gasket_sysfs.h
> > @@ -75,7 +75,7 @@ structgasket_sysfs_attribute{
> >
> > #defineGASKET_SYSFS_RO(_name, _show_function, _attr_type)\
> > { \
> > - .attr =__ATTR(_name, S_IRUGO, _show_function, NULL), \
> > + .attr =__ATTR(_name, 0444, _show_function, NULL), \
>
> Why not use__ATTR_RO()instead?
>
> thanks,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To view this discussion on the web visit
>
https://groups.google.com/d/msgid/outreachy-kernel/CAL9LiB%2BPSd68yRfkrbr9yHkShzuPceJHosvswETO1-w1zgkqFw%40mail.gmail.com.
>
>