Skip to contentSkip to conversation

elx: efct: fix zalloc-simple.cocci warnings

PATCH New Julia Lawall 1 participant 1 message Apr 12, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 elx: efct: fix zalloc-simple.cocci warnings

From: kbuild test robot <[email protected]>

Use zeroing allocator rather than allocator followed by memset with 0

Generated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci

---

There are four patches in all from 0-day, all with the same subject. Maybe you can just squash them.

thanks,
julia

url:    https://github.com/0day-ci/linux/commits/James-Smart/efct-Broadcom-Emulex-FC-Target-driver/20200412-114125
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next

:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago

 efct_hw_queues.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/scsi/elx/efct/efct_hw_queues.c +2 -4
@@ -170,11 +170,10 @@ efct_hw_new_cq_set(struct hw_eq *eqs[],
 		cqs[i] = NULL;
 
 	for (i = 0; i < num_cqs; i++) {
-		cq = kmalloc(sizeof(*cq), GFP_KERNEL);
+		cq = kzalloc(sizeof(*cq), GFP_KERNEL);
 		if (!cq)
 			goto error;
 
-		memset(cq, 0, sizeof(*cq));
 		cqs[i]          = cq;
 		cq->eq          = eqs[i];
 		cq->type        = SLI_QTYPE_CQ;
@@ -373,11 +372,10 @@ efct_hw_new_rq_set(struct hw_cq *cqs[],
 		rqs[i] = NULL;
 
 	for (i = 0, q_count = 0; i < num_rq_pairs; i++, q_count += 2) {
-		rq = kmalloc(sizeof(*rq), GFP_KERNEL);
+		rq = kzalloc(sizeof(*rq), GFP_KERNEL);
 		if (!rq)
 			goto error;
 
-		memset(rq, 0, sizeof(*rq));
 		rqs[i] = rq;
 		rq->instance = hw->hw_rq_count++;
 		rq->cq = cqs[i];