Skip to contentSkip to conversation

MAINTAINERS: Wrong ordering in S390 PCI SUBSYSTEM

DISCUSSION Lukas Bulwahn 3 participants 5 messages May 6, 2020 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hi Pierre,

with your commit de267a7c71ba ("s390/pci: Documentation for zPCI"), visible on next-20200505, ./scripts/checkpatch.pl -f MAINTAINERS complains:

WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order #14723: FILE: MAINTAINERS:14723:
+F: drivers/pci/hotplug/s390_pci_hpc.c
+F: Documentation/s390/pci.rst

This is due to wrong ordering of the entries in your submission. If you would like me to send you a patch fixing that, please just let me know.

It is a recent addition to checkpatch.pl to report ordering problems in MAINTAINERS, so you might have not seen that at submission time.

Best regards,

Lukas

#1 lore raw
Quoted 13 lines · Lukas Bulwahn

Hi Pierre,

with your commit de267a7c71ba ("s390/pci: Documentation for zPCI"), visible on next-20200505, ./scripts/checkpatch.pl -f MAINTAINERS complains:

WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order #14723: FILE: MAINTAINERS:14723:

(quoted diff) +2 -0
+F:     drivers/pci/hotplug/s390_pci_hpc.c
+F:     Documentation/s390/pci.rst
Quoted 5 lines

This is due to wrong ordering of the entries in your submission. If you would like me to send you a patch fixing that, please just let me know.

It is a recent addition to checkpatch.pl to report ordering problems in MAINTAINERS, so you might have not seen that at submission time.

Why not to send a patch?
Same for the rest of similar mails from you.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 13 lines · Andy Shevchenko
Quoted 12 lines · Lukas Bulwahn

Hi Pierre,

with your commit de267a7c71ba ("s390/pci: Documentation for zPCI"), visible on next-20200505, ./scripts/checkpatch.pl -f MAINTAINERS complains:

WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order #14723: FILE: MAINTAINERS:14723:

(quoted diff) +2 -0
+F:     drivers/pci/hotplug/s390_pci_hpc.c
+F:     Documentation/s390/pci.rst
Quoted 8 lines
Quoted 5 lines

This is due to wrong ordering of the entries in your submission. If you would like me to send you a patch fixing that, please just let me know.

It is a recent addition to checkpatch.pl to report ordering problems in MAINTAINERS, so you might have not seen that at submission time.

Why not to send a patch?
Same for the rest of similar mails from you.

Frequently an original patch, which has yet to hit Linus' tree, can be updated before being upstreamed to avoid unnecessary additional patches.

It's also good form so the author of the original patch can be aware of possible defects in submission.

#3 lore raw
In reply to Andy Shevchenko
Quoted 14 lines · Andy Shevchenko
Quoted 13 lines · Lukas Bulwahn

Hi Pierre,

with your commit de267a7c71ba ("s390/pci: Documentation for zPCI"), visible on next-20200505, ./scripts/checkpatch.pl -f MAINTAINERS complains:

WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order #14723: FILE: MAINTAINERS:14723:

(quoted diff) +2 -0
+F:     drivers/pci/hotplug/s390_pci_hpc.c
+F:     Documentation/s390/pci.rst
Quoted 9 lines
Quoted 5 lines

This is due to wrong ordering of the entries in your submission. If you would like me to send you a patch fixing that, please just let me know.

It is a recent addition to checkpatch.pl to report ordering problems in MAINTAINERS, so you might have not seen that at submission time.

Why not to send a patch?
Same for the rest of similar mails from you.

Well, the checkpatch warning is new, so I want to find out if and make sure that the involved developers are generally okay getting those patches or if there is a better way handling those patches to MAINTAINERS.

I do not expect that there are too many further cases of this warning appearing soon in linux-next now that checkpatch already warns about it.

Lukas

#4 lore raw
Quoted 26 lines · Lukas Bulwahn
Quoted 13 lines · Andy Shevchenko
Quoted 12 lines · Lukas Bulwahn

Hi Pierre,

with your commit de267a7c71ba ("s390/pci: Documentation for zPCI"), visible on next-20200505, ./scripts/checkpatch.pl -f MAINTAINERS complains:

WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order #14723: FILE: MAINTAINERS:14723:

(quoted diff) +2 -0
+F:     drivers/pci/hotplug/s390_pci_hpc.c
+F:     Documentation/s390/pci.rst
Quoted 9 lines
Quoted 5 lines

This is due to wrong ordering of the entries in your submission. If you would like me to send you a patch fixing that, please just let me know.

It is a recent addition to checkpatch.pl to report ordering problems in MAINTAINERS, so you might have not seen that at submission time.

Why not to send a patch?
Same for the rest of similar mails from you.

Quoted 6 lines

Well, the checkpatch warning is new, so I want to find out if and make sure that the involved developers are generally okay getting those patches or if there is a better way handling those patches to MAINTAINERS.

I do not expect that there are too many further cases of this warning appearing soon in linux-next now that checkpatch already warns about it.

Hey Lukas.

Don't expect _too_ much as checkpatch has for a long time has done add/delete/move tests for files and emitted a "Does MAINTAINERS need updating" message that most have ignored or not seen as many patches are submitted without running checkpatch.