Skip to contentSkip to conversation

Evaluate and Improve checkpatch: tasks

Linux-kernel-mentees Ujjwal Kumar 2 participants 8 messages Sep 12, 2020 – Sep 16, 2020

lore
Share & tools
lore
#2 lore raw
Quoted 6 lines · Lukas Bulwahn
Quoted 2 lines · Ujjwal Kumar

Hello Lukas,

Quoted 7 lines
Quoted 5 lines

I attempted the tasks.

Below is the link of GitHub repository containing my write-up and findings.
https://github.com/Ujjwal0501/lkmp-checkpatch

Thanks, it shows 404. Good luck next time.

I'm really sorry for the noise. The link is active now.

Quoted 3 lines

Lukas

Ujjwal Kumar
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

#3 lore raw
Quoted 9 lines · Ujjwal Kumar
Quoted 8 lines · Lukas Bulwahn
Quoted 4 lines · Ujjwal Kumar

Hello Lukas,

I attempted the tasks.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Below is the link of GitHub repository containing my write-up and findings.
https://github.com/Ujjwal0501/lkmp-checkpatch

Thanks, it shows 404. Good luck next time.

I'm really sorry for the noise. The link is active now.

Okay, scripts and data looks sound. So, let us try those scripts.

Please have a look at this patch:

https://lore.kernel.org/linux-kernel-mentees/[email protected]/

The author states:

This issue was discovered through a thorough analysis of checkpatch.pl errors and warnings of type GIT_COMMIT_ID on commits between v5.7 and v5.8.

Before applying this patch, checkpatch.pl reported 342 errors of type GIT_COMMIT_ID. After applying patch, errors reduced to 284.

If your scripts work, you should be able to confirm the statement.

The tasks are:

1. Run your scripts and create a full statistics of all error types with their according count for v5.7..v5.8.

2. Apply the patch with git am.

3. Run your scripts again and create a new statistics.

4. Compare before and after

5. Make all results available on your github repository.

---

Ujjwal, I can see that your evaluation shows

272 ERROR:GIT_COMMIT_ID

different from what the author reports. Maybe you apply the patch and check the difference for your evaluation first.

Afterwards, you might want to reach out to the author, cc this mailing list and check the difference of the configurations for the evaluation.

Then you can confirm the other evaluation as well.

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

#4 lore raw
Quoted 31 lines · Lukas Bulwahn
Quoted 9 lines · Ujjwal Kumar
Quoted 8 lines · Lukas Bulwahn
Quoted 4 lines · Ujjwal Kumar

Hello Lukas,

I attempted the tasks.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Below is the link of GitHub repository containing my write-up and findings.
https://github.com/Ujjwal0501/lkmp-checkpatch

Thanks, it shows 404. Good luck next time.

I'm really sorry for the noise. The link is active now.

Okay, scripts and data looks sound. So, let us try those scripts.

Please have a look at this patch:

https://lore.kernel.org/linux-kernel-mentees/[email protected]/

The author states:

This issue was discovered through a thorough analysis of checkpatch.pl errors and warnings of type GIT_COMMIT_ID on commits between v5.7 and v5.8.

Quoted 6 lines

Before applying this patch, checkpatch.pl reported 342 errors of type GIT_COMMIT_ID. After applying patch, errors reduced to 284.

If your scripts work, you should be able to confirm the statement.

I'm unable to reproduce the same count as above because the script is run on different sets of commits.

Quoted 5 lines

The tasks are:

1. Run your scripts and create a full statistics of all error types with their according count for v5.7..v5.8.

Quoted 8 lines

2. Apply the patch with git am.

3. Run your scripts again and create a new statistics.

4. Compare before and after

5. Make all results available on your github repository.

The results are available at the link
https://github.com/Ujjwal0501/lkmp-checkpatch/blob/master/tasks.md

Kindly take a look at it.

Quoted 4 lines

---

Ujjwal, I can see that your evaluation shows

Quoted 8 lines

272 ERROR:GIT_COMMIT_ID

different from what the author reports. Maybe you apply the patch and check the difference for your evaluation first.

Afterwards, you might want to reach out to the author, cc this mailing list and check the difference of the configurations for the evaluation.

I haven't contacted the author yet. But I have included an explanation for this in my GitHub repository.

Quoted 4 lines

Then you can confirm the other evaluation as well.

Lukas

Ujjwal Kumar
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

#5 lore raw
Quoted 36 lines · Ujjwal Kumar
Quoted 35 lines · Lukas Bulwahn
Quoted 9 lines · Ujjwal Kumar
Quoted 8 lines · Lukas Bulwahn
Quoted 4 lines · Ujjwal Kumar

Hello Lukas,

I attempted the tasks.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Below is the link of GitHub repository containing my write-up and findings.
https://github.com/Ujjwal0501/lkmp-checkpatch

Thanks, it shows 404. Good luck next time.

I'm really sorry for the noise. The link is active now.

Okay, scripts and data looks sound. So, let us try those scripts.

Please have a look at this patch:

https://lore.kernel.org/linux-kernel-mentees/[email protected]/

The author states:

This issue was discovered through a thorough analysis of checkpatch.pl errors and warnings of type GIT_COMMIT_ID on commits between v5.7 and v5.8.

Before applying this patch, checkpatch.pl reported 342 errors of type GIT_COMMIT_ID. After applying patch, errors reduced to 284.

Quoted 6 lines
Quoted 2 lines

If your scripts work, you should be able to confirm the statement.

I'm unable to reproduce the same count as above because the script is run on different sets of commits.

So, you say the evaluation from Ayush was not really a good evaluation of v5.7..v.5.8 due to some misconception of Ayush how to obtain the set of proper commits from v5.7..v5.8?

Quoted 12 lines
Quoted 12 lines

The tasks are:

1. Run your scripts and create a full statistics of all error types with their according count for v5.7..v5.8.

2. Apply the patch with git am.

3. Run your scripts again and create a new statistics.

4. Compare before and after

Quoted 8 lines
Quoted 2 lines

5. Make all results available on your github repository.

The results are available at the link
https://github.com/Ujjwal0501/lkmp-checkpatch/blob/master/tasks.md

Kindly take a look at it.

Can you share the errors that have changed after the patch was applied?

- Which cases of GIT_COMMIT_ID have disappeared?
- Which cases of GIT_COMMIT_ID are new?
- Which cases of GIT_COMMIT_ID have changed?
- Have cases of other type of errors/warnings/checks/notes disappeared, been added or changed?

You state GIT_COMMIT_ID changed from 272 to 230, but the tester in

https://lore.kernel.org/linux-kernel-mentees/CABJPP5BFNjBhdcvBWqDYnR-o2sZ0oY77bYr9PxducXW4Y=482Q@mail.gmail.com/

claimed that it changed from 270 to 251.

Which numbers are right? Why is there a difference in both statistics?

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

#6 lore raw
Quoted 43 lines · Lukas Bulwahn
Quoted 39 lines · Ujjwal Kumar
Quoted 37 lines · Lukas Bulwahn
Quoted 9 lines · Ujjwal Kumar
Quoted 8 lines · Lukas Bulwahn
Quoted 4 lines · Ujjwal Kumar

Hello Lukas,

I attempted the tasks.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Below is the link of GitHub repository containing my write-up and findings.
https://github.com/Ujjwal0501/lkmp-checkpatch

Thanks, it shows 404. Good luck next time.

I'm really sorry for the noise. The link is active now.

Okay, scripts and data looks sound. So, let us try those scripts.

Please have a look at this patch:

https://lore.kernel.org/linux-kernel-mentees/[email protected]/

The author states:

This issue was discovered through a thorough analysis of checkpatch.pl errors and warnings of type GIT_COMMIT_ID on commits between v5.7 and v5.8.

Before applying this patch, checkpatch.pl reported 342 errors of type GIT_COMMIT_ID. After applying patch, errors reduced to 284.

If your scripts work, you should be able to confirm the statement.

Quoted 7 lines
Quoted 3 lines

I'm unable to reproduce the same count as above because the script is run on different sets of commits.

So, you say the evaluation from Ayush was not really a good evaluation of v5.7..v.5.8 due to some misconception of Ayush how to obtain the set of proper commits from v5.7..v5.8?

That is not totally correct as he correctly generated the list of commits in the first task. But the script used to generate the statistics used a different way so I was trying to point that specific thing.

Quoted 29 lines
Quoted 12 lines
Quoted 12 lines

The tasks are:

1. Run your scripts and create a full statistics of all error types with their according count for v5.7..v5.8.

2. Apply the patch with git am.

3. Run your scripts again and create a new statistics.

4. Compare before and after

Quoted 8 lines
Quoted 2 lines

5. Make all results available on your github repository.

The results are available at the link
https://github.com/Ujjwal0501/lkmp-checkpatch/blob/master/tasks.md

Kindly take a look at it.

Can you share the errors that have changed after the patch was applied?

- Which cases of GIT_COMMIT_ID have disappeared?
- Which cases of GIT_COMMIT_ID are new?
- Which cases of GIT_COMMIT_ID have changed?
- Have cases of other type of errors/warnings/checks/notes disappeared, been added or changed?

Quoted 7 lines

You state GIT_COMMIT_ID changed from 272 to 230, but the tester in

https://lore.kernel.org/linux-kernel-mentees/CABJPP5BFNjBhdcvBWqDYnR-o2sZ0oY77bYr9PxducXW4Y=482Q@mail.gmail.com/

claimed that it changed from 270 to 251.

Which numbers are right? Why is there a difference in both statistics?

The patch from Ayush appears to have a bug which I have detailed in my write up.

Kindly take a look at the link.
https://github.com/Ujjwal0501/lkmp-checkpatch/blob/master/followuptask1.md

Quoted 3 lines

Lukas

Thanks,
Ujjwal Kumar
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

#7 lore raw

[Linux-kernel-mentees] RRRe: Evaluate and Improve checkpatch: tasks

Quoted 89 lines · Ujjwal Kumar
Quoted 43 lines · Lukas Bulwahn
Quoted 39 lines · Ujjwal Kumar
Quoted 37 lines · Lukas Bulwahn
Quoted 9 lines · Ujjwal Kumar
Quoted 8 lines · Lukas Bulwahn
Quoted 4 lines · Ujjwal Kumar

Hello Lukas,

I attempted the tasks.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

Below is the link of GitHub repository containing my write-up and findings.
https://github.com/Ujjwal0501/lkmp-checkpatch

Thanks, it shows 404. Good luck next time.

I'm really sorry for the noise. The link is active now.

Okay, scripts and data looks sound. So, let us try those scripts.

Please have a look at this patch:

https://lore.kernel.org/linux-kernel-mentees/[email protected]/

The author states:

This issue was discovered through a thorough analysis of checkpatch.pl errors and warnings of type GIT_COMMIT_ID on commits between v5.7 and v5.8.

Before applying this patch, checkpatch.pl reported 342 errors of type GIT_COMMIT_ID. After applying patch, errors reduced to 284.

If your scripts work, you should be able to confirm the statement.

Quoted 7 lines
Quoted 3 lines

I'm unable to reproduce the same count as above because the script is run on different sets of commits.

So, you say the evaluation from Ayush was not really a good evaluation of v5.7..v.5.8 due to some misconception of Ayush how to obtain the set of proper commits from v5.7..v5.8?

That is not totally correct as he correctly generated the list of commits in the first task. But the script used to generate the statistics used a different way so I was trying to point that specific thing.

Quoted 33 lines
Quoted 12 lines
Quoted 12 lines

The tasks are:

1. Run your scripts and create a full statistics of all error types with their according count for v5.7..v5.8.

2. Apply the patch with git am.

3. Run your scripts again and create a new statistics.

4. Compare before and after

Quoted 8 lines
Quoted 2 lines

5. Make all results available on your github repository.

The results are available at the link
https://github.com/Ujjwal0501/lkmp-checkpatch/blob/master/tasks.md

Kindly take a look at it.

Can you share the errors that have changed after the patch was applied?

- Which cases of GIT_COMMIT_ID have disappeared?
- Which cases of GIT_COMMIT_ID are new?
- Which cases of GIT_COMMIT_ID have changed?
- Have cases of other type of errors/warnings/checks/notes disappeared, been added or changed?

You state GIT_COMMIT_ID changed from 272 to 230, but the tester in

https://lore.kernel.org/linux-kernel-mentees/CABJPP5BFNjBhdcvBWqDYnR-o2sZ0oY77bYr9PxducXW4Y=482Q@mail.gmail.com/

Quoted 9 lines
Quoted 3 lines

claimed that it changed from 270 to 251.

Which numbers are right? Why is there a difference in both statistics?

The patch from Ayush appears to have a bug which I have detailed in my write up.

Kindly take a look at the link.
https://github.com/Ujjwal0501/lkmp-checkpatch/blob/master/followuptask1.md

Ayush, please fix the bug.

Ujjwal, please do not create screenshots. That is wasteful and harmful to the environment.

You can share the same information by sharing plain text in nicely formated ways.

Ujjwal, I do not understand the diff you presented. We are really not acquainted with your stat file, maybe you can explain what you read out of that.

Which results are from which exact commit?

Ujjwal, can you judge if the findings that disappeared should have not been warned about in the first place?

And the ones that appear new? Should they be really warned about or not?

Are there further patterns in the GIT_COMMIT_ID findings that probably should not be warned about and could be improved?

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees