Skip to contentSkip to conversation

checkpatch: improve handling of email comments

PATCH In review Dwaipayan Ray 3 participants 8 messages Oct 30, 2020 – Oct 31, 2020 Checkpatch

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 checkpatch: improve handling of email comments

checkpatch has limited support for parsing email comments. It only support single name comments or single after address comments. Whereas, RFC 5322 specifies that comments can be inserted in between any tokens of the email fields.

Improve comment parsing mechanism in checkpatch.

What is handled now:

- Multiple name/address comments
- Comments anywhere in between name/address
- Nested comments like (John (Doe))

A brief analysis of checkpatch output on v5.0..v5.7 showed that after these modifications, the number of BAD_SIGN_OFF warnings came down from 2944 to 1424, and FROM_SIGN_OFF_MISMATCH came down from 2366 to 2330.

So, a total of 1556 false positives were resolved in total.

---
 scripts/checkpatch.pl | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)
scripts/checkpatch.pl +14 -5
index fab38b493cef..ae8436385fc1 100755
@@ -1183,14 +1183,20 @@ sub parse_email {
 		}
 	}
 
-	$comment = trim($comment);
+	# Comments in between name like John(A nice chap) Doe
+	while ($name =~ s/\s*($balanced_parens)\s*/ /) {
+		$name_comment .= trim($1);
+	}
 	$name = trim($name);
 	$name =~ s/^\"|\"$//g;
-	if ($name =~ s/(\s*\([^\)]+\))\s*//) {
-		$name_comment = trim($1);
+
+	# Comments in between address like <john(his account)@doe.com>
+	while ($address =~ s/\s*($balanced_parens)\s*//) {
+		$comment .= trim($1);
 	}
 	$address = trim($address);
 	$address =~ s/^\<|\>$//g;
+	$comment = trim($comment);
 
 	if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
 		$name =~ s/(?<!\\)"/\\"/g; ##escape quotes
@@ -1205,8 +1211,6 @@ sub format_email {
 
 	my $formatted_email;
 
-	$name_comment = trim($name_comment);
-	$comment = trim($comment);
 	$name = trim($name);
 	$name =~ s/^\"|\"$//g;
 	$address = trim($address);
@@ -1216,6 +1220,11 @@ sub format_email {
 		$name = "\"$name\"";
 	}
 
+	$name_comment = trim($name_comment);
+	$name_comment =~ s/(.+)/ $1/;
+	$comment = trim($comment);
+	$comment =~ s/(.+)/ $1/;
+
 	if ("$name" eq "") {
 		$formatted_email = "$address";
 	} else {
Signature · 1 line
2.27.0
maintainer
#1 lore raw
Quoted 13 lines · Dwaipayan Ray

checkpatch has limited support for parsing email comments. It only support single name comments or single after address comments. Whereas, RFC 5322 specifies that comments can be inserted in between any tokens of the email fields.

Improve comment parsing mechanism in checkpatch.

What is handled now:

- Multiple name/address comments
- Comments anywhere in between name/address
- Nested comments like (John (Doe))

Quoted 6 lines

A brief analysis of checkpatch output on v5.0..v5.7 showed that after these modifications, the number of BAD_SIGN_OFF warnings came down from 2944 to 1424, and FROM_SIGN_OFF_MISMATCH came down from 2366 to 2330.

So, a total of 1556 false positives were resolved in total.

A mere reduction in messages emitted isn't necessarily good.

Please send me privately a complete list of these nominally false positive messages that are no longer emitted.

I believe one of the relatively common incorrect messages is for the cc: <[email protected]> where a version number is continued on the same line after a #.

CC [email protected] # for versions x.y.z and above
#2 lore raw
Quoted 14 lines · Joe Perches
Quoted 13 lines · Dwaipayan Ray

checkpatch has limited support for parsing email comments. It only support single name comments or single after address comments. Whereas, RFC 5322 specifies that comments can be inserted in between any tokens of the email fields.

Improve comment parsing mechanism in checkpatch.

What is handled now:

- Multiple name/address comments
- Comments anywhere in between name/address
- Nested comments like (John (Doe))

Quoted 9 lines
Quoted 6 lines

A brief analysis of checkpatch output on v5.0..v5.7 showed that after these modifications, the number of BAD_SIGN_OFF warnings came down from 2944 to 1424, and FROM_SIGN_OFF_MISMATCH came down from 2366 to 2330.

So, a total of 1556 false positives were resolved in total.

A mere reduction in messages emitted isn't necessarily good.

Agree. That is why I also went through the list of those warnings.

I could not spot any obvious true positive among the reduced ones.

Quoted 9 lines

Please send me privately a complete list of these nominally false positive messages that are no longer emitted.

I believe one of the relatively common incorrect messages is for the cc: <[email protected]> where a version number is continued on the same line after a #.

CC [email protected] # for versions x.y.z and above

That was one, another common pattern was just quotes put inconsistently at different places.

Lukas

maintainer
#3 lore raw
Quoted 20 lines · Lukas Bulwahn
Quoted 19 lines · Joe Perches
Quoted 18 lines · Dwaipayan Ray

checkpatch has limited support for parsing email comments. It only support single name comments or single after address comments. Whereas, RFC 5322 specifies that comments can be inserted in between any tokens of the email fields.

Improve comment parsing mechanism in checkpatch.

What is handled now:

- Multiple name/address comments
- Comments anywhere in between name/address
- Nested comments like (John (Doe))

A brief analysis of checkpatch output on v5.0..v5.7 showed that after these modifications, the number of BAD_SIGN_OFF warnings came down from 2944 to 1424, and FROM_SIGN_OFF_MISMATCH came down from 2366 to 2330.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

So, a total of 1556 false positives were resolved in total.

A mere reduction in messages emitted isn't necessarily good.

Agree. That is why I also went through the list of those warnings.

So sending me a copy of that list shouldn't be a burden.

Quoted 7 lines
Quoted 7 lines

Please send me privately a complete list of these nominally false positive messages that are no longer emitted.

I believe one of the relatively common incorrect messages is for the cc: <[email protected]> where a version number is continued on the same line after a #.

Quoted 5 lines
Quoted 2 lines
CC [email protected] # for versions x.y.z and above

That was one, another common pattern was just quotes put inconsistently at different places.

Which to me is more an indication that a message _should_ be emitted as many email clients do not like to copy/paste incorrectly formatted email addresses (ie: Missing necessary quotes when the name contains characters like .) and that's a common way to cc a reply to a possible commit message of an email.

Perhaps as well the .mailmap mechanism may not cope with these differently formatted email addresses.

_______________________________________________
Linux-kernel-mentees mailing list [email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

maintainer
#4 lore raw
In reply to Lukas Bulwahn
Quoted 35 lines · Lukas Bulwahn
Quoted 14 lines · Joe Perches
Quoted 13 lines · Dwaipayan Ray

checkpatch has limited support for parsing email comments. It only support single name comments or single after address comments. Whereas, RFC 5322 specifies that comments can be inserted in between any tokens of the email fields.

Improve comment parsing mechanism in checkpatch.

What is handled now:

- Multiple name/address comments
- Comments anywhere in between name/address
- Nested comments like (John (Doe))

Quoted 9 lines
Quoted 6 lines

A brief analysis of checkpatch output on v5.0..v5.7 showed that after these modifications, the number of BAD_SIGN_OFF warnings came down from 2944 to 1424, and FROM_SIGN_OFF_MISMATCH came down from 2366 to 2330.

So, a total of 1556 false positives were resolved in total.

A mere reduction in messages emitted isn't necessarily good.

Agree. That is why I also went through the list of those warnings.

I could not spot any obvious true positive among the reduced ones.

Quoted 3 lines

Please send me privately a complete list of these nominally false positive messages that are no longer emitted.

Quoted 8 lines
Quoted 6 lines

I believe one of the relatively common incorrect messages is for the cc: <[email protected]> where a version number is continued on the same line after a #.

CC [email protected] # for versions x.y.z and above

That was one,

It's not just one, it's ~90% of the list that Dwaipayan sent me.

$ wc -l mismatches
831 mismatches
$ grep -v -i stable mismatches | wc -l
98
Quoted 2 lines

another common pattern was just quotes put inconsistently at different places.

Yes, there are some defects there.
But there are also now false negatives.

For instance, this is not appropriate to ignore:

WARNING:BAD_SIGN_OFF: email address '[email protected], [email protected], [email protected], [email protected]' might be better as '[email protected],[email protected], [email protected], [email protected]'

From the file that Dwaipayan sent me, all the rest not including the stable variants, which IMO should be handled separately, are below.

Of these 98 in total, 60+% are unicode which IMO should always be quoted and most are doubled with BAD_SIGN_OFF doubling FROM_SIGN_OFF_MISMATCH (and I don't quite understand why it's "From:/" then "Signed-off-by:"

$ grep -v -i stable dwai | sort | uniq -c | sort -rn
     31 WARNING:BAD_SIGN_OFF: email address '周琰杰 (Zhou Yanjie) <[email protected]>' might be better as '"周琰杰"(Zhou Yanjie) <[email protected]>'
     30 WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: "周琰杰"(Zhou Yanjie) <[email protected]>' != 'Signed-off-by: 周琰杰 (Zhou Yanjie) <[email protected]>'

These 29 in total would be better stripping any bits in parentheses from the name portion only when _not_ inside quotes.

     20 WARNING:BAD_SIGN_OFF: email address 'Thomas Hellström (VMware) <[email protected]>' might be better as '"Thomas Hellström"(VMware) <[email protected]>'
      5 WARNING:BAD_SIGN_OFF: email address 'H. Peter Anvin (Intel) <[email protected]>' might be better as '"H. Peter Anvin"(Intel) <[email protected]>'
      

      1 WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: "Thomas Hellström"(VMware) <[email protected]>' != 'Signed-off-by: Thomas Hellström (VMware) <[email protected]>'
      
      1 WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: "Srivatsa S. Bhat"(VMware) <[email protected]>' != 'Signed-off-by: Srivatsa S. Bhat (VMware) <[email protected]>'
      1 WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: JanNieuwenhuizen(janneke) <[email protected]>' != 'Signed-off-by: Jan Nieuwenhuizen <[email protected]>'  
      1 WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: "Frédéric Pierret"(fepitre) <[email protected]>' != 'Signed-off-by: Frédéric Pierret (fepitre) <[email protected]>'

So these 8 others are ones where quotes are either oddly placed or perhaps should always exist and the comment in parentheses is suggested poorly. 7 of these should be fixed and one should still be reported.

1 WARNING:BAD_SIGN_OFF: email address '"Thomas Hellström (VMware)" <[email protected]>' might be better as '"Thomas Hellström"(VMware) <[email protected]>'
1 WARNING:BAD_SIGN_OFF: email address 'Srivatsa S. Bhat (VMware) <[email protected]>' might be better as '"Srivatsa S. Bhat"(VMware) <[email protected]>'
1 WARNING:BAD_SIGN_OFF: email address '"Rantala, Tommi T. (Nokia - FI/Espoo)" <[email protected]>' might be better as '"Rantala, Tommi T."(Nokia - FI/Espoo) <[email protected]>'
1 WARNING:BAD_SIGN_OFF: email address '"Kai Mäkisara (Kolumbus)" <[email protected]>' might be better as '"Kai Mäkisara"(Kolumbus) <[email protected]>'
1 WARNING:BAD_SIGN_OFF: email address '[email protected], [email protected], [email protected], [email protected]' might be better as '[email protected],[email protected], [email protected], [email protected]' 1 WARNING:BAD_SIGN_OFF: email address 'Frédéric Pierret (fepitre) <[email protected]>' might be better as '"Frédéric Pierret"(fepitre) <[email protected]>'
1 WARNING:BAD_SIGN_OFF: email address '[email protected] (big endian system concerns)' might be better as '[email protected](big endian system concerns)'
1 WARNING:BAD_SIGN_OFF: email address '[email protected] (Avery Pennarun)' might be better as '[email protected](Avery Pennarun)'

#5 lore raw
Quoted 93 lines · Joe Perches
Quoted 35 lines · Lukas Bulwahn
Quoted 14 lines · Joe Perches
Quoted 13 lines · Dwaipayan Ray

checkpatch has limited support for parsing email comments. It only support single name comments or single after address comments. Whereas, RFC 5322 specifies that comments can be inserted in between any tokens of the email fields.

Improve comment parsing mechanism in checkpatch.

What is handled now:

- Multiple name/address comments
- Comments anywhere in between name/address
- Nested comments like (John (Doe))

Quoted 9 lines
Quoted 6 lines

A brief analysis of checkpatch output on v5.0..v5.7 showed that after these modifications, the number of BAD_SIGN_OFF warnings came down from 2944 to 1424, and FROM_SIGN_OFF_MISMATCH came down from 2366 to 2330.

So, a total of 1556 false positives were resolved in total.

A mere reduction in messages emitted isn't necessarily good.

Agree. That is why I also went through the list of those warnings.

I could not spot any obvious true positive among the reduced ones.

Quoted 3 lines

Please send me privately a complete list of these nominally false positive messages that are no longer emitted.

Quoted 8 lines
Quoted 6 lines

I believe one of the relatively common incorrect messages is for the cc: <[email protected]> where a version number is continued on the same line after a #.

CC [email protected] # for versions x.y.z and above

That was one,

It's not just one, it's ~90% of the list that Dwaipayan sent me.

$ wc -l mismatches
831 mismatches
$ grep -v -i stable mismatches | wc -l
98
Quoted 2 lines

another common pattern was just quotes put inconsistently at different places.

Yes, there are some defects there.
But there are also now false negatives.

For instance, this is not appropriate to ignore:

WARNING:BAD_SIGN_OFF: email address '[email protected], [email protected], [email protected], [email protected]' might be better as '[email protected],[email protected], [email protected], [email protected]'

From the file that Dwaipayan sent me, all the rest not including the stable variants, which IMO should be handled separately, are below.

Of these 98 in total, 60+% are unicode which IMO should always be quoted and most are doubled with BAD_SIGN_OFF doubling FROM_SIGN_OFF_MISMATCH (and I don't quite understand why it's "From:/" then "Signed-off-by:"

$ grep -v -i stable dwai | sort | uniq -c | sort -rn
     31 WARNING:BAD_SIGN_OFF: email address '周琰杰 (Zhou Yanjie) <[email protected]>' might be better as '"周琰杰"(Zhou Yanjie) <[email protected]>'
     30 WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: "周琰杰"(Zhou Yanjie) <[email protected]>' != 'Signed-off-by: 周琰杰 (Zhou Yanjie) <[email protected]>'

These 29 in total would be better stripping any bits in parentheses from the name portion only when _not_ inside quotes.

     20 WARNING:BAD_SIGN_OFF: email address 'Thomas Hellström (VMware) <[email protected]>' might be better as '"Thomas Hellström"(VMware) <[email protected]>'
      5 WARNING:BAD_SIGN_OFF: email address 'H. Peter Anvin (Intel) <[email protected]>' might be better as '"H. Peter Anvin"(Intel) <[email protected]>'


      1 WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: "Thomas Hellström"(VMware) <[email protected]>' != 'Signed-off-by: Thomas Hellström (VMware) <[email protected]>'

      1 WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: "Srivatsa S. Bhat"(VMware) <[email protected]>' != 'Signed-off-by: Srivatsa S. Bhat (VMware) <[email protected]>'
      1 WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: JanNieuwenhuizen(janneke) <[email protected]>' != 'Signed-off-by: Jan Nieuwenhuizen <[email protected]>'
      1 WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: "Frédéric Pierret"(fepitre) <[email protected]>' != 'Signed-off-by: Frédéric Pierret (fepitre) <[email protected]>'

So these 8 others are ones where quotes are either oddly placed or perhaps should always exist and the comment in parentheses is suggested poorly. 7 of these should be fixed and one should still be reported.

Quoted 10 lines

1 WARNING:BAD_SIGN_OFF: email address '"Thomas Hellström (VMware)" <[email protected]>' might be better as '"Thomas Hellström"(VMware) <[email protected]>'
1 WARNING:BAD_SIGN_OFF: email address 'Srivatsa S. Bhat (VMware) <[email protected]>' might be better as '"Srivatsa S. Bhat"(VMware) <[email protected]>'
1 WARNING:BAD_SIGN_OFF: email address '"Rantala, Tommi T. (Nokia - FI/Espoo)" <[email protected]>' might be better as '"Rantala, Tommi T."(Nokia - FI/Espoo) <[email protected]>'
1 WARNING:BAD_SIGN_OFF: email address '"Kai Mäkisara (Kolumbus)" <[email protected]>' might be better as '"Kai Mäkisara"(Kolumbus) <[email protected]>'
1 WARNING:BAD_SIGN_OFF: email address '[email protected], [email protected], [email protected], [email protected]' might be better as '[email protected],[email protected], [email protected], [email protected]' 1 WARNING:BAD_SIGN_OFF: email address 'Frédéric Pierret (fepitre) <[email protected]>' might be better as '"Frédéric Pierret"(fepitre) <[email protected]>'
1 WARNING:BAD_SIGN_OFF: email address '[email protected] (big endian system concerns)' might be better as '[email protected](big endian system concerns)'
1 WARNING:BAD_SIGN_OFF: email address '[email protected] (Avery Pennarun)' might be better as '[email protected](Avery Pennarun)'

Hi,
Thanks for the review.

So I get that the parentheses from within quotes should not be extracted. I will do that.

But for the names which should be quoted, I think the errors appeared because of a parsing bug. There is no separate mechanism to distinguish quoted and unquoted names currently.

Names which have must quote characters without any comments are not warned about right now:

D. Ray <[email protected]> doesn't throw any warning, while D. Ray (Dwai) <[email protected]> does.

Do you think this should be dealt separately from this patch? Perhaps as another warning?

Thanks,
Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

maintainer
#6 lore raw
Quoted 5 lines · Dwaipayan Ray

Names which have must quote characters without any comments are not warned about right now:

D. Ray <[email protected]> doesn't throw any warning, while D. Ray (Dwai) <[email protected]> does.

I agree that a comment in parentheses after the name and before the email address is an issue that should be resolved.

I think your proposed solution isn't great through.

Quoted 1 line

Do you think this should be dealt separately from this patch?

I think the cc: stable@(?:vger\.)?kernel.org with additional content on the same line should be separated from other email addresses with additional content on the same line.

Quoted 1 line

Perhaps as another warning?

Dunno.

Try this git log grep:

$ git log --format=email -100000 | \
  grep -P '^(?:[\w\-]+-by:|cc:|CC:|Cc:)' | \
  grep -v 'stable\@' | \
  grep -P '\>.+'

This finds any signature/cc line with content after an email address that end with a close angle bracket that doesn't go to the stable address.

Think about what content after that close angle bracket should and shoud not be allowed.

There are a few variants here:

o comments (optional whitespace, followed by '#' or '[' or '(' or c89)
o misuse of quote (around the whole name and address)
o Odd commas after '>' likely from defective cut'n'paste use

Then add this to the first grep to avoid the comments as above

$ git log --format=email -100000 | \
  grep -P '^(?:[\w\-]+-by:|cc:|CC:|Cc:)' | \
  grep -v 'stable\@' | \
  grep -P '\>.+' | \
  grep -vP '\>\s*(?:\#|\(|/\*|\[)'

Shouldn't all these be reported?
Are they if your patch is applied?

Then look at the addresses that do not have a close angle bracket and also have more content after the email address.

$ git log --format=email -100000 | \
  grep -P '^(?:[\w\-]+-by:|cc:|CC:|Cc:)' | \
  grep -v 'stable@' | \
  grep -vP '<[\w\.\@\+\-]+>' | \
  grep -vP '[\w\.\@\+\-]+$'

What of all of these should be reported?

Happy testing...

#7 lore raw
Quoted 41 lines

Try this git log grep:

$ git log --format=email -100000 | \
   grep -P '^(?:[\w\-]+-by:|cc:|CC:|Cc:)' | \
   grep -v 'stable\@' | \
   grep -P '\>.+'

This finds any signature/cc line with content after an email address that end with a close angle bracket that doesn't go to the stable address.

Think about what content after that close angle bracket should and shoud not be allowed.

There are a few variants here:

o comments (optional whitespace, followed by '#' or '[' or '(' or c89)
o misuse of quote (around the whole name and address)
o Odd commas after '>' likely from defective cut'n'paste use

Then add this to the first grep to avoid the comments as above

$ git log --format=email -100000 | \
   grep -P '^(?:[\w\-]+-by:|cc:|CC:|Cc:)' | \
   grep -v 'stable\@' | \
   grep -P '\>.+' | \
   grep -vP '\>\s*(?:\#|\(|/\*|\[)'

Shouldn't all these be reported?
Are they if your patch is applied?

Then look at the addresses that do not have a close angle bracket and also have more content after the email address.

$ git log --format=email -100000 | \
   grep -P '^(?:[\w\-]+-by:|cc:|CC:|Cc:)' | \
   grep -v 'stable@' | \
   grep -vP '<[\w\.\@\+\-]+>' | \
   grep -vP '[\w\.\@\+\-]+$'
Quoted 4 lines

What of all of these should be reported?

Happy testing...

Hi,
So I ran the tests and there are some interesting results.

The warnings were the same before and after this patch was applied.

For illegal elements after the closing braces, there were several errors for which no warnings were reported. These are:

      6 Cc: Peter Zijlstra <[email protected]>,
      5 Reviewed-by: "Dietmar Eggemann <[email protected]>"
      1 Suggested-by: Julia Lawall <[email protected]>.
      1 Signed-off-by: Vishal Kulkarni <[email protected]>"
      1 Signed-off-by: Vishal Kulkarni <[email protected]>"
      1 Signed-off-by: Vishal Kulkarni <[email protected]>"
      1 Signed-off-by: Veerabhadrarao Badiganti <[email protected]> Link:
      1 Signed-off-by: Jingle Wu <[email protected]>.
      1 Reviewed-by: Tvrtko Ursulin <[email protected]>,
      1 Reviewed-by: Max Gurtovoy <[email protected] <mailto:[email protected]>>
      1 Reviewed-by: Maulik Shah <[email protected]> Thanks, Maulik
      1 Reviewed-by: Marc Zyngier <[email protected]> Link: https://lore.kernel.org/r/[email protected]
      1 Reviewed-by: David Sterba <[email protected]>i
      1 Reviewed-by: David Sterba <[email protected]>c
      1 Reviewed-by: David Sterba <[email protected]>3
      1 Reviewed-by: Christoph Hellwig <[email protected]>,
      1 Reviewed-by: Christian König <[email protected]> for both.
      1 Reviewed-by: Christian König <[email protected]>.
      1 Reported-by: Randy Dunlap <[email protected]>>
      1 Reported-by: Qian Cai <[email protected]>>
      1 Reported-by: Qian Cai <[email protected]> writes:
      1 Reported-by: kernel test robot <[email protected]> for missing #include
      1 Reported-by: "kernelci.org bot" <[email protected]>"
      1 Reported-by: kbuild test robot <[email protected]>]
      1 Reported-by: Bob Sanders <[email protected]> and the LTP testsuite
      1 Cc: Wolfram Sang <[email protected]>,
      1 Cc: Valdis Kletnieks <[email protected]>,
      1 Cc: Tvrtko Ursulin <[email protected]>,
      1 CC: Stephen Rothwell <[email protected]>,
      1 Cc: Sia, Jee Heng <[email protected]>; [email protected]; [email protected]; [email protected]; Nathan Chancellor <[email protected]> 1 Cc: Robert Sesek <[email protected]>,
      1 CC: Peter Zijlstra <[email protected]>,
      1 Cc: Omar Sandoval <[email protected]>,
      1 Cc: Michael Neuling <[email protected]> <[email protected]>
      1 Cc: Maxime Ripard <[email protected]>,
      1 Cc: "Martin K. Petersen" <[email protected]>,
      1 Cc: Mark Scott <[email protected]>,
      1 Cc: Mark Rutland <[email protected]>.
      1 Cc: Mark Rutland <[email protected]>,
      1 Cc: Mark Rutland <[email protected]>,
      1 Cc: Laurent Pinchart <[email protected]>,
      1 Cc: Kees Cook <[email protected]>,
      1 Cc: Jonas Karlman <[email protected]>,
      1 Cc: Jernej Skrabec <[email protected]>,
      1 Cc: Jason Wang <[email protected]>; Parav Pandit <[email protected]>; [email protected]; [email protected]; [email protected] 1 Cc: Jann Horn <[email protected]>,
      1 Cc: James Bottomley <[email protected]>,
      1 Cc: Icenowy Zheng <[email protected]>,
      1 Cc: Dan Murphy <[email protected]>A
      1 Cc: Daniel Vetter <[email protected]>,
      1 Cc: Christoph Lameter <[email protected]>Cc: Pekka Enberg <[email protected]>
      1 Cc: Christoph Hellwig <[email protected]>,
      1 Cc: Christian König <[email protected]>.
      1 CC: "Chang S. Bae" <[email protected]>,
      1 Cc: Al Viro <[email protected]>e
      1 Acked-by: Thomas Bogendoerfer <[email protected]>A
      1 Acked-by: Geert Uytterhoeven <[email protected]>A

For cases with no closing '>', following cases were not reported by checkpatch:

      6 Cc: [email protected],
      1 Reviewed-by: Max Gurtovoy <[email protected] <mailto:[email protected]>> 1 Cc: [email protected],
      1 Cc: [email protected],
      1 Cc: [email protected],

So it's mostly extra commas at the end. But other illegal characters were also there. Also in one or two cases, multiple addresses were stacked together. I think these all deserve to be reported.

Thanks,
Dwaipayan.