coccinelle: api: fix kobj_to_dev.cocci warnings
PATCH 1/1 coccinelle: api: fix kobj_to_dev.cocci warnings
Use kobj_to_dev() instead of container_of()
Generated by: scripts/coccinelle/api/kobj_to_dev.cocci
CC Denis Efremov <[email protected]>
Signed-off-by kernel test robot <[email protected]>
Signed-off-by Julia Lawall <[email protected]>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git for-5.10 head: a2fc3718bc22e85378085568ecc5765fb28cabce commit: a2fc3718bc22e85378085568ecc5765fb28cabce [3/3] coccinelle: api: add kobj_to_dev.cocci script
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
lightnvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/lightnvm.c +1 -1
@@ -1241,7 +1241,7 @@ static struct attribute *nvm_dev_attrs[]static umode_t nvm_dev_attrs_visible (struct kobject *kobj,struct attribute *attr,int index) { - struct device *dev = container_of(kobj, struct device, kobj); +struct device *dev =kobj_to_dev (kobj);struct gendisk *disk =dev_to_disk (dev);struct nvme_ns *ns = disk->private_data;struct nvm_dev *ndev = ns->ndev;
Jens Axboe
maintainerQuoted 3 lines · Julia Lawall
Use
kobj_to_dev()instead ofcontainer_of()Generated by:
scripts/coccinelle/api/kobj_to_dev.cocci
Seem to see more of these, these days. I don't really like them, why not just use container_of? The private bla_to_foo() helpers should go away, they are actively hurting readability of the code imho.
Signature · 1 line
Jens Axboe