Skip to contentSkip to conversation

drm/i915: fix odd_ptr_err.cocci warnings

PATCH New Julia Lawall 1 participant 1 message Sep 27, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: fix odd_ptr_err.cocci warnings

From: kernel test robot <[email protected]>

PTR_ERR should access the value just tested by IS_ERR

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

Fixes 6b05030496f7 ("drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2.")
CC Maarten Lankhorst <[email protected]>

---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head:   20dc779fdefc40bf7dd9736cea01704f29228fae
commit: 6b05030496f773f35f24299b1bd49dc8aa10a580 [4922/11173] drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2.

:::::: branch date: 2 days ago
:::::: commit date: 3 weeks ago

 i915_gem_object_blt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c +1 -1
@@ -364,7 +364,7 @@ int i915_gem_object_copy_blt(struct drm_
 
 	vma[1] = i915_vma_instance(dst, vm, NULL);
 	if (IS_ERR(vma[1]))
-		return PTR_ERR(vma);
+		return PTR_ERR(vma[1]);
 
 	i915_gem_ww_ctx_init(&ww, true);
 	intel_engine_pm_get(ce->engine);