Skip to contentSkip to conversation

forcedeth: fix excluded_middle.cocci warnings

PATCH Applied Julia Lawall 2 participants 2 messages Nov 2, 2020 – Nov 4, 2020

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 forcedeth: fix excluded_middle.cocci warnings

From: kernel test robot <[email protected]>

Condition !A || A && B is equivalent to !A || B.

Generated by: scripts/coccinelle/misc/excluded_middle.cocci

Fixes b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script")
CC Denis Efremov <[email protected]>

---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   3cea11cd5e3b00d91caf0b4730194039b45c5891
commit: b76f0ea013125358d1b4ca147a6f9b6883dd2493 coccinelle: misc: add excluded_middle.cocci script

:::::: branch date: 7 hours ago
:::::: commit date: 6 weeks ago

 forcedeth.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/nvidia/forcedeth.c +1 -2
@@ -1043,8 +1043,7 @@ static int using_multi_irqs(struct net_d
 	struct fe_priv *np = get_nvpriv(dev);
 
 	if (!(np->msi_flags & NV_MSI_X_ENABLED) ||
-	    ((np->msi_flags & NV_MSI_X_ENABLED) &&
-	     ((np->msi_flags & NV_MSI_X_VECTORS_MASK) == 0x1)))
+	    ((np->msi_flags & NV_MSI_X_VECTORS_MASK) == 0x1))
 		return 0;
 	else
 		return 1;
maintainer Applied
#1 lore raw
Quoted 10 lines · On Mon, 2 Nov 2020 09:38:30 +0100 (CET) Julia Lawall wrote:

From: kernel test robot <[email protected]>

Condition !A || A && B is equivalent to !A || B.

Generated by: scripts/coccinelle/misc/excluded_middle.cocci

Fixes b76f0ea01312 ("coccinelle: misc: add excluded_middle.cocci script")
CC Denis Efremov <[email protected]>

Applied, thanks!