Skip to contentSkip to conversation

ACPI: NFIT: fix flexible_array.cocci warnings

PATCH In review Julia Lawall 2 participants 2 messages Dec 22, 2020 – Dec 24, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI: NFIT: fix flexible_array.cocci warnings

From: kernel test robot <[email protected]>

Zero-length and one-element arrays are deprecated, see Documentation/process/deprecated.rst Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Fixes 7b36c1398fb6 ("coccinelle: misc: add flexible_array.cocci script")
CC Denis Efremov <[email protected]>

---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   148842c98a24e508aecb929718818fbf4c2a6ff3
commit: 7b36c1398fb63f9c38cc83dc75f143d2e5995062 coccinelle: misc: add flexible_array.cocci script

:::::: branch date: 20 hours ago
:::::: commit date: 2 months ago

 core.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/acpi/nfit/core.c +2 -2
@@ -2268,7 +2268,7 @@ struct nfit_set_info {
 		u64 region_offset;
 		u32 serial_number;
 		u32 pad;
-	} mapping[0];
+	} mapping[];
 };
 
 struct nfit_set_info2 {
@@ -2279,7 +2279,7 @@ struct nfit_set_info2 {
 		u16 manufacturing_date;
 		u8  manufacturing_location;
 		u8  reserved[31];
-	} mapping[0];
+	} mapping[];
 };
 
 static size_t sizeof_nfit_set_info(int num_mappings)
#1 lore raw
Quoted 7 lines · Julia Lawall

From: kernel test robot <[email protected]>

Zero-length and one-element arrays are deprecated, see Documentation/process/deprecated.rst Flexible-array members should be used instead.

Quoted 7 lines

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Fixes 7b36c1398fb6 ("coccinelle: misc: add flexible_array.cocci script")
CC Denis Efremov <[email protected]>

Hmm, this triggers:

drivers/acpi/nfit/core.c:2276:4: error: flexible array member in a struct with no named members drivers/acpi/nfit/core.c:2287:4: error: flexible array member in a struct with no named members

$ gcc --version
gcc (GCC) 10.2.1 20201016 (Red Hat 10.2.1-6)

I'll need to circle back to this later.