Skip to contentSkip to conversation

crypto: fix flexible_array.cocci warnings

PATCH In review Julia Lawall 2 participants 2 messages Jun 29, 2021 – Jul 16, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: fix flexible_array.cocci warnings

From: kernel test robot <[email protected]>

Zero-length and one-element arrays are deprecated, see Documentation/process/deprecated.rst Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Fixes 7540b2861e52 ("crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ")
CC Megha Dey <[email protected]>

---

tree:   https://github.com/meghadey/crypto for_crypto_avx512
head:   a89c5880f0d6260dd593bf579df26f2a2d56ac32
commit: 7540b2861e5292b5993f8e693fc69510b2a7277a [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ

:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago

 aesni-intel_glue.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/crypto/aesni-intel_glue.c +1 -1
@@ -87,7 +87,7 @@ struct gcm_context_data {
 	u64 partial_block_len;
 	u64 unused;
 	/* Allocate space for hash_keys later */
-	u8 hash_keys[0];
+	u8 hash_keys[];
 };
 
 asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,
maintainer
#1 lore raw
Quoted 27 lines · Julia Lawall

From: kernel test robot <[email protected]>

Zero-length and one-element arrays are deprecated, see Documentation/process/deprecated.rst Flexible-array members should be used instead.

Generated by: scripts/coccinelle/misc/flexible_array.cocci

Fixes 7540b2861e52 ("crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ")
CC Megha Dey <[email protected]>

---

tree:   https://github.com/meghadey/crypto for_crypto_avx512
head:   a89c5880f0d6260dd593bf579df26f2a2d56ac32
commit: 7540b2861e5292b5993f8e693fc69510b2a7277a [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ

:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago

 aesni-intel_glue.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/x86/crypto/aesni-intel_glue.c struct gcm_context_data { · line 90

Quoted 5 lines
arch/x86/crypto/aesni-intel_glue.c +1 -1
@@ -87,7 +87,7 @@ struct gcm_context_data {
 	u64 partial_block_len;
 	u64 unused;
 	/* Allocate space for hash_keys later */
-	u8 hash_keys[0];
+	u8 hash_keys[];

Unfortunately this patch doesn't apply to the current crypto tree. But the good news is that the current tree no longer has a zero- length array in that struct.

Thanks,

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt