Skip to contentSkip to conversation

scsi: ufs: fix itnull.cocci warnings

PATCH New Julia Lawall 1 participant 1 message Mar 26, 2022 SCSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: ufs: fix itnull.cocci warnings

From: kernel test robot <[email protected]>

list_for_each_entry binds rgn to an entry, which cannot be NULL. So remove the first test.

Generated by: scripts/coccinelle/iterators/itnull.cocci

---

tree:   https://github.com/bvanassche/linux ufs-for-next
head:   b93e987f91a0c037fc4357107f5144110cd84d08
commit: b93e987f91a0c037fc4357107f5144110cd84d08 [324/324] scsi: ufs: Split the drivers/scsi/ufs directory

:::::: branch date: 11 hours ago
:::::: commit date: 11 hours ago

Please take the patch only if it's a positive warning. Thanks!

 drivers/scsi/ufs-core/ufshpb.c |    6 ------
 1 file changed, 6 deletions(-)
drivers/scsi/ufs-core/ufshpb.c +0 -6
@@ -875,12 +875,6 @@ static struct ufshpb_region *ufshpb_vict
 	struct ufshpb_region *rgn, *victim_rgn = NULL;
 
 	list_for_each_entry(rgn, &lru_info->lh_lru_rgn, list_lru_rgn) {
-		if (!rgn) {
-			dev_err(&hpb->sdev_ufs_lu->sdev_dev,
-				"%s: no region allocated\n",
-				__func__);
-			return NULL;
-		}
 		if (ufshpb_check_srgns_issue_state(hpb, rgn))
 			continue;