staging: media: imx: imx7-media-csi: Fix parenthesis alignment
PATCH v2 1/1 staging: media: imx: imx7-media-csi: Fix parenthesis alignment
Adhere to Linux kernel coding style.
Reported by checkpatch:
CHECK: Alignment should match open parenthesis
---
Altered changes acording to feedback for a more readable code
drivers/staging/media/imx/imx7-media-csi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/media/imx/imx7-media-csi.c +2 -1
@@ -1704,7 +1704,8 @@ static int imx7_csi_init_cfg(struct v4l2_subdev *sd, mf->xfer_func =V4L2_MAP_XFER_FUNC_DEFAULT (mf->colorspace); mf->ycbcr_enc =V4L2_MAP_YCBCR_ENC_DEFAULT (mf->colorspace); mf->quantization =V4L2_MAP_QUANTIZATION_DEFAULT (!cc->yuv, - mf->colorspace, mf->ycbcr_enc); + mf->colorspace, + mf->ycbcr_enc); csi->cc[i] = cc; }
Signature · 1 line
2.34.1
Quoted 5 lines · Gabriel Lima Luz
Adhere to Linux kernel coding style.
Reported by checkpatch:
CHECK: Alignment should match open parenthesis
Here you have made a decision that is quite reasonable, but that does not actually "Fix parenthesis alignment". This highlights an overall problem with your log message. You say what you are "fixing", but you don't give any explanation about why you have done what you have done. Actually the most helpful comment was below the ---, but that will disappear when the patch is applied.
julia
Quoted 27 lines
Signed-off-by Gabriel Lima Luz <[email protected]>---
Altered changes acording to feedback for a more readable codedrivers/staging/media/imx/imx7-media-csi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/media/imx/imx7-media-csi.c +2
-2@@ -1704,7 +1704,8 @@ static int imx7_csi_init_cfg(struct v4l2_subdev *sd, mf->xfer_func =V4L2_MAP_XFER_FUNC_DEFAULT (mf->colorspace); mf->ycbcr_enc =V4L2_MAP_YCBCR_ENC_DEFAULT (mf->colorspace); mf->quantization =V4L2_MAP_QUANTIZATION_DEFAULT (!cc->yuv, - mf->colorspace, mf->ycbcr_enc); + mf->colorspace, + mf->ycbcr_enc); csi->cc[i] = cc; } --2.34.1