arch/arm64/kernel/mpam/mpam_device.c:1838:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 1841. (fwd)
PATCH 2616/2616 arch/arm64/kernel/mpam/mpam_device.c:1838:1-33: WARNING: Function "for_each_available_child_of_node" should have of_node_put() before break around line 1841. (fwd)
Hello,
I odm't know what mpam_discovery_failed does; maybe it takes care of the needed of_node_put. But normally these are placed explicitly in the loop rather than hidden in some other function, so it could be good to consider doing that here.
julia
---------- Forwarded message ----------
Date: Wed, 1 Jan 2025 14:56:31 +0800
From: kernel test robot <[email protected]>
To: [email protected]
Cc: [email protected], Julia Lawall <[email protected]>
Subject: [openeuler:OLK-5.10 2616/2616]
arch/arm64/kernel/mpam/mpam_device.c:1838:1-33: WARNING: Function
"for_each_available_child_of_node" should have of_node_put() before break
around line 1841.BCC: [email protected]
CC: [email protected]
TO: [email protected]
TO: Zheng Zengkai <[email protected]>
tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: 55bf638d3d29c53ddd64ed89efda8b70b47ccbbc commit: c0ec28ac9769e4df7757ba3ed94295446243ec31 [2616/2616] arm64/mpam: refactor device tree structure to support multiple devices
:::::: branch date: 22 hours ago
:::::: commit date: 2 years, 11 months ago
config: arm64-randconfig-r052-20250101 (https://download.01.org/0day-ci/archive/20250101/[email protected]/config)
compiler: aarch64-linux-gcc (GCC) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]> | Reported-by: Julia Lawall <[email protected]> | Closes: https://lore.kernel.org/r/[email protected]/
cocci warnings: (new ones prefixed by >>)
Quoted 1 line
Quoted 1 line
arch/arm64/kernel/mpam/mpam_device.c:1838:1-33: WARNING: Function "
for_each_available_child_of_node" should haveof_node_put()before break around line 1841.
vim +/for_each_available_child_of_node +1838 arch/arm64/kernel/mpam/mpam_device.c
7926bf06ce9fb8 Xingang Wang 2022-01-10 1817
7926bf06ce9fb8 Xingang Wang 2022-01-10 1818 static int arm_mpam_device_probe(struct platform_device *pdev)
7926bf06ce9fb8 Xingang Wang 2022-01-10 1819 {
7926bf06ce9fb8 Xingang Wang 2022-01-10 1820 int ret;
c0ec28ac9769e4 Xingang Wang 2022-01-29 1821 struct device *dev = &pdev->dev;
c0ec28ac9769e4 Xingang Wang 2022-01-29 1822 struct device_node *node = dev->of_node;
c0ec28ac9769e4 Xingang Wang 2022-01-29 1823 struct device_node *child = NULL;
7926bf06ce9fb8 Xingang Wang 2022-01-10 1824
7926bf06ce9fb8 Xingang Wang 2022-01-10 1825 if (!cpus_have_const_cap(ARM64_HAS_MPAM))
7926bf06ce9fb8 Xingang Wang 2022-01-10 1826 return 0;
7926bf06ce9fb8 Xingang Wang 2022-01-10 1827
7926bf06ce9fb8 Xingang Wang 2022-01-10 1828 if (!acpi_disabled || mpam_enabled != MPAM_ENABLE_OF)
7926bf06ce9fb8 Xingang Wang 2022-01-10 1829 return 0;
7926bf06ce9fb8 Xingang Wang 2022-01-10 1830
c0ec28ac9769e4 Xingang Wang 2022-01-29 1831 if (!node || !of_match_node(arm_mpam_of_device_ids, pdev->dev.of_node))
c0ec28ac9769e4 Xingang Wang 2022-01-29 1832 return -EINVAL;
c0ec28ac9769e4 Xingang Wang 2022-01-29 1833
7926bf06ce9fb8 Xingang Wang 2022-01-10 1834 ret = mpam_discovery_start();
7926bf06ce9fb8 Xingang Wang 2022-01-10 1835 if (ret)
7926bf06ce9fb8 Xingang Wang 2022-01-10 1836 return ret;
7926bf06ce9fb8 Xingang Wang 2022-01-10 1837
c0ec28ac9769e4 Xingang Wang 2022-01-29 @1838 for_each_available_child_of_node(node, child) {
c0ec28ac9769e4 Xingang Wang 2022-01-29 1839 ret = of_mpam_add_child(pdev, child);
c0ec28ac9769e4 Xingang Wang 2022-01-29 1840 if (ret)
c0ec28ac9769e4 Xingang Wang 2022-01-29 @1841 break;
c0ec28ac9769e4 Xingang Wang 2022-01-29 1842 }
7926bf06ce9fb8 Xingang Wang 2022-01-10 1843
7926bf06ce9fb8 Xingang Wang 2022-01-10 1844 if (ret) {
7926bf06ce9fb8 Xingang Wang 2022-01-10 1845 mpam_discovery_failed();
7926bf06ce9fb8 Xingang Wang 2022-01-10 1846 } else {
7926bf06ce9fb8 Xingang Wang 2022-01-10 1847 ret = mpam_discovery_complete();
7926bf06ce9fb8 Xingang Wang 2022-01-10 1848 if (!ret)
7926bf06ce9fb8 Xingang Wang 2022-01-10 1849 pr_info("Successfully init mpam by DT.\n");
7926bf06ce9fb8 Xingang Wang 2022-01-10 1850 }
7926bf06ce9fb8 Xingang Wang 2022-01-10 1851
7926bf06ce9fb8 Xingang Wang 2022-01-10 1852 return ret;
7926bf06ce9fb8 Xingang Wang 2022-01-10 1853 }
7926bf06ce9fb8 Xingang Wang 2022-01-10 1854Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki