SYNCLINK: Standardize format of linux header file include's with "<>".
PATCH 1/1 SYNCLINK: Standardize format of linux header file include's with "<>".
Use the recommended form of "<>" to include linux header files, and move those includes up to join the rest of the linux includes.
---
outside of the UML stuff, there are precious few examples of including headers out of include/linux that don't use the "<>" notation, so clean them up. and it makes my scanning scripts simpler, too. so, yes, it *is* all about me.
not compile tested, it seemed pretty straightforward.
drivers/char/pcmcia/synclink_cs.c | 3 +-- drivers/char/synclink.c | 3 +-- drivers/char/synclink_gt.c | 3 +-- drivers/char/synclinkmp.c | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-)
drivers/char/pcmcia/synclink_cs.c +1 -2
@@ -57,6 +57,7 @@#include <linux/init.h> #include <linux/delay.h> #include <linux/ioctl.h> +#include <linux/synclink.h> #include <asm/system.h> #include <asm/io.h>
@@ -87,8 +88,6 @@#include <asm/uaccess.h> -#include "linux/synclink.h" -static MGSL_PARAMS default_params = {MGSL_MODE_HDLC ,/* unsigned long mode */ 0 ,/* unsigned char loopback; */
drivers/char/synclink.c +1 -2
@@ -85,6 +85,7 @@#include <linux/vmalloc.h> #include <linux/init.h> #include <linux/ioctl.h> +#include <linux/synclink.h> #include <asm/system.h> #include <asm/io.h>
@@ -110,8 +111,6 @@#include <asm/uaccess.h> -#include "linux/synclink.h" -#define RCLRVALUE 0xffffstatic MGSL_PARAMS default_params = {
drivers/char/synclink_gt.c +1 -2
@@ -73,6 +73,7 @@#include <linux/bitops.h> #include <linux/workqueue.h> #include <linux/hdlc.h> +#include <linux/synclink.h> #include <asm/system.h> #include <asm/io.h>
@@ -81,8 +82,6 @@#include <asm/types.h> #include <asm/uaccess.h> -#include "linux/synclink.h" -#if defined(CONFIG_HDLC ) || (defined(CONFIG_HDLC_MODULE ) && defined(CONFIG_SYNCLINK_GT_MODULE ))#define SYNCLINK_GENERIC_HDLC 1#else
drivers/char/synclinkmp.c +1 -2
@@ -66,6 +66,7 @@#include <linux/termios.h> #include <linux/workqueue.h> #include <linux/hdlc.h> +#include <linux/synclink.h> #if defined(CONFIG_HDLC ) || (defined(CONFIG_HDLC_MODULE ) && defined(CONFIG_SYNCLINKMP_MODULE ))#define SYNCLINK_GENERIC_HDLC 1
@@ -80,8 +81,6 @@#include <asm/uaccess.h> -#include "linux/synclink.h" -static MGSL_PARAMS default_params = {MGSL_MODE_HDLC ,/* unsigned long mode */ 0 ,/* unsigned char loopback; */
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry Waterloo, Ontario, CANADA
http://crashcourse.ca
========================================================================