Skip to contentSkip to conversation

x86: make mxcsr_feature_mask static again

PATCH Applied Adrian Bunk 3 participants 4 messages Feb 13, 2008 – Feb 17, 2008 x86

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: make mxcsr_feature_mask static again

mxcsr_feature_mask needlessly became global.

---

 arch/x86/kernel/i387.c |    2 +-
 include/asm-x86/i387.h |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

76adc866d04ed20a5b2eb548920f93ad87268cbd

arch/x86/kernel/i387.c +1 -1
index 26719bd..763dfc4 100644
@@ -39,7 +39,7 @@
 #define HAVE_HWFP 1
 #endif
 
-unsigned int mxcsr_feature_mask __read_mostly = 0xffffffffu;
+static unsigned int mxcsr_feature_mask __read_mostly = 0xffffffffu;
 
 void mxcsr_feature_mask_init(void)
 {
include/asm-x86/i387.h +0 -1
index ba8105c..4c7706a 100644
@@ -19,7 +19,6 @@
 #include <asm/uaccess.h>
 
 extern void fpu_init(void);
-extern unsigned int mxcsr_feature_mask;
 extern void mxcsr_feature_mask_init(void);
 extern void init_fpu(struct task_struct *child);
 extern asmlinkage void math_state_restore(void);
#1 lore raw

Good change. Making it global was needed temporarily in between some of the i387 unification patches, but is unnecessary after the final merge.

Thanks,
Roland

#3 lore raw
In reply to Adrian Bunk
Quoted 3 lines · Adrian Bunk

mxcsr_feature_mask needlessly became global.

Applied along with the other x86 ones.

Thanks,
tglx

Quoted 39 lines

---

 arch/x86/kernel/i387.c |    2 +-
 include/asm-x86/i387.h |    1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

76adc866d04ed20a5b2eb548920f93ad87268cbd

arch/x86/kernel/i387.c +1 -1
index 26719bd..763dfc4 100644
@@ -39,7 +39,7 @@
 #define HAVE_HWFP 1
 #endif
 
-unsigned int mxcsr_feature_mask __read_mostly = 0xffffffffu;
+static unsigned int mxcsr_feature_mask __read_mostly = 0xffffffffu;
 
 void mxcsr_feature_mask_init(void)
 {
include/asm-x86/i387.h +0 -2
index ba8105c..4c7706a 100644
@@ -19,7 +19,6 @@
 #include <asm/uaccess.h>
 
 extern void fpu_init(void);
-extern unsigned int mxcsr_feature_mask;
 extern void mxcsr_feature_mask_init(void);
 extern void init_fpu(struct task_struct *child);
 extern asmlinkage void math_state_restore(void);
 
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/