Skip to contentSkip to conversation

is "pci_find_subsys" safe to remove?

DISCUSSION Robert P. J. Day 2 participants 3 messages Feb 25, 2008 – Feb 26, 2008

lore
Share & tools
lore
#0 lore raw

it's not just that it falls under the category of PCI "legacy" but,
if you look in drivers/pci/search.c near the bottom:

...
#ifdef CONFIG_PCI_LEGACY
EXPORT_SYMBOL(pci_find_device);
EXPORT_SYMBOL(pci_find_slot);
#endif /* CONFIG_PCI_LEGACY */
...

that symbol is not being exported even *if* you select PCI_LEGACY. i'm guessing that's an oversight but it would certainly suggest that no one can possibly be using it, no?

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================

#1 lore raw
Quoted 11 lines · Robert P. J. Day

it's not just that it falls under the category of PCI "legacy" but,
if you look in drivers/pci/search.c near the bottom:

...
#ifdef CONFIG_PCI_LEGACY
EXPORT_SYMBOL(pci_find_device);
EXPORT_SYMBOL(pci_find_slot);
#endif /* CONFIG_PCI_LEGACY */
...

Quoted 3 lines

that symbol is not being exported even *if* you select PCI_LEGACY. i'm guessing that's an oversight but it would certainly suggest that no one can possibly be using it, no?

It's used by pci_find_device().

Quoted 1 line

rday

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw
Quoted 12 lines · Adrian Bunk
Quoted 11 lines · Robert P. J. Day

it's not just that it falls under the category of PCI "legacy" but,
if you look in drivers/pci/search.c near the bottom:

...
#ifdef CONFIG_PCI_LEGACY
EXPORT_SYMBOL(pci_find_device);
EXPORT_SYMBOL(pci_find_slot);
#endif /* CONFIG_PCI_LEGACY */
...

Quoted 5 lines
Quoted 3 lines

that symbol is not being exported even *if* you select PCI_LEGACY. i'm guessing that's an oversight but it would certainly suggest that no one can possibly be using it, no?

It's used by pci_find_device().

yes, i noticed that shortly after hitting the ENTER key. sigh. it was a long day ...

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================