Skip to contentSkip to conversation

FS: Label tmpfs Kconfig option with "tmpfs".

PATCH In review Robert P. J. Day 2 participants 3 messages Jul 7, 2008 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 FS: Label tmpfs Kconfig option with "tmpfs".

Make it clear that the Kconfig option refers to "tmpfs".

---

if people haven't yet figured out that this used to be shm fs, they
probably don't need to know.

fs/Kconfig +1 -1
index 2694648..9360b69 100644
@@ -979,7 +979,7 @@ config SYSFS
 	Designers of embedded systems may wish to say N here to conserve space.
 
 config TMPFS
-	bool "Virtual memory file system support (former shm fs)"
+	bool "tmpfs support (Virtual memory file system)"
 	help
 	  Tmpfs is a file system which keeps all files in virtual memory.
 

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================

Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Robert P. J. Day

Make it clear that the Kconfig option refers to "tmpfs".

It's so long since I used anything but "make oldconfig", which already shows TMPFS, making your mod seem redundant. But you're right, menuconfig and xconfig don't show it, so your change is a good one.

Though for the moment I can only give you

the next entry is for "Tmpfs POSIX Access Control Lists" so I'd rather you say "Tmpfs support (virtual memory file system)", then you can uppercase my ack.

hugh

Quoted 20 lines

---

if people haven't yet figured out that this used to be shm fs, they
probably don't need to know.

fs/Kconfig +1 -1
index 2694648..9360b69 100644
@@ -979,7 +979,7 @@ config SYSFS
 	Designers of embedded systems may wish to say N here to conserve space.
 
 config TMPFS
-	bool "Virtual memory file system support (former shm fs)"
+	bool "tmpfs support (Virtual memory file system)"
 	help
 	  Tmpfs is a file system which keeps all files in virtual memory.
 
#2 lore raw
Quoted 10 lines · Hugh Dickins
Quoted 4 lines · Robert P. J. Day

Make it clear that the Kconfig option refers to "tmpfs".

It's so long since I used anything but "make oldconfig", which already shows TMPFS, making your mod seem redundant. But you're right, menuconfig and xconfig don't show it, so your change is a good one.

Quoted 5 lines

Though for the moment I can only give you

the next entry is for "Tmpfs POSIX Access Control Lists" so I'd rather you say "Tmpfs support (virtual memory file system)", then you can uppercase my ack.

or i could change the next line to read "tmpfs" rather than "Tmpfs". :-) does anyone have any strong feelings either way?

rday
--

========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry:
Have classroom, will lecture.

http://crashcourse.ca Waterloo, Ontario, CANADA
========================================================================