Skip to contentSkip to conversation

parser: add const to parser token table (resend)

PATCH Steven Whitehouse 3 participants 4 messages Jul 24, 2008

lore
Share & tools
lore
#0 lore raw

This patch adds a "const" to the parser token table. I've done an allmodconfig build to see if this produces any warnings/failures and the patch includes a fix for the only warning that was produced.

fs/ufs/super.c +1 -1
index 85b22b5..506f724 100644
@@ -1232,7 +1232,7 @@ static int ufs_show_options(struct seq_file *seq, struct vfsmount *vfs)
 {
 	struct ufs_sb_info *sbi = UFS_SB(vfs->mnt_sb);
 	unsigned mval = sbi->s_mount_opt & UFS_MOUNT_UFSTYPE;
-	struct match_token *tp = tokens;
+	const struct match_token *tp = tokens;
 
 	while (tp->token != Opt_onerror_panic && tp->token != mval)
 		++tp;
include/linux/parser.h +1 -1
index 7dcd050..cc554ca 100644
@@ -14,7 +14,7 @@ struct match_token {
 	const char *pattern;
 };
 
-typedef struct match_token match_table_t[];
+typedef const struct match_token match_table_t[];
 
 /* Maximum number of arguments that match_token will find in a pattern */
 enum {MAX_OPT_ARGS = 3};
#1 lore raw

Btw, the reason I didn't even look at this at first is that there is no such thing as a "parser" in the kernel, so I just dismissed the patch as being to somebody else (ie a sparse thing).

Now, if the subject had been something like

UFS: add const to parser token table

I would have realized that it was relevant to my interests

What I'm trying to say is that subject lines matter ;)

Linus

#2 lore raw
Quoted 4 lines · Linus Torvalds

Btw, the reason I didn't even look at this at first is that there is no such thing as a "parser" in the kernel, so I just dismissed the patch as being to somebody else (ie a sparse thing).

Just to clarify: there obviously _is_ a "parser", but it's at such a low level that tagging by it doesn't much help my mental picture, when there are other projects I'm involved with where the "parser" is a much more integral and major deal.

Linus

#3 lore raw
In reply to Linus Torvalds
Quoted 3 lines · Linus Torvalds

Btw, the reason I didn't even look at this at first is that there is no such thing as a "parser" in the kernel,

Well, there's lib/parser.c and include/linux/parser.h..